StarMirror/toxcore
1
0
Fork 0
mirror of https://github.com/irungentoo/toxcore.git synced 2024-03-22 13:30:51 +08:00
Code Issues Projects Releases Wiki Activity

Remove pointless nullity check on array address

Browse Source 
assoc->self_client_id is always true, therefore we can remove it from that if" -m "The if thus asserts !assoc->self_hash, so we can elide the immediately following if (!assoc->self_hash)
This commit is contained in:
tux3 2015-05-19 19:53:55 +02:00
parent 8760aba257
commit 19bd38999b
No known key found for this signature in database
GPG Key ID: 7E086DD661263264
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
toxcore/assoc.c
View File

@ -510,20 +510,18 @@ static uint8_t candidates_create_new(const Assoc *assoc, hash_t hash, const uint
static void client_id_self_update(Assoc *assoc)
{
if (assoc->self_hash || !assoc->self_client_id)
if (assoc->self_hash)
return;
if (!assoc->self_hash) {
size_t i, sum = 0;
size_t i, sum = 0;
for (i = 0; i < crypto_box_PUBLICKEYBYTES; i++)
sum |= assoc->self_client_id[i];
for (i = 0; i < crypto_box_PUBLICKEYBYTES; i++)
sum |= assoc->self_client_id[i];
if (!sum)
return;
if (!sum)
return;
assoc->self_hash = id_hash(assoc, assoc->self_client_id);
}
assoc->self_hash = id_hash(assoc, assoc->self_client_id);
LOGGER_DEBUG("id is now set, purging cache of self-references");
@ -532,7 +530,7 @@ static void client_id_self_update(Assoc *assoc)
*/
bucket_t b_id = candidates_id_bucket(assoc, assoc->self_client_id);
candidates_bucket *cnd_bckt = &assoc->candidates[b_id];
size_t i, pos = assoc->self_hash % assoc->candidates_bucket_size;
size_t pos = assoc->self_hash % assoc->candidates_bucket_size;
for (i = 0; i < HASH_COLLIDE_COUNT; pos = hash_collide(assoc, pos), i++) {
Client_entry *entry = &cnd_bckt->list[pos];