StarMirror/toxcore
1
0
Fork 0
mirror of https://github.com/irungentoo/toxcore.git synced 2024-03-22 13:30:51 +08:00
Code Issues Projects Releases Wiki Activity

Added minor error checking in Core, this helps prevent CERT MEM04-C; CWE-131

Browse Source
This commit is contained in:
Sean Qureshi 2013-08-18 01:26:11 -07:00
parent 71bc275284
commit 17d3878174
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/Messenger.c
View File

@ -37,8 +37,9 @@ static int write_cryptpacket_id(Messenger *m, int friendnumber, uint8_t packet_i
return -1 if realloc fails */ return -1 if realloc fails */
int realloc_friendlist(Messenger *m, uint32_t num) int realloc_friendlist(Messenger *m, uint32_t num)
{ {
if (num * sizeof(Friend) == 0) return -1;
Friend *newfriendlist = realloc(m->friendlist, num * sizeof(Friend)); Friend *newfriendlist = realloc(m->friendlist, num * sizeof(Friend));
if (newfriendlist == NULL && num != 0) if (newfriendlist == NULL && num != 0)
return -1; return -1;
@ -597,7 +598,6 @@ int write_cryptpacket_id(Messenger *m, int friendnumber, uint8_t packet_id, uint
/*Interval in seconds between LAN discovery packet sending*/ /*Interval in seconds between LAN discovery packet sending*/
#define LAN_DISCOVERY_INTERVAL 60 #define LAN_DISCOVERY_INTERVAL 60
#define PORT 33445 #define PORT 33445
/*Send a LAN discovery packet every LAN_DISCOVERY_INTERVAL seconds*/ /*Send a LAN discovery packet every LAN_DISCOVERY_INTERVAL seconds*/
@ -971,4 +971,3 @@ int Messenger_load(Messenger *m, uint8_t *data, uint32_t length)
return 0; return 0;
} }