StarMirror/toxcore
1
0
Fork 0
mirror of https://github.com/irungentoo/toxcore.git synced 2024-03-22 13:30:51 +08:00
Code Issues Projects Releases Wiki Activity
7a6d50ebe3
toxcore/.github/workflows/sonar-scan.yml

57 lines
2.3 KiB
YAML
Raw Normal View History

chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
name: sonar-scan
on:
push:
branches: [master]
chore: Don't run sonar scan on pull requests. This reverts commit e3d20afc6a36869531dde7b9155a5312c70c67d5. It doesn't work.
2022-01-18 08:07:42 +08:00
pull_request:
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
branches: [master]
chore: Cancel old PR builds on docker and sonar-scan workflows. Also, don't error on test failures on windows (they are very flaky).
2023-11-23 05:28:18 +08:00
# Cancel old PR builds when pushing new commits.
concurrency:
group: scan-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
jobs:
sonar-scan:
runs-on: ubuntu-latest
env:
chore: Upgrade sonar-scan jvm to java 17. https://community.sonarsource.com/t/java-11-is-deprecated-as-a-runtime-env-to-scan-your-projects/9659
2023-11-23 18:56:32 +08:00
SONAR_SCANNER_VERSION: 5.0.1.3006
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
SONAR_SERVER_URL: "https://sonarcloud.io"
BUILD_WRAPPER_OUT_DIR: build_wrapper_output_directory # Directory where build-wrapper output will be placed
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
refactor: Use cmp instead of msgpack-c for events packing. This library is better in every way.
2022-03-25 02:16:45 +08:00
submodules: recursive
chore: Upgrade sonar-scan jvm to java 17. https://community.sonarsource.com/t/java-11-is-deprecated-as-a-runtime-env-to-scan-your-projects/9659
2023-11-23 18:56:32 +08:00
- name: Set up JDK 17
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
uses: actions/setup-java@v1
with:
chore: Upgrade sonar-scan jvm to java 17. https://community.sonarsource.com/t/java-11-is-deprecated-as-a-runtime-env-to-scan-your-projects/9659
2023-11-23 18:56:32 +08:00
java-version: 17
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
- name: Download and set up sonar-scanner
env:
SONAR_SCANNER_DOWNLOAD_URL: https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${{ env.SONAR_SCANNER_VERSION }}-linux.zip
run: |
mkdir -p $HOME/.sonar
curl -sSLo $HOME/.sonar/sonar-scanner.zip ${{ env.SONAR_SCANNER_DOWNLOAD_URL }}
unzip -o $HOME/.sonar/sonar-scanner.zip -d $HOME/.sonar/
echo "$HOME/.sonar/sonar-scanner-${{ env.SONAR_SCANNER_VERSION }}-linux/bin" >> $GITHUB_PATH
- name: Download and set up build-wrapper
env:
BUILD_WRAPPER_DOWNLOAD_URL: ${{ env.SONAR_SERVER_URL }}/static/cpp/build-wrapper-linux-x86.zip
run: |
curl -sSLo $HOME/.sonar/build-wrapper-linux-x86.zip ${{ env.BUILD_WRAPPER_DOWNLOAD_URL }}
unzip -o $HOME/.sonar/build-wrapper-linux-x86.zip -d $HOME/.sonar/
echo "$HOME/.sonar/build-wrapper-linux-x86" >> $GITHUB_PATH
- name: Install dependencies and prepare build
chore: Don't run sonar scan on pull requests. This reverts commit e3d20afc6a36869531dde7b9155a5312c70c67d5. It doesn't work.
2022-01-18 08:07:42 +08:00
run: |
.github/scripts/sonar-prepare
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
- name: Run build-wrapper
chore: Don't run sonar scan on pull requests. This reverts commit e3d20afc6a36869531dde7b9155a5312c70c67d5. It doesn't work.
2022-01-18 08:07:42 +08:00
run: |
build-wrapper-linux-x86-64 --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} .github/scripts/sonar-build
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
- name: Run sonar-scanner
chore: Don't run sonar scan on pull requests. This reverts commit e3d20afc6a36869531dde7b9155a5312c70c67d5. It doesn't work.
2022-01-18 08:07:42 +08:00
if: github.event_name == 'push'
chore: Add sonar-scan analysis on pushes. We can't run this on pull requests because it needs access to the `SONAR_TOKEN` secret. Perhaps in the future we can make it a `pull_request_target` workflow, but then we can't use cmake to initialise the environment, meaning we need to specify the inputs manually.
2022-01-14 20:08:29 +08:00
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
cleanup: Remove uses of `strcpy` and `sprintf`. Use of `strcpy` in these particular cases was safe, but it's hard to tell and also useless. `strcpy` would effectively need to do another `strlen` which we already did. Also removed sprintf, which was also safe in this case but it's easier to be "obviously safe", especially for static analysers.
2022-01-17 18:01:26 +08:00
run: 'sonar-scanner --define sonar.host.url="${{ env.SONAR_SERVER_URL }}" --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}"'
Reference in New Issue Copy Permalink