Stephane Moore
0c88671aa8
Merge pull request #269 from google/update-objc
...
[objc] Update the Objective-C style guide 📜
2017-08-23 18:37:49 -07:00
Stephane Moore
82d0af2190
[objc] Update the Objective-C style guide 📜
...
Revision Date: 8/23/2017
2017-08-23 14:59:52 -07:00
Stephane Moore
d6bc013ece
[objc] Make objcguide.xml link to objcguide.md 🔄
...
There are links out in the wild to the old XML style guide. An XML file that links to the new style guide location ensures that those links are not completely broken.
2017-08-23 14:57:27 -07:00
Mark Mentovai
de57acaedf
Update link to Objective-C style guide
2017-08-22 18:16:59 -04:00
Mark Mentovai
0d23d722dc
Merge pull request #267 from stephanemoore/update-objc
...
[objc] Update the Objective-C style guide 📜
2017-08-22 18:14:33 -04:00
Kevin Lindkvist
c5197bfc48
[objc] Update the Objective-C style guide 📜
...
Revision Date: 8/16/2017
2017-08-17 14:47:20 -07:00
Elliot Glaysher
62385582b8
Merge pull request #162 from ctubbsii/eclipse-formatter-on-off-tags
...
Enabling formatter on/off tags
2017-08-15 10:14:04 -07:00
Eric Anderson
77f7f28d31
Merge pull request #153 from alanyee/gh-pages
...
Update broken link
2017-08-07 14:14:44 -07:00
Alexander Artemenko
2fb66df7d3
Fixed "full hairy example" of formatting control string
...
Example produced wrong results:
```
CL-USER> (format nil "Items:~#[ none~; ~S~; ~S and ~S~:;~@{~#[~; and~] ~S~^ ,~}~]." :foo :bar :baz :kadabr)
"Items: :FOO , :BAR , :BAZ , and :KADABR."
```
With this fix, it uses commas correctly:
```
CL-USER> (format nil "Items: ~#[ none~; ~S~; ~S and ~S~:;~@{~S~^~#[~; and ~:;, ~]~}~]." :foo :bar :baz :kadabr)
"Items: :FOO, :BAR, :BAZ and :KADABR."
```
2017-07-30 21:28:02 +03:00
Elliot Glaysher
6c8669edb2
Fix test regression from 9883c51578
.
2017-07-28 14:54:33 -07:00
Elliot Glaysher
0c1c7f193f
Merge pull request #265 from hammacher/remove-disallow-presubmit-check
...
Remove presubmit check for DISALLOW_* macros
2017-07-26 10:59:27 -07:00
Clemens Hammacher
9883c51578
Remove presubmit check for DISALLOW_* macros
...
Before C++11, we were using a hack to disable copy constructors or copy
assignment by declaring the methods private and not implementing them.
This hack required the respective macros to be placed in the private:
declarations of a class.
The macros have switched to use the C++11 "= delete" syntax some time
ago in both v8 and chromium:
https://codereview.chromium.org/1123723003/
https://codereview.chromium.org/2017213002
Also the comments are now updated, since the macros do not need to be
in the private: declarations any more:
https://chromium-review.googlesource.com/c/577687
https://chromium-review.googlesource.com/c/578027
This change also removes the presubmit check that checked that the
macros are only used in the private declarations.
2017-07-24 12:57:05 +02:00
Elliot Glaysher
d75bd35c8f
Merge pull request #261 from jrobinson2/gh-pages
...
Fixed a typo.
2017-06-29 23:25:26 -07:00
James Robinson II
6161e33d8a
Fixed a typo.
2017-06-29 22:16:49 -04:00
Mark Mentovai
85799e8cd3
Merge pull request #257 from kwalrath/patch-1
...
Tweak URL for Go style guide
2017-06-22 17:03:13 -04:00
Kathy Walrath
2886a3f454
Tweak URL for Go style guide
2017-06-22 14:02:14 -07:00
Mark Mentovai
a11ef46100
Merge pull request #256 from kwalrath/patch-1
...
Add Dart style guide
2017-06-22 16:40:51 -04:00
Mark Mentovai
470a53f383
Reverse order of [dart] and [go] to match prose
2017-06-22 16:39:56 -04:00
Kathy Walrath
bb56ab5026
Change link to Go style guide
2017-06-22 12:30:50 -07:00
Kathy Walrath
8aab535ade
Add Dart style guide
...
* Added Go while I was in there. (@rakyll or @adg might have feedback on the link I used)
* Rewrote things a bit to make the new links fit.
* Copy edited a bit because I couldn't help myself.
2017-06-22 11:26:59 -07:00
Elliot Glaysher
142b0e64ba
Merge pull request #250 from kirkins/patch-1
...
Fix broken link
2017-05-26 13:14:04 -07:00
Philip Kirkbride
e3d0f56bcd
Fix broken link
...
Same guide is also linked on line 1144, but uses correct url (.html)
2017-05-26 15:45:00 -04:00
Stephen Hicks
c212f99186
Update JS style guide
2017-05-08 16:24:00 -07:00
Elliot Glaysher
d012c72624
Merge pull request #244 from schoetbi/FixVs7Oput
...
Changed vs7 output format so that Visual Studio can parse the error
2017-05-03 10:15:59 -07:00
schoetbi
819c572b4c
Changed vs7 output format so that Visual Studio can parse the error messages correctly
...
Also Visual Studio can jump to the correct file/linenumber
2017-05-03 10:11:03 +02:00
Elliot Glaysher
15f2836d9f
Merge pull request #230 from danakj/gh-pages
...
Teach the explicit constructor check about constexpr.
2017-03-02 10:23:49 -08:00
Dana Jansens
2db65fed51
Add unit tests for constexpr constructors
...
This also adds unit tests for inline+explicit constructors being okay,
with and without constexpr.
2017-03-02 13:20:12 -05:00
Liam Miller-Cushon
594d91bfbb
Update Java style guide
2017-02-28 21:12:14 -08:00
Tony Ruscoe
9fe17f92b7
Merge pull request #235 from tonyruscoe/html-css-style-validation
...
Fix HTML validation warnings and make the style guide HTML more compliant.
2017-02-27 09:33:22 +00:00
Tony Ruscoe
ad6dee81e9
Fix HTML validation warnings and make the style guide HTML more compliant.
2017-02-27 08:16:24 +00:00
Tony Ruscoe
b726be1588
Merge pull request #233 from tonyruscoe/gh-pages-anchor-and-emphasis
...
Add an anchor for the “Parting Words” section and change the emphasis on “Be consistent.”
2017-02-24 14:43:16 +00:00
Tony Ruscoe
a1773f9b3b
Add an anchor for the “Parting Words” section and change the emphasis on “Be consistent.”
2017-02-24 14:38:42 +00:00
Tony Ruscoe
d0960a41c0
Move, update, and convert HTML/CSS Style Guide from XML to HTML. ( #232 )
2017-02-24 12:31:41 +00:00
Dana Jansens
cf4071cf5d
Teach the explicit constructor check about constexpr.
...
If a constructor is marked constexpr it evades the explicit constructor
check right now, since the check only knows about the inline keyword.
Teach it that constexpr can be used also.
2017-02-22 12:02:39 -05:00
Geoff Romer
b282a74fea
Merge pull request #210 from roooooooot/patch-1
...
Fix a typo
2017-01-05 10:22:11 -08:00
roooooooot
a33bdd6e3a
Fix a typo
...
requre -> require
2016-12-31 13:10:07 +08:00
Dan Beam
159b4c81bb
Restore ES5 styleguide
...
Leave links in README.md and other style guides pointing to ES6.
This is a partial revert of 8f254427d9
2016-12-22 12:06:27 -08:00
Michael Plump
75c289f1d3
Update the IntelliJ style to the latest version from Google.
...
Internally, we use the google-java-format plugin to format our Java
files. It's much more rigorous and ignores the contents of this XML
file. Using that plugin should be the preferred way to make sure your
code conforms to Google's style.
2016-12-22 12:05:18 -08:00
Stephen Hicks
db0a26320f
Update Java and C++ style guides with various changes since the last update.
2016-11-17 18:02:44 -08:00
Stephen Hicks
8f254427d9
Update and replace JavaScript style guide.
...
The new guide is completely rewritten in light of ES2015. The old guide
has been replaced with a link to the new guide.
2016-11-17 18:02:23 -08:00
Elliot Glaysher
71ec7f1e52
Merge pull request #187 from google/revert-169-gh-pages
...
Revert "Fix the `cpplint.py` `build/endif_comment` check."
2016-09-30 15:35:21 -07:00
Elliot Glaysher
ae11811f81
Revert "Fix the cpplint.py
build/endif_comment
check."
2016-09-30 15:34:26 -07:00
Elliot Glaysher
aa8ccb418c
Merge pull request #184 from LukeCz/stdout
...
Cpplint is unnecessarily polluting stderr
2016-09-29 11:03:52 -07:00
LukeCz
e09f478aa8
Cpplint is unnecessarily polluting stderr
2016-09-28 19:13:37 -05:00
Elliot Glaysher
389efa293d
Merge pull request #183 from LukeCz/hpp-headers
...
Configurable header extensions
2016-09-27 10:06:56 -07:00
LukeCz
8920b13221
Changes after review
2016-09-26 19:40:47 -05:00
LukeCz
7197a244ea
Configurable header extensions
...
Fix for #50 , #79 and #113
2016-09-24 13:27:35 -05:00
Elliot Glaysher
1342002613
Merge pull request #169 from arames/gh-pages
...
Fix the `cpplint.py` `build/endif_comment` check.
2016-09-21 10:03:30 -07:00
Alexandre Rames
f558944179
Fix the build/endif_comment
check.
...
- The check needs to be run before we remove comments, otherwise valid
lines will be found as invalid.
- A single character different from `/` after the spaces is enough to
indicate an error.
- Also catch errors when only one `/` is present.
(For example `#endif / MY_FILE_H`.)
2016-09-21 11:03:34 +01:00
Christopher Tubbs
1fc370987b
Enabling formatter on/off tags
...
Allows overriding Eclipse formatter in order to comply with the
guidelines, when Eclipse formatter doesn't work.
2016-07-21 15:24:01 -04:00