StarMirror/styleguide
1
0
Fork 0
mirror of https://github.com/google/styleguide.git synced 2024-03-22 13:11:43 +08:00
Code Issues Projects Releases Wiki Activity

Unit tests for variadic argument constructors

Browse Source 
Explicit variadic constructors can be marked explicit as they can have
one or more arguments
This commit is contained in:
Matt Clarkson 2015-10-02 11:06:36 +01:00
parent 3591b2e540
commit 155994a4bd
1 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
cpplint/cpplint_unittest.py
View File

@ -1338,6 +1338,47 @@ class CpplintTest(CpplintTestBase):
Foo(std::initializer_list<T> &arg) {} Foo(std::initializer_list<T> &arg) {}
};""", };""",
'') '')
# Special case for variadic arguments
error_collector = ErrorCollector(self.assert_)
cpplint.ProcessFileData('foo.cc', 'cc',
['class Foo {',
' template<typename... Args>',
' explicit Foo(const int arg, Args&&... args) {}',
'};'],
error_collector)
self.assertEquals(0, error_collector.ResultList().count(
'Constructors that require multiple arguments should not be marked '
'explicit. [runtime/explicit] [0]'))
error_collector = ErrorCollector(self.assert_)
cpplint.ProcessFileData('foo.cc', 'cc',
['class Foo {',
' template<typename... Args>',
' explicit Foo(Args&&... args) {}',
'};'],
error_collector)
self.assertEquals(0, error_collector.ResultList().count(
'Constructors that require multiple arguments should not be marked '
'explicit. [runtime/explicit] [0]'))
error_collector = ErrorCollector(self.assert_)
cpplint.ProcessFileData('foo.cc', 'cc',
['class Foo {',
' template<typename... Args>',
' Foo(const int arg, Args&&... args) {}',
'};'],
error_collector)
self.assertEquals(1, error_collector.ResultList().count(
'Constructors callable with one argument should be marked explicit.'
' [runtime/explicit] [5]'))
error_collector = ErrorCollector(self.assert_)
cpplint.ProcessFileData('foo.cc', 'cc',
['class Foo {',
' template<typename... Args>',
' Foo(Args&&... args) {}',
'};'],
error_collector)
self.assertEquals(1, error_collector.ResultList().count(
'Constructors callable with one argument should be marked explicit.'
' [runtime/explicit] [5]'))
# Anything goes inside an assembly block # Anything goes inside an assembly block
error_collector = ErrorCollector(self.assert_) error_collector = ErrorCollector(self.assert_)
cpplint.ProcessFileData('foo.cc', 'cc', cpplint.ProcessFileData('foo.cc', 'cc',