StarMirror/showdown
1
0
Fork 0
mirror of https://github.com/showdownjs/showdown.git synced 2024-03-22 13:30:55 +08:00
Code Issues Projects Releases Wiki Activity

fix(ghCompatibleHeaderId): improve the number of removed chars

Browse Source
This commit is contained in:
Estevao Soares dos Santos 2016-12-30 19:46:46 +00:00
parent 150a5cd3ff
commit d499feb2aa
9 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -189,7 +189,7 @@ var defaultOptions = showdown.getDefaultOptions();
* **noHeaderId**: (boolean) [default false] Disable the automatic generation of header ids. Setting to true overrides **prefixHeaderId** * **noHeaderId**: (boolean) [default false] Disable the automatic generation of header ids. Setting to true overrides **prefixHeaderId**
* **ghCompatibleHeaderId**: (boolean) [default false] Generate header ids compatible with github style (spaces are replaced with dashes, ][&~$!@#*()=:/,;?+'.%\ chars are removed) (since v1.5.5) * **ghCompatibleHeaderId**: (boolean) [default false] Generate header ids compatible with github style (spaces are replaced with dashes and a bunch of non alphanumeric chars are removed) (since v1.5.5)
* **prefixHeaderId**: (string/boolean) [default false] Add a prefix to the generated header ids. Passing a string will prefix that string to the header id. Setting to `true` will add a generic 'section' prefix. * **prefixHeaderId**: (string/boolean) [default false] Add a prefix to the generated header ids. Passing a string will prefix that string to the header id. Setting to `true` will add a generic 'section' prefix.

BIN
dist/showdown.js vendored
View File

Binary file not shown.

BIN
dist/showdown.js.map vendored
View File

Binary file not shown.

BIN
dist/showdown.min.js vendored
View File

Binary file not shown.

BIN
dist/showdown.min.js.map vendored
View File

Binary file not shown.

2
src/options.js
View File

@ -23,7 +23,7 @@ function getDefaultOpts(simple) {
}, },
ghCompatibleHeaderId: { ghCompatibleHeaderId: {
defaultValue: false, defaultValue: false,
describe: 'Generate header ids compatible with github style (spaces are replaced with dashes, &~$!@#*()=:/,;?+%\\\'. chars are removed)', describe: 'Generate header ids compatible with github style (spaces are replaced with dashes, a bunch of non alphanumeric chars are removed)',
type: 'string' type: 'string'
}, },
headerLevelStart: { headerLevelStart: {

3
src/subParsers/headers.js
View File

@ -63,7 +63,8 @@ showdown.subParser('headers', function (text, options, globals) {
.replace(/~T/g, '') .replace(/~T/g, '')
.replace(/~D/g, '') .replace(/~D/g, '')
//replace rest of the chars (&~$ are repeated as they might have been escaped) //replace rest of the chars (&~$ are repeated as they might have been escaped)
.replace(/[&~$!@#*()=:/,;?+'.%\\]/g, '') // borrowed from github's redcarpet (some they should produce similar results)
.replace(/[&+$,\/:;=?@"#{}|^~\[\]`\\*)(%.!'<>]/g, '')
.toLowerCase(); .toLowerCase();
} else { } else {
escapedId = m.replace(/[^\w]/g, '').toLowerCase(); escapedId = m.replace(/[^\w]/g, '').toLowerCase();

3
test/features/#320.github-compatible-generated-header-id.html
View File

@ -1,2 +1,3 @@
<h1 id="some-header">some header</h1> <h1 id="some-header">some header</h1>
<h1 id="some-header-with--chars">some header with ~!@#$&amp;*()=:/,;?+'.\ chars</h1> <h1 id="some-header-with--chars">some header with &amp;+$,/:;=?@\"#{}|^~[]`\*()%.!' chars</h1>
<h1 id="another-header--with--chars">another header > with &lt; chars</h1>

4
test/features/#320.github-compatible-generated-header-id.md
View File

@ -1,3 +1,5 @@
# some header # some header
# some header with ~!@#$&*()=:/,;?+'.\ chars # some header with &+$,/:;=?@\"#{}|^~[]`\\*()%.!' chars
# another header > with < chars