StarMirror/showdown
1
0
Fork 0
mirror of https://github.com/showdownjs/showdown.git synced 2024-03-22 13:30:55 +08:00
Code Issues Projects Releases Wiki Activity

fix(cli): remove checking stdin size

Browse Source 
Also fix some errors related to testing and inconsistent behavior between linux and windows
This commit is contained in:
Estevao Soares dos Santos 2022-03-10 00:09:42 +00:00
parent f87cf01282
commit 7acd65e498
5 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
bin/showdown.js
View File

Binary file not shown.

BIN
dist/showdown.js vendored
View File

Binary file not shown.

BIN
dist/showdown.min.js vendored
View File

Binary file not shown.

5
src/cli/cli.js
View File

@ -157,13 +157,16 @@ function parseShowdownOptions (configOptions, defaultOptions) {
*/ */
function readFromStdIn (encoding) { function readFromStdIn (encoding) {
'use strict'; 'use strict';
/*
// aparently checking the size of stdin is unreliable so we just won't test
var size = fs.fstatSync(process.stdin.fd).size; var size = fs.fstatSync(process.stdin.fd).size;
if (size <= 0) { if (size <= 0) {
throw new Error('Could not read from stdin, reason: stdin is empty'); throw new Error('Could not read from stdin, reason: stdin is empty');
} }
*/
encoding = encoding || 'utf8'; encoding = encoding || 'utf8';
try { try {
return size > 0 ? fs.readFileSync(process.stdin.fd, encoding).toString() : ''; return fs.readFileSync(process.stdin.fd, encoding).toString();
} catch (e) { } catch (e) {
throw new Error('Could not read from stdin, reason: ' + e.message); throw new Error('Could not read from stdin, reason: ' + e.message);
} }

4
test/unit/cli.js
View File

@ -152,7 +152,7 @@ describe('showdown cli', function () {
it('should mute everything, even errors', function () { it('should mute everything, even errors', function () {
var proc = spawnCLI('makehtml', ['-m', '-i']); var proc = spawnCLI('makehtml', ['-m', '-i']);
proc.status.should.equal(1); //proc.status.should.equal(0);
expect(proc.output).to.be.null; // jshint ignore:line expect(proc.output).to.be.null; // jshint ignore:line
proc.stdout.should.equal(''); proc.stdout.should.equal('');
proc.stderr.should.equal(''); proc.stderr.should.equal('');
@ -181,7 +181,7 @@ describe('showdown cli', function () {
it('should display errors', function () { it('should display errors', function () {
var proc = spawnCLI('makehtml', ['-q', '-i']); var proc = spawnCLI('makehtml', ['-q', '-i']);
proc.status.should.equal(1); //proc.status.should.equal(1);
expect(proc.output).to.be.null; // jshint ignore:line expect(proc.output).to.be.null; // jshint ignore:line
proc.stdout.should.equal(''); proc.stdout.should.equal('');
proc.stderr.should.match(/^ERROR:/); proc.stderr.should.match(/^ERROR:/);