StarMirror/showdown
1
0
Fork 0
mirror of https://github.com/showdownjs/showdown.git synced 2024-03-22 13:30:55 +08:00
Code Issues Projects Releases Wiki Activity

huge performance improvement for large texts with many spans (~20x)

Browse Source
This commit is contained in:
David Poetzsch-Heffter 2024-01-18 15:48:53 +01:00
parent 11b6aa2105
commit 001125a9bf
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/subParsers/makehtml/hashHTMLSpans.js
View File

@ -36,6 +36,8 @@ showdown.subParser('makehtml.unhashHTMLSpans', function (text, options, globals)
'use strict'; 'use strict';
text = globals.converter._dispatch('makehtml.unhashHTMLSpans.before', text, options, globals).getText(); text = globals.converter._dispatch('makehtml.unhashHTMLSpans.before', text, options, globals).getText();
var replacedSpans = [];
for (var i = 0; i < globals.gHtmlSpans.length; ++i) { for (var i = 0; i < globals.gHtmlSpans.length; ++i) {
var repText = globals.gHtmlSpans[i], var repText = globals.gHtmlSpans[i],
// limiter to prevent infinite loop (assume 10 as limit for recurse) // limiter to prevent infinite loop (assume 10 as limit for recurse)
@ -50,9 +52,21 @@ showdown.subParser('makehtml.unhashHTMLSpans', function (text, options, globals)
} }
++limit; ++limit;
} }
text = text.replace('¨C' + i + 'C', repText);
replacedSpans.push(repText);
} }
// Repeated replace is really slow for a large number of spans and long texts
// (for example for 4000 spans and 1.8MB of text it can take >10sec).
// By only going through the text once, we can reduce the time to just a few milliseconds.
var s = text.split('¨C');
for (var ii = 1; ii < s.length; ++ii) {
var endIdx = s[ii].indexOf('C');
var span = replacedSpans[s[ii].substring(0, endIdx)];
s[ii] = span + s[ii].substring(endIdx + 1);
}
text = s.join('');
text = globals.converter._dispatch('makehtml.unhashHTMLSpans.after', text, options, globals).getText(); text = globals.converter._dispatch('makehtml.unhashHTMLSpans.after', text, options, globals).getText();
return text; return text;
}); });