Commit Graph

24 Commits

Author SHA1 Message Date
Christian Blichmann
4c87556901 Use Abseil's log/flags instead of glog/gflags
Follow-up changes might be required to fully fix up the contrib sandboxes.

PiperOrigin-RevId: 482475998
Change-Id: Iff631eb838a024b2f047a1be61bb27e35a8ff2f4
2022-10-20 06:48:51 -07:00
Christian Blichmann
79b6784b82 #Cleanup: Consistently use std::make_unique
PiperOrigin-RevId: 480597371
Change-Id: I145586382ad7a7694384cc672986132376a47465
2022-10-12 05:23:42 -07:00
Christian Blichmann
51799f99ae Introduce a transitional logging utility library
Instead of calling `google::InitGoogleLogging()` directly, introduce an
indirection via a new utility library. After this change, Sandboxed API
should consistently use `sapi::InitLogging()` everywhere.

For now, `sapi::InitLogging()` simply calls its glog equivalent. However,
this enables us to migrate away from the gflags dependency and use Abseil
flags. Once a follow-up change lands, `sapi::InitLogging()` will instead
initialize the google logging library with flags defined from Aseil.

Later still, once Abseil releases logging, we can then drop the glog
dependency entirely.

PiperOrigin-RevId: 445363592
Change-Id: Ia23a7dc88b8ffe65a422ea4d5233bba7bdd1303a
2022-04-29 02:14:06 -07:00
Christian Blichmann
6cbde854d6 #Cleanup: Consistently use char* argv[] instead of char**
PiperOrigin-RevId: 444782296
Change-Id: If8e7647be28f794392675ae001abbe9b809da0ac
2022-04-27 00:43:51 -07:00
Christian Blichmann
d451478e26 Change license link to HTTPS URL
PiperOrigin-RevId: 424811734
Change-Id: If5ea692edc56ddc9c99fd478673df41c0246e9cc
2022-01-28 01:39:09 -08:00
Christian Blichmann
75bbd0e1c1 Internal change
Only externally visible changes should be a few changed includes as well as
some formatting changes.

PiperOrigin-RevId: 353226662
Change-Id: Iebf5be13774efcbd94c5d5a17b9b27e47275b229
2021-01-22 06:01:34 -08:00
Christian Blichmann
dbaf95c724 Move utility code into sandboxed_api/util
This change should make it less confusing where utility code comes from.
Having it in two places made sense when we were debating whether to publish
Sandbox2 separately, but not any longer.

Follow-up changes will move `sandbox2/util.h` and rename the remaining
`sandbox2/util` folder.

PiperOrigin-RevId: 351601640
Change-Id: I6256845261f610e590c25e2c59851cc51da2d778
2021-01-13 09:25:52 -08:00
Copybara-Service
fbf3e84799 Merge pull request #65 from andreimedar:libarchive
PiperOrigin-RevId: 343290002
Change-Id: I1f29e4acfc7d423be63fd52e7a78ceb209d29115
2020-11-19 07:53:41 -08:00
Andrei Medar
150fd02ed4 Implemented requested changes 2020-10-09 13:52:17 +00:00
Andrei Medar
519b5af157 Added ld_preload example usage 2020-10-08 10:58:21 +00:00
Copybara-Service
33bc36ae3d Merge pull request #62 from andreimedar:libarchive
PiperOrigin-RevId: 336042102
Change-Id: I7b1ceaa794851c10e07dbdef4f4e37000edc25d4
2020-10-08 02:06:50 -07:00
Andrei Medar
f038f7aa3f added empty line at the end of files (was removed by clang-format) 2020-10-07 14:36:24 +00:00
root
c63302f731 Changed constants naming in unit tests. 2020-10-07 12:52:55 +00:00
Andrei Medar
04f4ff5960 Removed computer specific code 2020-10-07 11:51:59 +00:00
Andrei Medar
efff53149d Implemented requested changes (variable names, functions return absl::Status/absl::StatusOr) 2020-10-07 10:07:13 +00:00
Andrei Medar
725f665b79 Added one extra test 2020-10-02 16:52:13 +00:00
Andrei Medar
589776b6f9 Modified sandbox to limit ioctl. Use .value() instead of manually checking .ok(). 2020-10-02 15:52:29 +00:00
Andrei Medar
7e1d9179e5 Solved some pr comments 2020-10-02 10:56:14 +00:00
Andrei Medar
b4c64dac69 Added FetchContent command to cmake so that patches are applied automatically to libarchive clone 2020-10-01 19:01:50 +00:00
Andrei Medar
c5d44eab37 Removed computer specific line in CMakeLists.txt 2020-10-01 00:17:15 +00:00
Andrei Medar
efe48ccca6 Added unit tests. Cleaned up the code and added comments. Added README 2020-10-01 00:15:33 +00:00
Andrei Medar
7e6872ee26 Added first basic test 2020-09-29 22:50:43 +00:00
Andrei Medar
267686afb6 Added test helper class 2020-09-29 19:27:40 +00:00
Andrei Medar
e6e564f412 renamed main project folder 2020-09-28 15:35:51 +00:00