From fe2ee5dfac55e2e9bdad8622bbfea12d7447def8 Mon Sep 17 00:00:00 2001 From: Wiktor Garbacz Date: Fri, 25 Jun 2021 00:03:27 -0700 Subject: [PATCH] Do not expose stack_trace.h in public API PiperOrigin-RevId: 381412175 Change-Id: I30729c5af378c358e6400e4b7366d435518ae7d7 --- sandboxed_api/sandbox2/BUILD.bazel | 9 +++++++-- sandboxed_api/sandbox2/stack_trace.h | 1 - 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/sandboxed_api/sandbox2/BUILD.bazel b/sandboxed_api/sandbox2/BUILD.bazel index 4c8e9ef..4ea87f0 100644 --- a/sandboxed_api/sandbox2/BUILD.bazel +++ b/sandboxed_api/sandbox2/BUILD.bazel @@ -281,6 +281,7 @@ cc_library( "policybuilder.cc", "sandbox2.cc", "stack_trace.cc", + "stack_trace.h", ], hdrs = [ "client.h", @@ -293,7 +294,6 @@ cc_library( "regs.h", "result.h", "sandbox2.h", - "stack_trace.h", "syscall.h", ], copts = sapi_platform_copts(), @@ -784,11 +784,16 @@ cc_test( cc_test( name = "stack_trace_test", - srcs = ["stack_trace_test.cc"], + srcs = [ + "stack_trace.h", + "stack_trace_test.cc", + ], copts = sapi_platform_copts(), data = ["//sandboxed_api/sandbox2/testcases:symbolize"], deps = [ ":global_forkserver", + ":mounts", + ":regs", ":sandbox2", "//sandboxed_api:testing", "//sandboxed_api/sandbox2/util:bpf_helper", diff --git a/sandboxed_api/sandbox2/stack_trace.h b/sandboxed_api/sandbox2/stack_trace.h index de948d4..ea01fe5 100644 --- a/sandboxed_api/sandbox2/stack_trace.h +++ b/sandboxed_api/sandbox2/stack_trace.h @@ -27,7 +27,6 @@ #include #include "sandboxed_api/sandbox2/mounts.h" -#include "sandboxed_api/sandbox2/policy.h" #include "sandboxed_api/sandbox2/regs.h" namespace sandbox2 {