mirror of
https://github.com/qTox/qTox.git
synced 2024-03-22 14:00:36 +08:00
b894531cdb
Settings upgrades global settings on construction, which can cause the SmileyPack test to be inconsistent based on file system state. Fix #6530
133 lines
3.9 KiB
C++
133 lines
3.9 KiB
C++
/*
|
|
Copyright © 2021 by The qTox Project Contributors
|
|
|
|
This file is part of qTox, a Qt-based graphical interface for Tox.
|
|
|
|
qTox is libre software: you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation, either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
qTox is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with qTox. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "src/persistence/ismileysettings.h"
|
|
#include "src/persistence/smileypack.h"
|
|
#include "util/interface.h"
|
|
|
|
#include <QtTest/QtTest>
|
|
#include <QSignalSpy>
|
|
#include <QString>
|
|
#include <QStandardPaths>
|
|
|
|
#include <QGuiApplication>
|
|
|
|
#include <memory>
|
|
|
|
class MockSettings : public QObject, public ISmileySettings
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
QString getSmileyPack() const override;
|
|
SIGNAL_IMPL(MockSettings, smileyPackChanged, const QString& name);
|
|
};
|
|
|
|
QString MockSettings::getSmileyPack() const
|
|
{
|
|
return ":/smileys/emojione/emoticons.xml";
|
|
}
|
|
|
|
class TestSmileyPack : public QObject
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
TestSmileyPack();
|
|
|
|
private slots:
|
|
void testSmilifySingleCharEmoji();
|
|
void testSmilifyMultiCharEmoji();
|
|
void testSmilifyAsciiEmoticon();
|
|
private:
|
|
std::unique_ptr<QGuiApplication> app;
|
|
std::unique_ptr<MockSettings> settings;
|
|
};
|
|
|
|
TestSmileyPack::TestSmileyPack()
|
|
{
|
|
static char arg1[]{"QToxSmileyPackTestApp"};
|
|
static char arg2[]{"-platform"};
|
|
static char arg3[]{"offscreen"};
|
|
static char* qtTestAppArgv[] = {arg1, arg2, arg3};
|
|
static int qtTestAppArgc = 3;
|
|
|
|
app = std::unique_ptr<QGuiApplication>(new QGuiApplication(qtTestAppArgc, qtTestAppArgv));
|
|
settings = std::unique_ptr<MockSettings>(new MockSettings());
|
|
}
|
|
|
|
/**
|
|
* @brief Test that single-character emojis (non-ascii) are correctly smilified
|
|
*/
|
|
void TestSmileyPack::testSmilifySingleCharEmoji()
|
|
{
|
|
SmileyPack smileyPack{*settings};
|
|
|
|
auto result = smileyPack.smileyfied("😊");
|
|
QVERIFY(result == SmileyPack::getAsRichText("😊"));
|
|
|
|
result = smileyPack.smileyfied("Some😊Letters");
|
|
QVERIFY(result == "Some" + SmileyPack::getAsRichText("😊") + "Letters");
|
|
}
|
|
|
|
/**
|
|
* @brief Test that multi-character emojis (non-ascii) are correctly smilified
|
|
* and not incorrectly matched against single-char counterparts
|
|
*/
|
|
void TestSmileyPack::testSmilifyMultiCharEmoji()
|
|
{
|
|
SmileyPack smileyPack{*settings};
|
|
|
|
auto result = smileyPack.smileyfied("🇬🇧");
|
|
QVERIFY(result == SmileyPack::getAsRichText("🇬🇧"));
|
|
|
|
result = smileyPack.smileyfied("Some🇬🇧Letters");
|
|
QVERIFY(result == "Some" + SmileyPack::getAsRichText("🇬🇧") + "Letters");
|
|
|
|
// This verifies that multi-char emojis are not accidentally
|
|
// considered a multichar ascii smiley
|
|
result = smileyPack.smileyfied("🇫🇷🇬🇧");
|
|
QVERIFY(result == SmileyPack::getAsRichText("🇫🇷") + SmileyPack::getAsRichText("🇬🇧"));
|
|
}
|
|
|
|
|
|
/**
|
|
* @brief Test that single character emojis (non-ascii) are correctly smilified
|
|
* and not when surrounded by non-punctuation and non-whitespace chars
|
|
*/
|
|
void TestSmileyPack::testSmilifyAsciiEmoticon()
|
|
{
|
|
SmileyPack smileyPack{*settings};
|
|
|
|
auto result = smileyPack.smileyfied(":-)");
|
|
QVERIFY(result == SmileyPack::getAsRichText(":-)"));
|
|
|
|
constexpr auto testMsg = "Some:-)Letters";
|
|
result = smileyPack.smileyfied(testMsg);
|
|
|
|
// Nothing has changed. Ascii smileys are only considered
|
|
// when they are surrounded by white space
|
|
QVERIFY(result == testMsg);
|
|
|
|
result = smileyPack.smileyfied(" :-) ");
|
|
QVERIFY(result == " " + SmileyPack::getAsRichText(":-)") + " ");
|
|
}
|
|
|
|
|
|
QTEST_GUILESS_MAIN(TestSmileyPack)
|
|
#include "smileypack_test.moc"
|