sudden6
f03262e98b
refactor(core): remove duplicate code and checks
2019-04-10 10:28:13 +02:00
sudden6
b033b5095b
refactor(core): use mutable keyword instead of smart pointer
2019-04-10 10:28:13 +02:00
sudden6
66f72ee863
refactor(core): remove unused function
...
This function would always return true for any non destroyed Core
object.
2019-04-10 10:28:12 +02:00
sudden6
93a7fdfe03
refactor(core): cleanup Core public functions
2019-04-10 10:28:09 +02:00
sudden6
b7b9b58d42
refactor: make ToxCall non-moveable
...
We don't need move functionality and the code for it is complex and
error prone.
2019-03-17 19:32:34 +01:00
sudden6
acef759a58
feat: remove old boostrap nodes code
...
This commit replaces the bootstrap node list in the qtox.ini file with
the boostrapnodeupdater class.
2019-03-01 10:39:24 +01:00
Anthony Bilinski
13afbf7ec6
fix(groups): avoid having to lookup peer pk
...
Caused race where peer plays audio, then is removed from group, then we
process audio played signal and lookup their peerId in core where it
doesn't exist. Now Group will effectively contain the peer until the
peer list changed slot is processed.
Partial fix for #5511
2019-01-29 08:30:39 -08:00
Anthony Bilinski
edf6b67313
refactor(core): strong type message receipt and row ID
...
Avoid implicit casting and invalid arithmetic.
2019-01-28 10:58:54 -08:00
Anthony Bilinski
8422c09f6a
fix(groups): don't invalidate all audio sources when peer list changes
...
Fix #5508
2019-01-27 23:13:11 -08:00
Anthony Bilinski
ec07fd7291
feat(groups): show who is in a group call before joining
...
Fix #5507
2019-01-27 15:57:38 -08:00
Anthony Bilinski
5289c99962
feat(core): add send message error handling
...
remove unused sendMessageResult signal
2019-01-27 04:52:36 -08:00
Anthony Bilinski
f2e8567b21
Merge pull request #5366
...
Mick Sayson (2):
fix(transfer): Accurately represent pause state in UI
refactor(transfer): Remove unnecessary split for pause send/recv
2018-12-16 14:51:02 -08:00
Mick Sayson
3615425234
refactor(transfer): Remove unnecessary split for pause send/recv
2018-12-16 13:51:04 -08:00
Mick Sayson
293a1d615c
fix(transfer): Accurately represent pause state in UI
...
Toxcore has a 3 state pause, us, them, or both. Currently our UI
messes up if both parties pause. This changeset changes our UI behavior
to show whether we're paused, or if we are waiting on the remote to
unpause.
2018-12-16 13:51:03 -08:00
Anthony Bilinski
8db744a505
feat(core): set group title for loaded groups
...
Replace double static_cast of pointer with reinterpret_cast.
reinterpret_cast in unsafe because the underlying data may be
meaningless in the new type, static cast to void then to a new pointer
type has exactly the same problem. This is our intention here.
2018-12-14 09:19:50 -08:00
Anthony Bilinski
cbf2a1801f
Merge pull request #5354
...
Anthony Bilinski (2):
feat(db): add file hash to file history
refactor(files): change ToxFile's fileName to QString
Mick Sayson (5):
refactor(files): Refactor FileTransferWidget
feat(db): Support schema version upgrades
feat(db): Database support for file history
feat(db): Hookup file history to the rest of the system
feat(db): File transfer history review comments
2018-12-14 08:34:53 -08:00
Anthony Bilinski
84362244da
refactor(files): change ToxFile's fileName to QString
2018-12-14 00:33:27 -08:00
Anthony Bilinski
c8ffa1f921
fix(settings): repair saved invalid proxy type due to #5311
2018-12-09 15:10:21 -08:00
Anthony Bilinski
8427be6678
feat(db): add file hash to file history
...
Not currently used, but there are plans to display if a transfered file
has been modified, which the file hash will be needed for. Adding file
hash at the same time as file history also saves a db schema update.
2018-12-02 14:40:54 -08:00
Mick Sayson
567ddfb203
feat(db): Database support for file history
2018-12-02 14:35:18 -08:00
Mick Sayson
157be30b11
refactor(files): Refactor FileTransferWidget
...
Rational here is that the current FileTransferWidget is quite
entangled with core logic. If we are going to instantiate the
FileTransferWidget without an active file transfer the widget needs to
behave sanely without getting messages from toxcore. This changeset is
an attempt to allow us to move from any FileTransferWidget state to any
other state without having to go through the appropriate state
transitions.
2018-12-02 14:35:04 -08:00
sudden6
a82eb6f36e
feat(core): prepare qTox for groupchat saving
...
This change creates groups on startup of Core. We need this once
https://github.com/TokTok/c-toxcore/pull/1156 is merged to load existing
groups.
2018-11-22 08:11:18 +01:00
sudden6
6cce0dae83
fix(toxoptions): handle nullptr in parameters
...
Use the c-toxcore default settings in case we don't have own settings.
2018-11-14 15:06:43 +01:00
sudden6
c6a197feca
refactor: re-format and cleanup
2018-11-14 13:58:24 +01:00
Anthony Bilinski
e1201f901f
chore(core): improve failed decryption error handling
2018-11-05 10:59:50 -08:00
sudden6
7fa2dfead5
refactor(coreav): move CoreAV to the factory pattern too
...
- clean up error handling during construction of the Core
- prevent leaks by using unique_ptr
2018-10-25 08:06:19 +02:00
sudden6
2ab081b4a9
refactor: remove support for c-toxcore < 0.2.0
...
This code is only a maintainance burden and not used anymore.
2018-10-25 07:48:21 +02:00
sudden6
10a4b249bb
fix(core): remove pgc code
...
This code was needed for the pgc implementation, but is not needed for
minipgc
2018-10-24 13:27:16 +02:00
sudden6
26206a35eb
fix(core): ensure QTimers are moved with the objects they belong to
...
We use the Qt parent/child model instead of unique_ptr to achieve this.
2018-10-07 20:12:33 +02:00
sudden6
39dc6dacb8
Merge pull request #5352
...
Mick Sayson (1):
fix(core): Fix misuse of toxcore tox_file_send API
2018-09-24 18:06:51 +02:00
sudden6
a139a9933b
refactor(core): cleanup thread and timer destruction in Core and CoreAV
2018-09-24 16:57:53 +02:00
Mick Sayson
f988177a9b
fix(core): Fix misuse of toxcore tox_file_send API
2018-09-23 20:51:34 -07:00
Anthony Bilinski
cc6df2c294
chore(core): use new toxcore enum typenames
...
Fix #5287
2018-09-17 10:40:07 -07:00
Anthony Bilinski
0c757356d3
fix(avatar): set friend to identicon on empty avatar receipt
...
*All friend avatar changes and removals go through Profile, so that Profile can manage identicons
*Split the concept of "changed" and "removed" into "changed", "set", and "removed"
Fixes #4724
2018-09-17 02:30:45 -07:00
iphydf
31f54d4d1c
refactor: Improve toxcore-originated log messages.
...
This changes ToxLogger to behave as if `qDebug()` were used inside
toxcore itself, i.e. with the correct file/line/func.
2018-08-26 17:22:28 +00:00
sudden6
291e86d9f9
fix(ui): don't emit filename change windows for every chat
2018-07-13 09:42:27 +02:00
sudden6
7a98ea2def
fix(logging): only log toxcore messages above TRACE level
2018-07-12 11:35:01 +02:00
sudden6
24e7c4efd4
refactor(core): format code
2018-07-05 17:10:26 +02:00
sudden6
82a7141e31
refactor(core): reimplement restart and small cleanups
2018-07-05 17:05:41 +02:00
sudden6
5a6606e351
refactor(core): prepare for future error codes
2018-07-05 17:05:41 +02:00
sudden6
5ec983d8f5
refactor(core): remove unused return value and fix comment
2018-07-05 17:05:41 +02:00
sudden6
7f7b29e55e
refactor(core): use smart pointers instead of raw pointers
2018-07-05 17:05:41 +02:00
sudden6
6aa215e96f
refactor(core): protect the tox main loop with a mutex
2018-07-05 17:05:41 +02:00
sudden6
e5acc6726f
refactor(core): reimplement avatar transfers
...
In the process of this I used some ugly hacks, to finish this in time,
they should be changed as soon as possible.
2018-07-05 17:05:41 +02:00
sudden6
b647f9291e
refactor(core): reimplement profile saving
2018-07-05 17:05:40 +02:00
sudden6
e56ee4a134
refactor(core): fix bootstrapping
2018-07-05 17:05:40 +02:00
sudden6
a8494980da
refactor(core): fix error handling
2018-07-05 17:05:40 +02:00
sudden6
8574162949
refactor(core): cleanup Core class
...
- use a factory method to create it
- make it handle its own thread
- remove dependency on GUI
2018-07-05 17:05:40 +02:00
sudden6
977b7fc9a0
fix(settings): automatically disable UDP when a proxy is set
...
fixes : #5174
2018-07-02 22:46:26 +02:00
sudden6
40d30153ae
fix(audio): fix error introduced in 67f2605971
2018-07-02 15:34:24 +02:00
sudden6
a00af08777
fix(audio): connect the correct audio callbacks
2018-07-01 10:39:33 +02:00
sudden6
67f2605971
refactor(toxcall): move peer handling to ToxGroupCall
2018-07-01 10:16:21 +02:00
sudden6
811998b8df
refactor(toxcall): move alSource into ToxFriendCall
2018-06-30 22:11:19 +02:00
sudden6
20ca6c84c8
refactor(core): move Tox_Options handling to separate file
2018-06-27 18:34:59 +02:00
sudden6
c7ca261679
refactor(core): move logger to its own file
2018-06-27 18:34:55 +02:00
Pavel Karelin
9b6cd1c022
fix: Fix PR #5182 . Eliminating the 'new' operator at ToxOptionsWrapper
2018-06-23 03:36:39 +03:00
sudden6
26b59d3123
fix(Core): fix use after free of proxyAddrData
2018-06-22 08:12:08 +02:00
sudden6
2a8ab03e46
fix(file): don't clean the filenames of avatar transfer
...
also don't print the filenames to the log for privacy reasons
2018-06-14 22:39:23 +02:00
Pavel Karelin
2cd65610fc
fix(build): Elimination the build warnings (Wunused-variable, Wreorder)
2018-06-06 23:05:06 +03:00
sudden6
4faab0750d
feat(core): put c-toxcore log messages in the qTox log
2018-06-06 00:57:37 +02:00
tox-user
2fae2a30f7
feat(chat): add UI option to mute group peers
...
Implements #4596 , #4626 , #1007
Adds a context menu to every peer label in group chat with an
option to mute chosen peers, which adds them to the blacklist.
Mutes audio of blacklisted group peers.
2018-06-02 18:05:45 +00:00
sudden6
3d7d791e5f
Merge pull request #5111
...
Alice (1):
fix(core): Clean illegal chars from filenames
2018-05-15 22:56:25 +02:00
sudden6
e55f86c6a5
fix(video): unsubscribe the video device correctly
...
fixes #5110
2018-05-15 20:29:47 +02:00
Alice
ab85716f00
fix(core): Clean illegal chars from filenames
...
Fixes : #1304
2018-05-14 16:16:16 -07:00
sudden6
4acf884fb9
refactor: use ToxPk as identifier
...
fixes #5116 and #5117
2018-05-11 20:35:24 +02:00
Anthony Bilinski
5dc4e6de81
chore(legal): update copyright date to 2018 for all source files
2018-04-25 17:33:38 -07:00
Anthony Bilinski
869036f3c6
fix(core): split messages on utf8 multibyte character boundary properly
...
Fix #4917
2018-04-13 00:16:41 -07:00
Anthony Bilinski
9f8b0fed07
feat(ui): Add ability to disable LAN discovery
...
Fix #4074
2018-04-06 12:02:10 -07:00
Anthony Bilinski
9216549d6e
refactor(call): Refactor toxcall and disconnect lambda on destruction
...
Fixes #3840
Move audio and video state into ToxCall which both ToxFriendCall and ToxGroupCall inherit from
2018-04-04 01:32:00 -07:00
sudden6
0170ccd6f7
refactor: remove some unused includes
...
thanks @iphydf for pointing that out
2018-03-21 19:39:28 +01:00
Anthony Bilinski
bc18990fd2
fix(build): Remove unused vars, add default case for switch
...
Fix #5006
2018-03-16 12:59:51 -07:00
sudden6
d3d81bbdf3
feat: update to the new c-toxcore 0.2.0 conferences api
...
The old functions are disabled at compile time and should be removed
later.
2018-02-24 09:57:42 +01:00
iphydf
1111949f45
fix(core): Adapt qtox to new conferences state change callback.
2018-02-24 09:57:42 +01:00
sudden6
0dea03906e
Merge pull request #4918
...
iphydf (1):
chore: Don't dereference Tox_Options, use getters instead.
2018-02-05 22:05:28 +01:00
sudden6
09ad16bc44
refactor: cleanup notifications and core
2018-02-01 22:00:00 +01:00
Diadlo
d2deec7c55
fix(core): Use new callback API for bitrate set
2018-01-31 09:39:43 +03:00
Diadlo
2c8f03dada
fix(core): Use new API for bitrate set
...
Fix #4935
2018-01-31 00:01:52 +03:00
Diadlo
3b52402fa2
feat: Prefere new line as message break
...
Fix #4113
2018-01-20 14:07:22 +03:00
iphydf
2e645eb68c
chore: Don't dereference Tox_Options, use getters instead.
...
Depending on Tox_Options structure layout is deprecated. We will remove
it from the public API in the future.
2018-01-16 17:27:17 +00:00
iphydf
398ba415ce
chore: Update to immutable TES API and one-big-lib change.
2018-01-14 15:47:43 +00:00
Diadlo
9ac5f881c6
refactor: Rename signal and remove unused params
2017-11-25 01:16:10 +03:00
Diadlo
7c76bebebe
fix(group): Send all parts of long message
...
Fix #4832
2017-11-25 01:16:10 +03:00
Diadlo
78262b41bd
fix(core): Check that result of get peer name is successful
...
Fix #4802
2017-11-17 23:38:54 +03:00
anthony.bilinski
1394dd1b7f
fix(call): fix bugs introduced from ToxCall refactor
...
-inverted call active booleans
-audio subscription leak on move assignment
-NullVideoBitrate check
-return peers list by reference so that adding audio source in GroupCallCallback is persisted
-fix output muting for friend calls
2017-11-02 13:41:44 -07:00
sudden6
967dab8700
style: run format-code.sh on the files
2017-10-31 09:32:53 +01:00
sudden6
90bf0a7e2c
refactor(toxcall): make toxcall a class with getters and setters
2017-10-31 09:32:53 +01:00
sudden6
1dce8f6468
refactor(core): rename corestructs to toxfile.cpp
...
It only contains this struct now.
2017-10-31 09:32:53 +01:00
sudden6
cac25b4477
refactor(core): move Status class to core.h
2017-10-31 09:32:52 +01:00
sudden6
2a15927a16
refactor(core): remove unused declaration
2017-10-31 09:32:47 +01:00
sudden6
b07ea763cd
refactor(toxcall): remove callId from ToxCall members
2017-10-28 11:47:56 +02:00
sudden6
4149b5b252
refactor(coreav): remove unused IndexedList
2017-10-28 11:47:56 +02:00
sudden6
ed4b063994
refactor(coreav): replace IndexedList with std::map
2017-10-28 11:47:51 +02:00
sudden6
ecea41045c
fix(video): reduce default video bitrate to make it more usable
2017-10-23 14:22:26 +02:00
sudden6
1d790190d8
Merge pull request #4747
...
anthony.bilinski (1):
fix(video): Set toxav video bitrate to 0 if answering audio-only call
2017-10-23 13:46:34 +02:00
noavarice
5e45569973
fix: add missed <functional> header
2017-10-20 22:39:10 +03:00
anthony.bilinski
1613044c68
fix(video): Set toxav video bitrate to 0 if answering audio-only call
...
Before we would set the video bitrate to 0 if sending an audio-only call, but we would still set the video bitrate to default when receiving an audio only call. In bad network conditions, this caused tox to ask us to decrease video bitrate in audio-only calls.
2017-10-19 12:18:44 -07:00
anthony.bilinski
7170b48589
fix(init): register AV connects and call after AV is ready
...
Fixes #4651
2017-10-13 15:22:24 -07:00
Diadlo
49915c0a45
refactor(profileinfo): Move some methods in profile info class
2017-10-13 09:12:41 +03:00
Diadlo
68813a37c3
refactor: Remove Settings from Core
2017-10-11 08:51:32 +03:00
Diadlo
7f2bd726ef
refactor: Integrate ICoreSettings in Core
2017-10-11 08:51:32 +03:00
Diadlo
4e3b2291f5
refactor: Create interface for core settings
2017-10-11 08:51:32 +03:00
Diadlo
0c8c16e743
refactor: Extract DhtServer in separate file
2017-10-11 08:51:32 +03:00
sudden6
1fc7fe2d58
Merge pull request #4638
...
noavarice (1):
refactor(toxid): use left instead of mid
2017-10-10 13:08:15 +02:00
sudden6
b609a8f99a
Merge pull request #4697
...
tox-user (5):
feat(settings): Add audio quality setting
feat(settings): make audio quality setting persistent
refactor(settings): use constants in audio quality setting
refactor(settings): use a cleaner way to read and set audio bitrate
style(settings): change names of local constants to camel case
2017-10-08 00:18:06 +02:00
sudden6
f82f57ec91
refactor: don't pass ToxPk as QString
2017-10-06 23:57:55 +02:00
tox-user
7ed2d97aad
feat(settings): make audio quality setting persistent
2017-09-29 12:33:30 +02:00
tox-user
61eddc1f6b
feat(settings): Add audio quality setting
...
Fixes #4693
2017-09-28 16:14:36 +02:00
noavarice
b967d28465
refactor: use GroupInvite instead of set of parameters
2017-09-17 19:54:06 +03:00
noavarice
6b93a41a40
refactor: removed unused constant
2017-09-09 23:06:53 +03:00
noavarice
28aed05d0a
refactor: removed unused quitGroupChat method
...
`removeGroup` is used instead of this method
2017-09-09 23:06:53 +03:00
noavarice
b7323e3164
refactor(toxid): use left instead of mid
2017-09-09 22:25:39 +03:00
anthony.bilinski
1f787cc475
fix(popup): Don't create two error popups for friend requests
...
Fixes #4633
2017-09-06 19:34:17 -07:00
Diadlo
99ebb73562
refactor: Remove deprecated methods to get id
2017-08-06 13:55:02 +03:00
Diadlo
017653470d
refactor: Move friend and group in model directory
2017-08-06 13:55:02 +03:00
sudden6
c715729167
feat(audio): add alternative OpenAL backend
2017-08-05 21:12:32 +02:00
Diadlo
c82b66104c
Merge pull request #4531
...
tWido (1):
feat(video): Error message on call fail
2017-07-24 00:28:23 +03:00
tWido
ac75f7b594
feat(video): Error message on call fail
...
notifies user if call ended unexpectedly
2017-07-23 21:19:06 +02:00
Diadlo
3b2352a0ee
refactor: Rename methods in CameraSource
...
To make the method more correctly reflect the essence
2017-07-05 23:53:17 +03:00
Diadlo
3c21af200c
revert: "refactor(core): Remove unused Core::reset method"
...
This reverts commit 4664c6249a
2017-07-05 23:53:06 +03:00
Diadlo
efcad35fd5
fix: Fix warning about stack protection
...
Replace local array on stack with dynamic size on QByteArray with
dynamic size
2017-06-12 13:46:42 +03:00
Diadlo
8e93af7fca
refactor: Add copy and move assignment operator to toxid and toxpk
...
Add assignment operator to classes which has copy constructor
2017-06-12 13:46:42 +03:00
Diadlo
7895bcdaa0
refactor: Remove useless check
...
uint32_t always greater of equal 0
2017-06-12 12:42:54 +03:00
Diadlo
65b1463933
refactor(core): Move setAvatar to profile from core
2017-05-24 19:43:47 +03:00
Diadlo
4664c6249a
refactor(core): Remove unused Core::reset method
2017-05-24 19:43:47 +03:00
sudden6
50768abbab
Merge pull request #4394
...
Yuri (1):
fix(message size): Replaced TOX_MAX_*_LENGTH with API calls.
2017-05-14 12:53:41 +02:00
Maxim Biro
4e5b191553
fix(core): use correct byte representation when bootstrapping
...
Revert a bug introduced in d126b18d76Fixes #4385
2017-05-11 17:19:28 -04:00
Yuri
3963d3c150
fix(message size): Replaced TOX_MAX_*_LENGTH with API calls.
...
It is good for flexibility to have fewer hardcoded values.
2017-05-11 09:24:54 -07:00
Diadlo
b126d21922
refactor(core): Merge friendAdded and friendshipChanged
2017-05-08 22:12:14 +03:00
Diadlo
49e9eb8de2
refactor(core): Move saving request to history to Profile
2017-05-08 22:12:14 +03:00
Diadlo
b25f5b5ed6
fix(core): Add action message with friend request text
2017-05-08 22:12:14 +03:00
sudden6
407413c65b
fix(core): add missing nullptr check
...
fix #4324
2017-05-07 01:03:35 +02:00
noavarice
532e05cb0f
fix: fixed segfault after accepting group invite
...
Fix #4327
Description:
- QString::arg call with mulpiple arguments replaced with chained
QString::arg calls;
- dynamic memory allocation for array of names replaced with
allocation on the stack, unfortunately I do not notice this while
making Core refactoring.
Also code style is formatted with script
2017-04-12 22:57:31 +03:00
Yuri
e597d391fc
fix(includes): Added missing #include <ctime>
...
time(3) requires this include. Found when qTox failed to build on the FreeBSD due to the missing include.
2017-04-11 00:04:48 -07:00
sudden6
20db8b740b
fix(core): don't continue when the tox file is corrupted
2017-04-04 11:43:24 +02:00
noavarice
c1e01710b4
refactor: returned correct code format
2017-04-03 21:05:25 +03:00
noavarice
931e5803cd
refactor: next part of Core refactoring
...
Changes:
- several parts of code extracted into single methods;
- fixed several TODO's
2017-04-03 16:13:56 +03:00
noavarice
d126b18d76
refactor: Core refactoring
...
Brief list of changes:
- removed unnecessary headers from core.h and core.cpp;
- added missing brackets and aligned long lists of parameters;
- some other small changes.
2017-04-03 16:13:56 +03:00
sudden6
aeb9df0750
refactor(core): reduce line lenghts
2017-03-28 21:57:14 +02:00
sudden6
3e50757ddb
refactor(profile): reduce code duplication
2017-03-28 21:57:13 +02:00
Diadlo
add8d51a29
refactor: ContentDialog refactoring
2017-03-21 01:38:03 +03:00
sudden6
4e548662d7
refactor(core): remove CString
2017-03-09 11:01:43 +01:00
sudden6
25c279c320
refactor(core): replace CString with ToxString
2017-03-09 11:01:43 +01:00
sudden6
1f0467bb1b
refactor(core): add new class for easy string conversion
2017-03-09 11:01:34 +01:00
Diadlo
ea50eaaef7
fix(core): Ignore online connection status
...
Fix #4010 .
qTox use status system, where offline is one of the status, but toxcore
use two different meaning: 'connection' and 'user status'. To correct
qTox status handling we should ignore online connection status.
2017-03-08 08:55:17 +03:00
sudden6
aabf34ebad
refactor: remove unused file
2017-03-05 12:05:41 +01:00
Zetok Zalbavar
80f5de31b3
style: reformat current C++ codebase using clang-format
2017-02-26 11:52:45 +00:00
tux3
c75ee8a661
fix: Various IPC event handling and related bugs on startup
...
Fixes #1926 : When an IPC event was processed locally, if the window was closed before the core could start, the event handler would be forever stuck in the background waiting for the core to start. We fix this by substituting QApplication::quit() by a Nexus::quit() function and a Nexus::isRunning() function, which gives us a condition for exiting blocking processEvents() loops. We cannot simply use QApplication::quit(), because this function has no effect before the start of the event loop.
The problem was further exacerbated by the Tox URI event handler being (incorrectly) blocking. The IPC owner would block in this event handler, and the sender of the event would give up waiting and process the event itself a second time, potentially triggering the first bug. We fix the event handlers accordingly to be (mostly) non-blocking.
Also fixes a related deadlock between ~Core and ~Profile in the case of an early exit
2017-02-17 17:18:52 +01:00
sudden6
14ee8af3cd
fix(toxencrypt): return the plaintext after decryption
...
fix #4162
2017-02-10 22:33:57 +01:00
sudden6
01b9327827
Merge pull request #4146
...
agrecascino (1):
fix(audio): alternate audio fix implementation from #4139
2017-02-08 13:34:22 +01:00
agrecascino
62ac480171
fix(audio): alternate audio fix implementation from #4139
2017-02-07 15:44:35 -05:00
