6 Commits

Author	SHA1	Message	Date
Anthony Bilinski	9571434df9	feat(CI): Disallow unsafe implicit casts to QString ... Covers char* without size, and QByteArray. Catches the case of QByteArray to QString implicit conversion like was fixed in 47ee51c61d, but still allows construction or assignment from string literals in source. Gives most of the type safety of QT_NO_CAST_FROM_ASCII without having to wrap every literal string in QStringLiteral. No functional issues found during change.	2022-04-05 12:10:05 -07:00
Anthony Bilinski	b894531cdb	fix(tests): Mock Settings for SmileyPack test ... Settings upgrades global settings on construction, which can cause the SmileyPack test to be inconsistent based on file system state. Fix #6530	2022-03-15 01:32:16 -07:00
Anthony Bilinski	0c967725df	refactor: Remove Settings singleton ... * Make main.cpp's toxSave free functions into a ToxSave class so that it can be given Settings on construction. * Add void* to IPC callbacks so that classes can get back to themselves.	2022-03-13 16:00:48 -07:00
Anthony Bilinski	47328cc6bf	refactor: Remove SmileyPack singleton	2022-03-12 16:28:06 -08:00
Anthony Bilinski	adc0f0cca6	refactor: Comply with Wmissing-declarations ... * Move free functions to the anonymous namespace * Additionally move static free functions to the anonymous namespace * Move functions that must be accessed externally to static class functions	2022-03-11 10:08:02 -08:00
Waris Boonyasiriwat	7a26fe1708	test(persistence): add smileypack unit test ... A follow-up of issue #5147, add a unit test which ensures the same bug won't come up again.	2021-02-20 16:36:11 -08:00