1
0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Commit Graph

49 Commits

Author SHA1 Message Date
Anthony Bilinski
c828a16b7b
feat(CI): Run clang-tidy check in CI 2022-03-15 08:19:53 -07:00
Anthony Bilinski
47d52f9977
chore(CI): Fix gitstats cloning by cloning with https
To resolve the error:
  The unauthenticated git protocol on port 9418 is no longer supported.
2022-03-15 07:07:52 -07:00
Anthony Bilinski
ba17b5130c
Revert "chore(CI): Disable online tests in all but one CI job"
This reverts commit fd2997c2db.

Core tests are no longer online, so no longer are flaky nor tie up many
minutes of test runner time. So re-enable for all jobs.
2022-03-13 03:21:27 -07:00
Anthony Bilinski
be3e8997c4
chore(CI): apt-get update in gitstats runner
Package cache is stale and causing a failure to install.
2022-03-09 19:31:40 -08:00
Anthony Bilinski
fd2997c2db
chore(CI): Disable online tests in all but one CI job
They're still slightly flaky even with insanely long timeouts, and even when not they waste a huge amount of our runner time sitting and waiting for the DHT to disconnect and reconnect.

Still run on our fedora job to get almost all of the benefit, plus AddressSanitizer is enabled there for better testing synergy.
2022-03-08 20:18:35 -08:00
Anthony Bilinski
4afaf78c65
chore(meta): Remove commit format PR template
Commit format is already checked in CI, unlike this template which doesn't
actually enforce anything. Each PR showing "1 task done" clutters the PR list
view.
2022-03-08 15:45:54 -08:00
Anthony Bilinski
2bcd85cfe4
chore(CI): Add more artifacts to nightly release
To match functionality of old qTox/qTox-nightly-releases/releases nightlies.

Add flatpak sha, Windows zip shas, Windows installers, macOS sha.
2022-03-06 18:16:33 -08:00
Anthony Bilinski
3170dd8d62
chore(CI): Don't try to deploy from forks
Gitstats and doxygen deploys require deploy keys to update qTox's website.
Don't try to do this from forks, since it will always fail.
2022-03-03 03:59:12 -08:00
Anthony Bilinski
e18118c1bc
chore(CI): Don't try to upload installer on debug builds
The installer is only built on release builds. We used to ignore failure to
upload prior to 5fcf86b521. We stopped ignoring
because a07ab89cc8 tried to make our upload
targetted, but it only resolved the issue for the zip, not the installer.
2022-03-02 21:58:57 -08:00
Anthony Bilinski
bad2e0aba9 chore(CI): Fix appimage missing rename for nightly zsync upload 2022-02-28 20:38:36 -08:00
Anthony Bilinski
bf6d01598f
feat(CI): Run AddressSanitizer on Fedora build
Keep disabled for jobs that produce artifacts to not affect user performance.
Keep disabled for other distros that don't produce artifacts as well since other versions of Qt fail themselves in e.g. TestSmileyPack's QGuiApplication usage.

Don't enable thread sanitizer yet due to many Qt internal errors.

This should still give us a significant increase in qTox coverage, even if we have low platform coverage.
2022-02-24 07:28:11 -08:00
Anthony Bilinski
25b70761e5
chore(CI): Correct doxygen deploy access 2022-02-24 05:51:27 -08:00
Anthony Bilinski
f81c9bca29
chore(CI): Don't overwrite nightly release name and description
Allows maintainers to write a user friendly message rather than just having the
last commit desription.
2022-02-23 21:11:02 -08:00
Anthony Bilinski
b24610fc62
chore(CI): Revert nightly AppImage name to "nightly"
Changed in 41a555def9, I think by accident.
Causes our release uploader to no longer replace the old version, instead
adding a new version each time it runs.

Keeping named overwrite instead of removing release artifacts and
uploading new ones, since removing old artifacts would require a new job
that all other jobs depend on to avoid re-removing, and would also
create a gap while CI is running run where no artifact is available.

We could upload artifacts using actions/upload-artifact in each job then
download them at the end and update the release at that point too, if we
really want to keep sha name in the nightly release artifacts. I don't
see much value of having the sha in the filename though.
2022-02-23 21:11:02 -08:00
Anthony Bilinski
d3995bc87e
fix(doxygen): Re-enable deploying of doxygen to qtox.github.io
Hasn't been run since the travis days.

Now managed through a deploy key rather than an access token to limit scope to
a single repo. Private key is stored in qTox/qTox as a repository secret, and
the public portion is saved to qTox/doxygen as a deploy key.
2022-02-23 21:10:32 -08:00
Anthony Bilinski
e5d138f79c
chore(CI): Move gitstats and docs to ubuntu-latest
They're not platform dependent and the rest of our jobs run on ubuntu-latest.
Might as well move this one over so we don't have to remember to update it.

gitstats is not available in repo any longer, so install manually.
2022-02-23 21:10:03 -08:00
Anthony Bilinski
2f92a5f2f0
fix(CI): Remove "setup" from Windows zip file name
Matches previous behaviour, and the zips don't do any installation.
2022-02-20 18:15:52 -08:00
Anthony Bilinski
c726b9ce23
fix(CI): Don't upload Windows setup exe to nightly release
Matches previous behaviour from travis. Avoids spreading a possibly buggy
nightly around a tester's system.
2022-02-20 18:15:49 -08:00
Anthony Bilinski
939bf6a2c1
chore(CI): Re-remove GH action if-no-files found conditions
Was accidentally reintroduced in c85e24e7db after
being removed in 5fcf86b521
2022-02-20 17:30:19 -08:00
Anthony Bilinski
11450afa81
feat(i18n): Check for new translatable strings on every PR
We've only been updating translatable strings for Weblate rarely based on
MAINTAINING.md#translations-from-weblate. Since Weblate pulls in commits live
from qTox, we should generate the translatable strings as soon as they're
introduced so that translators can not waste time translating deleted strings,
and can spend time translating new strings.

We can't auto-commit the changes in CI due to our requirement of signed
commits, so just fail CI if any new strings are found.

Move it into its own job, it doesn't depend on docker or the build, and doesn't need to run for debug/release/full/minimal
2022-02-20 17:04:05 -08:00
Anthony Bilinski
41a555def9
chore(CI): Remove knowledge of build context from AppImage build script
* Since nightlies are now published under qTox/qTox, different update
  info is not needed for the zsync file.
* The github action yaml already handles naming files correctly
  otherwise.
2022-02-19 03:31:49 -08:00
Anthony Bilinski
a764aebaf9
chore(CI): Remove unused CI environment variables
Not used since CI docker refactor.
2022-02-19 03:31:49 -08:00
Anthony Bilinski
5bcfd21760
chore(CI): Deep clone for gitstatus initially instead of recloning 2022-02-19 03:31:48 -08:00
Anthony Bilinski
6fd79c65e7
chore(CI): Remove travis config and directory
Move all CI scripts to generic .ci-scripts dir
2022-02-19 03:31:48 -08:00
Anthony Bilinski
3f2d953473
chore(CI): Revert 8a72928ad1
"chore(travis): don't fail generating docs when there's no git version"

No longer a concern on GH actions which allows deep clones.
2022-02-19 03:31:16 -08:00
Anthony Bilinski
5a77a18fc0
fix(gitstats): Re-enable deploying of gitstats to qtox.github.io
Hasn't been run since the travis days.

Now managed through a deploy key rather than an access token to limit scope to
a single repo. Private key is stored in qTox/qTox as a repository secret, and
the public portion is saved to qTox/gitstats as a deploy key.
2022-02-19 03:15:41 -08:00
Mick Sayson
1288a0a7fa
chore(ci): Windows docker build fixes
* Fix unit tests not running in windows build
* Fix missing comment ports from old build script
2022-02-17 10:10:20 -08:00
Anthony Bilinski
1bc72ab1a4
fix(CI): Grant action content write permission for release upload
By default our organization on GH only grants a more restricted read
permission to actions for content APIs, which include both writing to
repo for nightly tag creation, and writing to releases for nightly and
tag release creation or updates.
2022-02-17 09:01:01 -08:00
Anthony Bilinski
44d867f624
fix(CI): Fix regression in logging from docker compose run
Replace "docker compose run" with "docker-compose run".

Seems like some kind of github actions regression:
https://github.com/github/feedback/discussions/11011
2022-02-16 19:32:47 -08:00
Anthony Bilinski
90484a1fdf
chore(CI): Replace CentOS 8 CI with AlmaLinux
CentOS is EOL, and AlmaLinux seems like the closest successor
2022-02-08 02:08:42 -08:00
Anthony Bilinski
65c42ebd9e
chore(release): Create release on tag push
Release will be created as a draft, remaining private until manually published.
All generated artifacts will be uploaded, but will still need to be signed, and
the code archives still need to be created following
MAINTAINING.md#after-tagging

Fix #6345
2022-01-09 21:06:40 -08:00
Anthony Bilinski
c85e24e7db
chore(release): Create nightly release on master branch pushes
* Tag is required to create a release, so tag "nightly" is moved to
  latest commit on each run.
* Each time the tag is moved, the existing "nightly" release is updated
  automatically by github to point to the new tag and bundle the new
commit's source code.
* Artifacts are uploaded with intentionally conflicting names to replace
  last commit's version of artifacts, rather than deleting the whole
release and making a new one.
* This has two benefits, it doesn't notify of a new release on each
  commit, and it doesn't leave a gap where there's no nightly release
available.
2022-01-09 20:55:07 -08:00
Anthony Bilinski
ff2cad3b03
chore(build): Remove qTox-Mac-Deployer-ULTIMATE.sh
* It is only partially covered by CI and doesn't simplify the build process
much for users. Replacing it in CI with just build-osx.sh significantly reduces
script complexity and is fully tested.
* bootstrap-osx.sh copying system libs and headers locally is unneeded.
  Already the DMG file contains them, and re-linking the app against
updated system files may be desirable.
* Update INSTALL.md for macOS to use brewfile, use common dependency build
  scripts, and use cmake rather than wrapper scripts.
* Build macOS in Release mode in CI, for release artifact creation
* Don't copy all used libs into a local folder, macdeployerqt already
  handles this for the dmg, and for local running of the app using the
system libs and relinking on update is desirable to avoid running out of
date dependencies unexpectedly.
2022-01-09 18:52:53 -08:00
Anthony Bilinski
5fcf86b521
chore(CI): Remove if-no-files-found from artifact upload
Artifacts are now conditionally uploaded based on matrix, so they should always be present when expected.
2022-01-09 17:43:27 -08:00
Anthony Bilinski
a07ab89cc8
chore(CI): Upload release Windows zips from GH actions workflow 2022-01-09 14:47:14 -08:00
Mick Sayson
8abe8320d2 chore(CI): Use docker for CI scripts
Motiviation:
* Reproducing issues in CI is currently difficult
* Predicting issues in CI is currently difficult if you are not on
  ubuntu 18.04
* Reproducing issues submitted from other distros is currently done by
  creating a VM of that distro and building qtox for it locally
* Documentation for how to build on different distros is out of date
* Issues on non-ubuntu distributions are not caught by CI
* Cross compiling for windows locally is not trivial
* Iterating when working with custom build scripts is slow, scripts
  don't necessarily support re-running without re-starting the docker
  container and re-building qtox again
* Updating dependencies is a pain

Changes:
* docker-compose file has been added to the root of our repo.
  After `docker compose run --rm ubuntu` (or other supported distros),
  you are ready to compile and run qtox
* Dependencies are owned by dependency install scripts in buildscripts/.
  This allows us to use the same exact dependencies in our
  OSX/windows/linux scripts
* New docker images have been added for a variety of distributions.
  These are now run in CI in a variety of configurations
  * Docker images are cached in CI so rebuild time for the majority of
    jobs is quite quick
* Build scripts have been trimmed to leverage state of docker
  containers.
  * Windows build script no longer installs anything, dependencies are
    now managed by the windows_builder docker images
  * Build scripts should now be easily re-runnable. Usage is now `docker
    compose run --rm <image>` and then run the scripts
* All artifacts are now uploaded to github after build, this means we
  can take an appimage/flatpak/exe/dmg for any given PR and try it out
  without having to build it ourselves

Notes:
* Docker image size is quite important. We have a maximum of 5GB cache
  space on github actions. The majority of the linux distro docker
  images cache at ~300-400MB, which gives us room to test ~6 distros
  after accounting for the sizes of flatpak/windows docker images
* Docker layer ordering is relatively intentional. Approximate order
  should be that large dependencies that change infrequently should be
  farther up. This lowers the amount of rebuilding we have to do when
  dependencies are updated
* download_xxx.sh scripts are the cleanest way I could find to implement
  a shared dependency map between osx scripts and docker containers.
  Although it would be nice to have a single dependency mapping file,
  splitting it into individual scripts allows us to only rebuild some
  docker layers when dependencies are updated.
* Github actions are split between docker image building and docker
  image use. This allows us to re-use the same docker images for
  multiple jobs, but only build it once
  * Unfortunately I could not find a way to de-duplicate the stitching
    between jobs, so we have a lot of copy pasta in that area
2021-12-19 14:56:05 -08:00
Anthony Bilinski
9fa7f2e4b6
chore(CI): Split Win deps into their own job
Previously, the four matrix Windows jobs would run in parallel and each
build deps, which is redundant since both debug and release qTox use the
same deps.

Now, the win-deps job builds only the needed two versions of deps, and
the four windows builds wait for it to complete before running in
parallel.
2021-10-24 14:16:34 -07:00
Anthony Bilinski
ade6e38003
chore(CI): Run tests on pushed commits
So that each commit in repo is tested, including merge commits that
aren't present in PRs. Also prepares for running releases only on push
but not on PRs.

Workflows have a global runs-on, so commit format check needs to be
split out from the shared PR and push workflow to since checking all
commit messages on pushes always fails due to very old commits not
following the proper format.
2021-10-24 14:16:11 -07:00
Anthony Bilinski
4699e84e14
chore(ci): Migrate PR CI from travis-ci.org and circleci to GitHub Actions
Partially fix #6345, only PR portion, not nightly or releases.

Unlike travis, we're not caching our brew packages. `actions/cache` doesn't
update the cache on cache hit, making it hard to use a rolling cache like
before. We also don't know what cache key we should use before running, since
it relies on the live package list of brew.

Using a docker image containing brew packages seems like a better option if we
need the speedup going forward. ATM a full build with deps only takes about 12
minutes. Windows builds don't have this issue, since deps there are keyed off of
known versions in our repo.

Current Windows matrix form works, but causes a double-build on dep change due
to both debug/release rebuilding the release deps. Instead, should probably
separate the dep jobs, block build on the dep jobs, and update the cache on dep
jobs, guaranteeing a cache hit on build jobs?

Windows stage 1 and stage 2 can probably be recombined, if they were split due
to travis single build length limits, since GH actions allows much longer single
builds.
2021-06-27 01:03:23 -07:00
Anthony Bilinski
366478fca9
chore: remove "Hardware" from issue template
For the grand majority of bug reports, user hardware isn't relevant. Figuring
out what to write isn't always trivial.
2020-01-26 02:33:20 -08:00
sudden6
605d351a96
Merge pull request #4474
Samantha McVey (1):
      docs: Add a pull request template file
2018-04-28 21:19:06 +02:00
iphydf
f53b82825b
fix(windows): %APPDATA -> %APPDATA% in template 2018-01-06 15:56:01 +00:00
Samantha McVey
dca86252d0
docs: Add a pull request template file
Add a pull request template to tell contributors that their commits
should follow the project's git commit guidelines before submitting
a pull request.
2017-06-18 15:38:19 -07:00
initramfs
b7aa982a57
chore: rewrite all links to the qTox repository from tux3 to qTox 2016-08-04 06:25:50 +08:00
Zetok Zalbavar
6ac8827d29
chore(ISSUE_TEMPLATE): update location of log file on ~unix platforms 2016-06-30 21:38:51 +01:00
Anton Batenev
4f2a04c8e4 chore(ISSUE_TEMPLATE): Add tip to get webcam info on Linux
Additional info about webcam can help to understand where problem is. For example, ffmpeg does not support webcams with PJPG pixel format (pac7302).
2016-05-21 16:22:00 +03:00
Zetok Zalbavar
1c5572388b
chore(ISSUE_TEMPLATE): add direct instructions for including log file
Hopefully that'll result in more issues having log attached when it's
needed.
2016-04-22 10:37:49 +01:00
kehugter
f82a74a4bc style(Markdown): wrap all .md files at 80 characters
Short lines make it easier to evaluate diffs.
Fix only critical typos, like missing full stops in the middle of a
sentence. Everything else left untouched.
2016-04-09 23:57:31 +02:00
kehugter
f432a6f70f style: edit issue template, move it to .github dir
Reduce the titles size in the issue template.
Move the issue template file to GitHub's custom `.github` directory.
2016-04-08 21:31:57 +02:00