Fix#4327
Description:
- QString::arg call with mulpiple arguments replaced with chained
QString::arg calls;
- dynamic memory allocation for array of names replaced with
allocation on the stack, unfortunately I do not notice this while
making Core refactoring.
Also code style is formatted with script
Brief list of changes:
- removed unnecessary headers from core.h and core.cpp;
- added missing brackets and aligned long lists of parameters;
- some other small changes.
noavarice (3):
refactor: removed unnecessary headers and updated copyright info
refactor: slight refactoring of ChatForm class
refactor: onTextEditChanged method refactoring
The project file is deprecated and should not be used anymore as project
file for development. Adding a warning to that effect could help future
contributors while figuring out what they need to do to get started with
qTox.
Signed-off-by: NWeyand <nweyand@users.sourceforge.net>
Made as single commit because this change requires an explanation. As i
understand, `getTypingNotification` always return the same value because
`setTypingNotification` is not connected for any signal and the only
time it's called - from `PrivacyForm`'s method which is never called and
also is not connected to signals. I guess that removing `getTypingNotification`
from `onTextEditChanged` will not affect anything
One part fixes#4280 (removing this flag giving qTox on Windows able to start properly), another part fixes my mistake in #4258 (strmiids still needed for
linking, but previous searching of this libstrmiids.a wasn't include, for example, '/mingw32/i686-w64-mingw32/lib'. So I just add this lib to $ALL_LIBRARIES,
because it exists in system by default).
Fix#4275
I did not consider that replacing one substring with another will point
to shifting position of next URL found with regexp. That's the behavior
of Qt's "QRegularExpression" class - it takes a string into constructor
and seems to make its copy inside so changing source string does not
affect this regex object
Switched to libav*-devel because ffmpeg-devel is not available on
OpenSUSE in the official repos, and libav*-devel provides the headers
for FFmpeg 3.x series.
This commit adds the following fixes to simple_make.sh
- cmake -H -B is undocumented and not officially supported, so replace
it with the standard way
Fixes#4267
- fix build via "opensuse" docker image
+ zypper in sudo (if not installed)
+ replace external program "which" with shell built-in "command -v"
+ update and sorte depencies for OpenSUSE
+ improve the distro test, as OpenSUSE may have apt installed, but
not necessarily lsb_release.
Note:
OpenSUSE has no package called ffmpeg-devel in the official repos, but it
it has ffmpeg2-devel.
