1
0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Commit Graph

15 Commits

Author SHA1 Message Date
Anthony Bilinski
fc2e445294
refactor: Comply with Wshadow
Avoid shadowing variables:
* Rename variables to something better if possible
* If not, postfix shadowing arguments with _. Favour leaving member
  variables without postfixes.
* Rename variables prefixed with _ to avoid library function collisions
* Avoid double underscore anywhere in names
* Make definition and declaration argument names match where seen
* Favour using class variable over argument variable, where equivalent
* Remove explicit this-> where equivalent
2022-03-11 08:35:38 -08:00
Brandon Mosher
1438f8f766 refactor: Provide a Virtual Method Anchor for Classes in Headers
Define at least one virtual method in polymorphic class cpp files to
improve link efficiency. Do so by defining a defaulted destructor or
another overridden virtual method in the class cpp file.
Also add explicitly defaulted copy/move constructors and assignment
operators to follow the rule of five and to avoid compiler suppression
of these functions due to the addition of a user-provided destructor.
Where neccessary, create new cpp files and add them to CMakeLists and
Testing.cmake. Set the -Wweak-vtables by default when compiling with
clang to issue warnings for new classes that do not comply with this
pattern.

See http://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers.

Fixes #6036.
2021-10-26 16:47:40 +00:00
Anthony Bilinski
55fb28b08b
fix(core): extend RAII locker lifetime until end of function
Before it was being constructed then destroyed immediately, not
actually keeping the mutex locked.
2021-06-06 14:34:57 -07:00
Anthony Bilinski
8276141ef9
fix: Replace deprecated QMutex::Recursive with QRecursiveMutex 2021-06-06 01:29:44 -07:00
Anthony Bilinski
653a6f653e
refactor(audio): remove unused set min and max input gain 2021-01-23 18:25:11 -08:00
sudden6
0335f20362
fix: Qt ressource system usage
Make use of the `AUTORCC` feature of cmake to simplify adding resource
files to qTox.

Fixes #6144
2020-07-03 15:45:57 +02:00
Anthony Bilinski
8a9c89f239
Merge pull request #6109
iphydf (1):
      chore(interface): avoid gnu extensions in macros
2020-05-13 00:16:05 -07:00
sudden6
a90f0762d9
refactor(cmake): change folder structure
The new folder structure will be like this:

/<module>/CMakeLists.txt
/<module>/src/file.cpp
/<module>/include/<module>/file.h
/<module>/<subdir>/<...>
2020-05-11 16:45:52 +02:00
sudden6
5d65ab3876
fix(audio): specify format for sounds and make sounds follow it
This should reduce the problem that some sounds are very silent and some are loud.
2018-09-20 17:15:44 +02:00
Anthony Bilinski
65896e4501
feat(call): add call end sound
Fix #4905
2018-04-26 12:49:58 -07:00
Alice Weigt
a06ad7048e feat(audio):OutgoingCallSound
Adds outgoing call sound when call is started
2017-06-14 15:19:30 -07:00
Alice Weigt
3c310f4aa6 refactor: Use new getSound function 2016-10-26 02:17:08 -07:00
dubslow
54eb425238 add ringtone (not well done, but still better than status quo) 2014-10-07 22:33:55 -05:00
krepa098
b6848772fc converted notification.wav to notification.pcm (raw audio) fixes #256 2014-09-10 23:21:37 +02:00
Flynn
2d95acadb9 Add audio notifications 2014-06-27 14:36:44 -07:00