1
0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Commit Graph

7472 Commits

Author SHA1 Message Date
Anthony Bilinski
49abc996ae
Merge branch 'v1.17-dev' 2020-01-19 16:16:57 -08:00
Douglas Rhine
98a364ea2e
fix(build): appease appstream-glib validate
Flathub builds fail if appdata file
does not pass appstream-glib validate.
2020-01-19 16:06:24 -08:00
accelsao
bdb3b61ee0
fix(net): check if the node has all needed fields
Fixes ##5766
2020-01-19 16:06:19 -08:00
sudden6
4283a51df2
Merge pull request #5958
Douglas Rhine (1):
      fix(build): appease appstream-glib validate
2020-01-19 17:57:50 +01:00
Douglas Rhine
dbf58826f6
fix(build): appease appstream-glib validate
Flathub builds fail if appdata file
does not pass appstream-glib validate.
2020-01-18 01:18:35 +00:00
Anthony Bilinski
cf672375be
revert(toxme): remove toxme from qTox - the service is offline permanently
As of 2019-10-09, toxme.io was taken offline permanently. Remove UI and code
in qTox relating to it. Revert this commit if it comes back online in the
future.

Fix #5897
2020-01-16 13:28:41 -08:00
sudden6
41f05f3a02
Merge pull request #5954
accelsao (1):
      fix(net): check if the node has all needed fields
2020-01-16 08:59:18 +01:00
accelsao
ca4f14cc4c fix(net): check if the node has all needed fields
Fixes ##5766
2020-01-14 09:04:55 +08:00
sudden6
1fa35bfcb5
chore: remove Debian bug workaround 2020-01-13 11:19:02 -08:00
sudden6
6fff5a59a4
chore: update AppImage build tools 2020-01-13 11:19:01 -08:00
sudden6
547a038e48
refactor: remove AppImage update bridge
When re-evaluating our dependencies we decided that the update bridge
has a high potential for security issues because it's not widely used.
Additionally similar functionality is already present in qTox.
2020-01-13 11:19:01 -08:00
sudden6
7b45d7d9e1
chore: remove Debian bug workaround 2020-01-12 20:45:03 +01:00
sudden6
cfea3256c7
chore: update AppImage build tools 2020-01-12 20:45:03 +01:00
sudden6
5b3c8aec11
refactor: remove AppImage update bridge
When re-evaluating our dependencies we decided that the update bridge
has a high potential for security issues because it's not widely used.
Additionally similar functionality is already present in qTox.
2020-01-12 20:44:21 +01:00
sudden6
9765cf5c72
Merge pull request #5946
Emery Hemingway (1):
      feat(build): add nix-shell support
2019-12-18 09:42:11 +01:00
Emery Hemingway
faeb699fd0 feat(build): add nix-shell support
Add a metadata file and build rules to build and test from a development
shell provided by the Nix package manager.
2019-12-16 06:57:11 +00:00
Anthony Bilinski
f252816f55
Merge branch 'v1.17-dev' 2019-12-02 08:46:04 -08:00
Anthony Bilinski
7be327714a
Merge pull request #5828
Mick Sayson (1):
      fix(history): Prevent invalid history access
2019-12-02 03:34:34 -08:00
Mick Sayson
e3e6e1d9c4
fix(history): Prevent invalid history access
* When the DB schema was too new we were accessing history anyways. This
has potential to just completely corrupt the DB
* When history was disabled there was a chance we would attempt to write
to history anyways. Added more checks in this area
* Chatform was accessing invalid iterators when there were no displayed
messages. Added a guard for this case
2019-12-02 03:04:53 -08:00
sudden6
9fa6a4996d
chore: add OARS tags to appimage.xml
These tags help app stores and application launchers to put qTox in the
correct categories.

Fixes #5152
2019-12-02 02:02:08 -08:00
Anthony Bilinski
8a821c8858
Merge pull request #5941
Katherine Mantel (1):
      fix(ui): fix auto-accept directory setup display
2019-12-02 01:59:42 -08:00
Katherine Mantel
8c5cab935c
fix(ui): fix auto-accept directory setup display
Fixes #5917
2019-12-02 00:54:19 -08:00
Anthony Bilinski
88d10b1249
refactor(widget): remove uneeded check of if message is targetted
It's only relevant for group messages, where the check already exists.
2019-11-27 08:26:59 -08:00
Anthony Bilinski
9b23abc6de
fix(core): avoid using stack allocated memory past end of scope
tox_file_send was using a pointer to memory that was out of scope. Extend
lifetime of avatarHash to avoid this.
2019-11-27 07:28:47 -08:00
Anthony Bilinski
1f80173b2d
fix(offlinemsg): don't invalidate iterator before use
QMap::erase invalidates the iterator, meaning our usage of it on the
next line was unsafe.
2019-11-27 07:28:47 -08:00
Anthony Bilinski
479b39f536
fix(offlingmsg): only dipatch offline messages on friend online change
Before if the new status was online, we would dipsatch, which could cause
double sends in the case of a friend going from e.g. busy -> away
2019-11-25 20:52:06 -08:00
Anthony Bilinski
239dfdc65c
refactor(status): move isOnline into Status from Friend
Allows checking if a status if equivalent to Online without needing a Friend
class.
2019-11-25 20:52:06 -08:00
Anthony Bilinski
e9570eafdf
Merge branch 'v1.17-dev' 2019-11-25 16:56:50 -08:00
Anthony Bilinski
05064771ab
fix(test): create db tables in defined order, verify indexes
indexes need to be created after their corresponding table is created.
QMap doesn't enforce insertion order, just key order, so use a vector.
Also verify indexes from sql_master instead of only tables.
2019-11-25 16:21:17 -08:00
Anthony Bilinski
edd72906fb
perf(history): enable sql index on chat_id in history table
This makes every query with a "WHERE history.chat_id" clause quicker,
improving history load time by 50% on my profile.

Related to #5812
2019-11-25 16:21:17 -08:00
Anthony Bilinski
af19c0d73b
Merge pull request #5875
Mick Sayson (1):
      fix(chatform): Prevent date line oscillations maxing CPU
2019-11-23 17:27:36 -08:00
sudden6
7475ba4689
chore: remove dead updater code
The server for this updater doesn't exist anymore and it wasn't used in years.
2019-11-22 17:17:50 +01:00
Anthony Bilinski
97d8a53692
Merge pull request #5920
Mick Sayson (2):
      fix(groups): Avoid segfault when resizing group audio window
      fix(groups): Correct color of labels in group call
2019-11-22 02:48:37 -08:00
Anthony Bilinski
0055c7760c
fix(ui): fix reversed mute/unmute hover text 2019-11-18 13:56:56 -08:00
sudden6
25943be3c2
Merge pull request #5931
Igor Kushnir (1):
      fix(ui): quit qTox on Ctrl+Q when "Close to tray" is enabled
2019-11-17 22:01:50 +01:00
Igor Kushnir
f9f634b326 fix(ui): quit qTox on Ctrl+Q when "Close to tray" is enabled
Fixes #5925.
2019-11-17 15:26:49 +02:00
Mick Sayson
3205c2c407
fix(groups): Correct color of labels in group call
Group calls are supposed to show the name of each member under their
avatars. The color of the text was previously fixed to white regardless
of the background ignoring the color of the background.

This fix ensures that the background color is not the same color as the
label text
2019-11-16 14:33:28 -08:00
Mick Sayson
ce9e820b37
fix(groups): Avoid segfault when resizing group audio window
Avatars for group members currently in a call are resized depending on
the area they are displayed in. Previously a scrollbar would appear and
disapear based on the size of the contents. This resulted in
oscillations that ended in a SIGSEGV.

This fix avoids the oscillations by fixing the scrollbar to always be
shown
2019-11-16 14:33:27 -08:00
sudden6
22787a7f3c
Merge pull request #5920
Mick Sayson (2):
      fix(groups): Avoid segfault when resizing group audio window
      fix(groups): Correct color of labels in group call
2019-11-15 21:51:54 +01:00
sudden6
84f1a740c1
Merge pull request #5923
Anthony Bilinski (5):
      fix(chatform): don't try to send empty action messages
      fix(history): move stuck action messages to broken_messages table
      chore: log schema version when we error due to future db
      Merge pull request #5921
      Merge branch 'v1.17-dev'

Mick Sayson (2):
      fix(calls): Fix SIGSEGV on quit while in call
      fix(groups): Fix invalid group list on group member join
2019-11-14 13:38:34 +01:00
Mick Sayson
f27eb5b76c
fix(groups): Correct color of labels in group call
Group calls are supposed to show the name of each member under their
avatars. The color of the text was previously fixed to white regardless
of the background ignoring the color of the background.

This fix ensures that the background color is not the same color as the
label text
2019-11-12 02:44:42 -08:00
Mick Sayson
d4d4308e28
fix(groups): Avoid segfault when resizing group audio window
Avatars for group members currently in a call are resized depending on
the area they are displayed in. Previously a scrollbar would appear and
disapear based on the size of the contents. This resulted in
oscillations that ended in a SIGSEGV.

This fix avoids the oscillations by fixing the scrollbar to always be
shown
2019-11-12 02:44:42 -08:00
Anthony Bilinski
6179250458
Merge branch 'v1.17-dev' 2019-11-11 17:38:02 -08:00
Mick Sayson
836718aa26
fix(groups): Fix invalid group list on group member join
The call to Core::getGroupPeerNames is expected to return a list where
the index in the list is the group member id. In any error case we were
previously breaking this constraint. It turns out that every time
someone joins a group we call this function before they have a valid
name resulting in their id not being added to the list.

This fix ensures that the list coming out of Core::getGroupPeerNames
always has a full list.

Fixes #5838
2019-11-11 17:36:53 -08:00
Anthony Bilinski
08436bc2f1
Merge pull request #5921
Mick Sayson (1):
      fix(calls): Fix SIGSEGV on quit while in call
2019-11-11 17:25:28 -08:00
Mick Sayson
87eed97ab3
fix(calls): Fix SIGSEGV on quit while in call
On application close we used to access invalid memory associated with
the audio subsystem. This was because on destruction of static variables
we tried to access state associated with an already destructed item.

These variables seem to have no good reason to be static. They should be
tied to a single CoreAV instance and are only accessed through an
existing CoreAV instance.
2019-11-11 17:19:21 -08:00
sudden6
7349b44154
Merge pull request #5919
Mick Sayson (1):
      fix(groups): Fix invalid group list on group member join
2019-11-10 13:03:30 +01:00
Mick Sayson
64bae38b99 fix(chatform): Prevent date line oscillations maxing CPU
The previous implementation of hiding the date line would cause 100% cpu
usage. When the date line was shown it would hide the top line, causing
the date line to be hidden again due to a state change in which dates
was visible.

This is a minimal patch to work around the issue by pretending the line
covered by the date line is the first visible line when the dateline is
shown

Fixes #5620
2019-11-09 15:00:36 -08:00
Mick Sayson
fd243738c1 fix(groups): Fix invalid group list on group member join
The call to Core::getGroupPeerNames is expected to return a list where
the index in the list is the group member id. In any error case we were
previously breaking this constraint. It turns out that every time
someone joins a group we call this function before they have a valid
name resulting in their id not being added to the list.

This fix ensures that the list coming out of Core::getGroupPeerNames
always has a full list.

Fixes #5838
2019-11-09 14:21:12 -08:00
Anthony Bilinski
17bbe24ec5
chore: log schema version when we error due to future db 2019-11-04 14:42:20 -08:00