Revert a bug introduced in d126b18d76
where qTox calls tox_bootstrap() and tox_add_relay() with an invalid
argument, which results in qTox not connecting to the bootstrap nodes
from its list of bootsrap nodes and therefore failing to connect to the
Tox DHT network in the case when that list is the only source of nodes
to connect to. The invalid argument is node's public key, which is
non-nullable but is passed a null due to invalid ToxPk object being
constructed. ToxPk's constructor expects the QByteArray argument to be
the byte representation of a public key, but a textual representation
is passed to it instead, which creats an invalid ToxPk that resolves to
null when queried for public key's bytes for calls to tox_bootstrap()
and tox_add_relay().
Fixes#4385
Unfortunately, can not pass local variable on ChatLine::Ptr through
several method calls so ChatMessage inserted after its creating in the
same scope. Updated docs
Brief list of changes:
- "resolveToxId" method's name replaced with "resolveToxPk";
- updated comments for "resolveToxPk" and "needsToHideName";
- changed "resolveToxPk" return value for fail case;
- fixed typo.
Brief list of changes:
- contentdialog.* and friendlistwidget.cpp reverted to their previous states;
- added macros for setting stylesheets for form components;
- added 'static' qualificator for 'fontToCss' function;
- added 'needsToHideName' method and several places in code replaced with this
method's calls;
- some changes which are related to previous listed;
- 'resolveToxId' returned to GenericChatForm class.
Return value of "addMessage" was not used at all, so now this method
(and "addSelfMessage" too) does not have return value - just inserts
message into ChatLog. Also messages are creating with "createMessage"
and "createSelfMessage"
Fix#4327
Description:
- QString::arg call with mulpiple arguments replaced with chained
QString::arg calls;
- dynamic memory allocation for array of names replaced with
allocation on the stack, unfortunately I do not notice this while
making Core refactoring.
Also code style is formatted with script
