Commit Graph

6 Commits (master)

Author SHA1 Message Date
Anthony Bilinski 270286b38c
refactor(audio): Move getVolume and volumeAvailable to qreal from float
Reduces casting back and forth between types.
2022-03-24 04:19:41 -07:00
Anthony Bilinski 8337b935f9
refactor(audio): Remove unused OpenAL::outputVolume 2022-03-24 04:19:41 -07:00
Brandon Mosher 1438f8f766 refactor: Provide a Virtual Method Anchor for Classes in Headers
Define at least one virtual method in polymorphic class cpp files to
improve link efficiency. Do so by defining a defaulted destructor or
another overridden virtual method in the class cpp file.
Also add explicitly defaulted copy/move constructors and assignment
operators to follow the rule of five and to avoid compiler suppression
of these functions due to the addition of a user-provided destructor.
Where neccessary, create new cpp files and add them to CMakeLists and
Testing.cmake. Set the -Wweak-vtables by default when compiling with
clang to issue warnings for new classes that do not comply with this
pattern.

See http://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers.

Fixes #6036.
2021-10-26 16:47:40 +00:00
Anthony Bilinski 653a6f653e
refactor(audio): remove unused set min and max input gain 2021-01-23 18:25:11 -08:00
Anthony Bilinski 8a9c89f239
Merge pull request #6109
iphydf (1):
      chore(interface): avoid gnu extensions in macros
2020-05-13 00:16:05 -07:00
sudden6 a90f0762d9
refactor(cmake): change folder structure
The new folder structure will be like this:

/<module>/CMakeLists.txt
/<module>/src/file.cpp
/<module>/include/<module>/file.h
/<module>/<subdir>/<...>
2020-05-11 16:45:52 +02:00