refactor(avform): Changed combobox index checks on asserts

src/widget/form/settings/avform.cpp

@@ -34,6 +34,7 @@
 #include <QDebug>
 #include <QScreen>
 #include <QShowEvent>
+#include <cassert>
 #include <map>
 
 
@@ -147,17 +148,10 @@ void AVForm::rescanDevices()
 
 void AVForm::on_videoModescomboBox_currentIndexChanged(int index)
 {
-    if (index < 0 || index >= videoModes.size())
+    assert(0 <= index && index < videoModes.size());
-    {
-        qWarning() << "Invalid mode index:" << index;
-        return;
-    }
     int devIndex = videoDevCombobox->currentIndex();
-    if (devIndex < 0 || devIndex >= videoDeviceList.size())
+    assert(0 <= devIndex && devIndex < videoDeviceList.size());
-    {
+
-        qWarning() << "Invalid device index:" << devIndex;
-        return;
-    }
     QString devName = videoDeviceList[devIndex].first;
     VideoMode mode = videoModes[index];
 
@@ -409,11 +403,7 @@ void AVForm::updateVideoModes(int curIndex)
 
 void AVForm::on_videoDevCombobox_currentIndexChanged(int index)
 {
-    if (index < 0 || index >= videoDeviceList.size())
+    assert(0 <= index && index < videoDeviceList.size());
-    {
-        qWarning() << "Invalid index:" << index;
-        return;
-    }
 
     Settings::getInstance().setScreenGrabbed(false);
     QString dev = videoDeviceList[index].first;
@@ -555,6 +545,7 @@ void AVForm::createVideoSurface()
 {
     if (camVideoSurface)
         return;
+
     camVideoSurface = new VideoSurface(QPixmap(), CamFrame);
     camVideoSurface->setObjectName(QStringLiteral("CamVideoSurface"));
     camVideoSurface->setMinimumSize(QSize(160, 120));
@@ -566,6 +557,7 @@ void AVForm::killVideoSurface()
 {
     if (!camVideoSurface)
         return;
+
     QLayoutItem *child;
     while ((child = gridLayout->takeAt(0)) != 0)
         delete child;