StarMirror/qTox
1
0
Fork 0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Code Issues Projects Releases Wiki Activity

refactor(passwordedit): optimize event handler unregistration

Browse Source 
Only search the vector once, and using old enough Qt API.

Follow up to #3418.
This commit is contained in:
Colomban Wendling 2016-06-21 02:49:38 +02:00
parent 279225cd2d
commit ebc3a60e97
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/widget/passwordedit.cpp
View File

@ -42,10 +42,11 @@ void PasswordEdit::registerHandler()
void PasswordEdit::unregisterHandler()
{
#ifdef ENABLE_CAPSLOCK_INDICATOR
if (eventHandler && eventHandler->actions.contains(action))
int idx;
if (eventHandler && (idx = eventHandler->actions.indexOf(action)) >= 0)
{
//TODO: future: use removeOne() when Qt 5.3 (Debian 8) support ends.
eventHandler->actions.remove(eventHandler->actions.indexOf(action));
eventHandler->actions.remove(idx);
if (eventHandler->actions.isEmpty())
{
delete eventHandler;