From e18118c1bc3a7f5b3a51fec43c4e2a1f7ce061e4 Mon Sep 17 00:00:00 2001 From: Anthony Bilinski Date: Wed, 2 Mar 2022 10:52:02 -0800 Subject: [PATCH] chore(CI): Don't try to upload installer on debug builds The installer is only built on release builds. We used to ignore failure to upload prior to 5fcf86b5212b1c36686eaacf9c844ceb0e15adb1. We stopped ignoring because a07ab89cc84bcab3a75277dd4efd1608535127bb tried to make our upload targetted, but it only resolved the issue for the zip, not the installer. --- .github/workflows/build-test-deploy.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build-test-deploy.yaml b/.github/workflows/build-test-deploy.yaml index e6f17e04c..e65961622 100644 --- a/.github/workflows/build-test-deploy.yaml +++ b/.github/workflows/build-test-deploy.yaml @@ -345,6 +345,7 @@ jobs: - name: Run build run: docker-compose run --rm windows_builder ./windows/cross-compile/build.sh --arch x86_64 --build-type ${{ matrix.build_type }} --run-tests --src-dir /qtox - name: Upload installer + if: matrix.build_type == 'release' uses: actions/upload-artifact@v2 with: name: setup-qtox-x86_64-${{ matrix.build_type }}.exe @@ -405,6 +406,7 @@ jobs: - name: Run build run: docker-compose run --rm windows_builder.i686 ./windows/cross-compile/build.sh --arch i686 --build-type ${{ matrix.build_type }} --run-tests --src-dir /qtox - name: Upload installer + if: matrix.build_type == 'release' uses: actions/upload-artifact@v2 with: name: setup-qtox-i686-${{ matrix.build_type }}.exe