refactor(startup): extract startup makeToxPortable logic

This facilitates later use without instantiating Settings object during startup

src/persistence/settings.cpp

@@ -109,17 +109,7 @@ void Settings::loadGlobal()
 
     createSettingsDir();
 
-    QString localSettingsPath = qApp->applicationDirPath() + QDir::separator() + globalSettingsFile;
+    makeToxPortable = Settings::isToxPortable();
-
-    if (QFile(localSettingsPath).exists()) {
-        QSettings ps(localSettingsPath, QSettings::IniFormat);
-        ps.setIniCodec("UTF-8");
-        ps.beginGroup("Advanced");
-        makeToxPortable = ps.value("makeToxPortable", false).toBool();
-        ps.endGroup();
-    } else {
-        makeToxPortable = false;
-    }
 
     QDir dir(getSettingsDirPath());
     QString filePath = dir.filePath(globalSettingsFile);
@@ -273,6 +263,22 @@ void Settings::loadGlobal()
     loaded = true;
 }
 
+bool Settings::isToxPortable()
+{
+    QString localSettingsPath = qApp->applicationDirPath() + QDir::separator() + globalSettingsFile;
+    bool result;
+
+    if (QFile(localSettingsPath).exists()) {
+        QSettings ps(localSettingsPath, QSettings::IniFormat);
+        ps.setIniCodec("UTF-8");
+        ps.beginGroup("Advanced");
+        result = ps.value("makeToxPortable", false).toBool();
+        ps.endGroup();
+        return result;
+    }
+    return false;
+}
+
 void Settings::updateProfileData(Profile *profile)
 {
     QMutexLocker locker{&bigLock};

src/persistence/settings.h

@@ -154,6 +154,7 @@ public:
     void savePersonal();
 
     void loadGlobal();
+    bool isToxPortable();
     void loadPersonal(QString profileName, const ToxEncrypt* passKey);
 
     void resetToDefault();