StarMirror/qTox
1
0
Fork 0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Code Issues Projects Releases Wiki Activity

fix(CI): Fix memory leak in core_test

Browse Source 
Causes false positives when running tests with ASAN
This commit is contained in:
Anthony Bilinski 2022-02-17 07:27:41 -08:00
parent 0cb760dfa2
commit 9cd9da4a53
No known key found for this signature in database
GPG Key ID: 2AA8E0DA1B31FB3C
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
test/core/core_test.cpp
View File

@ -22,13 +22,15 @@
#include "src/core/icoresettings.h"
#include "src/net/bootstrapnodeupdater.h"
#include "src/model/ibootstraplistgenerator.h"
#include "src/persistence/settings.h"
#include <QtTest/QtTest>
#include <QtGlobal>
#include <limits>
#include <QSignalSpy>
#include <src/persistence/settings.h>
#include <iostream>
#include <memory>
Q_DECLARE_METATYPE(QList<DhtServer>)
@ -94,7 +96,7 @@ private slots:
private:
/* Test Variables */
Core::ToxCoreErrors* err = nullptr;
MockSettings* settings;
std::unique_ptr<MockSettings> settings;
QByteArray savedata{};
ToxCorePtr test_core;
};
@ -106,7 +108,7 @@ namespace {
void TestCore::startup_without_proxy()
{
settings = new MockSettings();
settings = std::unique_ptr<MockSettings>(new MockSettings());
// No proxy
settings->setProxyAddr("");
@ -115,7 +117,7 @@ void TestCore::startup_without_proxy()
MockNodeListGenerator nodesGenerator{};
test_core = Core::makeToxCore(savedata, settings, nodesGenerator, err);
test_core = Core::makeToxCore(savedata, settings.get(), nodesGenerator, err);
if (test_core == nullptr) {
QFAIL("ToxCore initialisation failed");
@ -133,8 +135,7 @@ void TestCore::startup_without_proxy()
void TestCore::startup_with_invalid_proxy()
{
settings = new MockSettings();
settings = std::unique_ptr<MockSettings>(new MockSettings());
// Test invalid proxy SOCKS5
settings->setProxyAddr("Test");
@ -143,7 +144,7 @@ void TestCore::startup_with_invalid_proxy()
MockNodeListGenerator nodesGenerator{};
test_core = Core::makeToxCore(savedata, settings, nodesGenerator, err);
test_core = Core::makeToxCore(savedata, settings.get(), nodesGenerator, err);
if (test_core != nullptr) {
QFAIL("ToxCore initialisation passed with invalid SOCKS5 proxy address");
@ -155,7 +156,7 @@ void TestCore::startup_with_invalid_proxy()
settings->setProxyPort(9985);
settings->setProxyType(MockSettings::ProxyType::ptHTTP);
test_core = Core::makeToxCore(savedata, settings, nodesGenerator, err);
test_core = Core::makeToxCore(savedata, settings.get(), nodesGenerator, err);
if (test_core != nullptr) {
QFAIL("ToxCore initialisation passed with invalid HTTP proxy address");