From 949e3cb830134a1412b93d751a1d16dd80877aba Mon Sep 17 00:00:00 2001
From: Zetok Zalbavar <zetok@openmailbox.org>
Date: Sun, 13 Nov 2016 23:44:05 +0000
Subject: [PATCH] feat(UI): add accessibility labels to the Profile page

---
 src/widget/form/profileform.cpp |  2 +
 src/widget/form/profileform.ui  | 66 ++++++++++++++++++++++++++++++++-
 2 files changed, 66 insertions(+), 2 deletions(-)

diff --git a/src/widget/form/profileform.cpp b/src/widget/form/profileform.cpp
index 556ab204e..313954eb8 100644
--- a/src/widget/form/profileform.cpp
+++ b/src/widget/form/profileform.cpp
@@ -101,6 +101,8 @@ ProfileForm::ProfileForm(QWidget *parent) :
     profilePicture->setContextMenuPolicy(Qt::CustomContextMenu);
     profilePicture->setClickable(true);
     profilePicture->installEventFilter(this);
+    profilePicture->setAccessibleName("Profile avatar");
+    profilePicture->setAccessibleDescription("Set a profile avatar shown to all contacts");
     connect(profilePicture, SIGNAL(clicked()), this, SLOT(onAvatarClicked()));
     connect(profilePicture, SIGNAL(customContextMenuRequested(const QPoint&)), this, SLOT(showProfilePictureContextMenu(const QPoint&)));
     QHBoxLayout *publicGrouplayout = qobject_cast<QHBoxLayout*>(bodyUI->publicGroup->layout());
diff --git a/src/widget/form/profileform.ui b/src/widget/form/profileform.ui
index 1844e31b3..bdd4165db 100644
--- a/src/widget/form/profileform.ui
+++ b/src/widget/form/profileform.ui
@@ -69,7 +69,14 @@
              </widget>
             </item>
             <item row="0" column="1">
-             <widget class="QLineEdit" name="userName"/>
+             <widget class="QLineEdit" name="userName">
+              <property name="accessibleName">
+               <string>Name input</string>
+              </property>
+              <property name="accessibleDescription">
+               <string>Name visible to contacts</string>
+              </property>
+             </widget>
             </item>
             <item row="1" column="0">
              <widget class="QLabel" name="statusMessageLabel">
@@ -79,7 +86,14 @@
              </widget>
             </item>
             <item row="1" column="1">
-             <widget class="QLineEdit" name="statusMessage"/>
+             <widget class="QLineEdit" name="statusMessage">
+              <property name="accessibleName">
+               <string>Status message input</string>
+              </property>
+              <property name="accessibleDescription">
+               <string>Status message visible to contacts</string>
+              </property>
+             </widget>
             </item>
            </layout>
           </item>
@@ -105,6 +119,9 @@ Share it with your friends to communicate.</string>
           </item>
           <item>
            <widget class="QLineEdit" name="toxId">
+            <property name="accessibleDescription">
+             <string>Your Tox ID</string>
+            </property>
             <property name="frame">
              <bool>true</bool>
             </property>
@@ -132,6 +149,9 @@ Share it with your friends to communicate.</string>
                 </item>
                 <item alignment="Qt::AlignVCenter">
                  <widget class="QPushButton" name="saveQr">
+                  <property name="accessibleDescription">
+                   <string>Save QR image as file</string>
+                  </property>
                   <property name="text">
                    <string>Save image</string>
                   </property>
@@ -139,6 +159,9 @@ Share it with your friends to communicate.</string>
                 </item>
                 <item alignment="Qt::AlignVCenter">
                  <widget class="QPushButton" name="copyQr">
+                  <property name="accessibleDescription">
+                   <string>Copy QR image to clipboard</string>
+                  </property>
                   <property name="text">
                    <string>Copy image</string>
                   </property>
@@ -173,6 +196,9 @@ Share it with your friends to communicate.</string>
               <property name="toolTip">
                <string comment="Tooltip for the `Username` ToxMe field.">Name for the ToxMe service.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>ToxMe username to be shown on ToxMe</string>
+              </property>
               <property name="autoFillBackground">
                <bool>false</bool>
               </property>
@@ -193,6 +219,9 @@ Share it with your friends to communicate.</string>
               <property name="toolTip">
                <string comment="Tooltip for the Biography field.">Optional. Something about you. Or your cat.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>Optional ToxMe biography to be shown on ToxMe</string>
+              </property>
              </widget>
             </item>
             <item row="3" column="0">
@@ -213,6 +242,9 @@ Share it with your friends to communicate.</string>
               <property name="toolTip">
                <string>ToxMe service to register on.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>ToxMe service address</string>
+              </property>
               <property name="editable">
                <bool>true</bool>
               </property>
@@ -226,6 +258,9 @@ Share it with your friends to communicate.</string>
               <property name="toolTip">
                <string comment="Tooltip for the `Hide my name from public list` ToxMe checkbox.">If not set, ToxMe entries are publicly visible.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>Visibility on the ToxMe service</string>
+              </property>
               <property name="text">
                <string>Hide my name from the public list</string>
               </property>
@@ -236,6 +271,9 @@ Share it with your friends to communicate.</string>
               <property name="enabled">
                <bool>true</bool>
               </property>
+              <property name="accessibleDescription">
+               <string>Register on ToxMe</string>
+              </property>
               <property name="text">
                <string>Register</string>
               </property>
@@ -262,6 +300,9 @@ Share it with your friends to communicate.</string>
             </item>
             <item row="7" column="1">
              <widget class="QLineEdit" name="toxmePassword">
+              <property name="accessibleDescription">
+               <string>Password</string>
+              </property>
               <property name="frame">
                <bool>false</bool>
               </property>
@@ -277,6 +318,9 @@ Share it with your friends to communicate.</string>
              <layout class="QHBoxLayout" name="horizontalLayout_6">
               <item>
                <widget class="QPushButton" name="toxmeUpdateButton">
+                <property name="accessibleDescription">
+                 <string>Update ToxMe entry</string>
+                </property>
                 <property name="text">
                  <string>Update</string>
                 </property>
@@ -347,6 +391,9 @@ Share it with your friends to communicate.</string>
               <property name="toolTip">
                <string comment="tooltip for renaming profile button">Rename profile.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>Rename profile.</string>
+              </property>
               <property name="text">
                <string comment="rename profile button">Rename</string>
               </property>
@@ -357,6 +404,9 @@ Share it with your friends to communicate.</string>
               <property name="toolTip">
                <string comment="delete profile button tooltip">Delete profile.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>Delete profile.</string>
+              </property>
               <property name="text">
                <string comment="delete profile button">Delete</string>
               </property>
@@ -368,6 +418,9 @@ Share it with your friends to communicate.</string>
                <string comment="tooltip for profile exporting button">Allows you to export your Tox profile to a file.
 Profile does not contain your history.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>Export profile</string>
+              </property>
               <property name="text">
                <string comment="export profile button">Export</string>
               </property>
@@ -378,6 +431,9 @@ Profile does not contain your history.</string>
               <property name="toolTip">
                <string comment="tooltip for logout button">Go back to the login screen</string>
               </property>
+              <property name="accessibleDescription">
+               <string/>
+              </property>
               <property name="text">
                <string comment="import profile button">Logout</string>
               </property>
@@ -418,6 +474,9 @@ Profile does not contain your history.</string>
               <property name="toolTip">
                <string comment="Tooltip for the `Remove password` button.">Remove your password and encryption from your profile.</string>
               </property>
+              <property name="accessibleDescription">
+               <string>Remove password from profile</string>
+              </property>
               <property name="text">
                <string>Remove password</string>
               </property>
@@ -425,6 +484,9 @@ Profile does not contain your history.</string>
             </item>
             <item>
              <widget class="QPushButton" name="changePassButton">
+              <property name="accessibleDescription">
+               <string>Change profile password</string>
+              </property>
               <property name="text">
                <string>Change password</string>
               </property>