StarMirror/qTox
1
0
Fork 0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Code Issues Projects Releases Wiki Activity

fix(platform): use result to remove -Wunused-result warning

Browse Source 
Check for write() and read() results and abort in case of unexpected
failure.
This commit is contained in:
Vincas Dargis 2017-10-03 19:52:08 +03:00
parent 6e0bdf2cd2
commit 729dc7740b
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/platform/posixsignalnotifier.cpp
View File

@ -53,7 +53,12 @@ static void signalHandler(int signum)
if (g_signalSocketUsageFlag.test_and_set()) if (g_signalSocketUsageFlag.test_and_set())
return; return;
::write(g_signalSocketPair[0], &signum, sizeof(signum)); if(::write(g_signalSocketPair[0], &signum, sizeof(signum)) == -1) {
// We hardly can do anything more usefull in signal handler, and
// any ways it's probably very unexpected error (out of memory?),
// since we check socket existance with a flag beforehand.
abort();
}
g_signalSocketUsageFlag.clear(); g_signalSocketUsageFlag.clear();
} }
@ -109,7 +114,9 @@ PosixSignalNotifier& PosixSignalNotifier::globalInstance()
void PosixSignalNotifier::onSignalReceived() void PosixSignalNotifier::onSignalReceived()
{ {
int signum{0}; int signum{0};
::read(detail::g_signalSocketPair[1], &signum, sizeof(signum)); if (::read(detail::g_signalSocketPair[1], &signum, sizeof(signum)) == -1) {
qFatal("Failed to read from signal socket, error = %d", errno);
}
qDebug() << "Signal" << signum << "received"; qDebug() << "Signal" << signum << "received";
emit activated(signum); emit activated(signum);