StarMirror/qTox
1
0
Fork 0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Code Issues Projects Releases Wiki Activity

chore(style): add CppCoreGuidlines as reference

Browse Source 
Also fix #3851 while at it.
This commit is contained in:
sudden6 2019-10-14 12:24:01 +02:00
parent af82a2dcef
commit 48d23234b7
No known key found for this signature in database
GPG Key ID: 279509B499E032B9
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
doc/coding_standards.md
View File

@ -10,6 +10,9 @@ be applied by simply running clang-format over the source code in question.
You can run [`tools/format-code.sh`] to format all C++ files tracked by You can run [`tools/format-code.sh`] to format all C++ files tracked by
git. git.
In case something is not specified in the following paragraphs, the
[CppCoreGuidelines] apply.
## Coding Standard ## Coding Standard
qTox is written under **[ISO/IEC 14882:2011 (C++11)][ISO/IEC/C++11]** without qTox is written under **[ISO/IEC 14882:2011 (C++11)][ISO/IEC/C++11]** without
@ -300,6 +303,24 @@ void foo(int* x, int&&); // Forward function declaration pointers and rvalue ref
// even if there is no name. // even if there is no name.
``` ```
To avoid side effects, calling a static member function via an object-expression
is not allowed. The only allowed way is via the class name.
```c++
class foo {
public:
static void bar();
};
foo& g();
void f()
{
foo::bar(); // OK: no object necessary
g().bar(); // Not OK: g() can cause side effects
}
```
### Unary Increment/Decrement ### Unary Increment/Decrement
When the use of the prefix and postfix notation for increment and decrement When the use of the prefix and postfix notation for increment and decrement
@ -550,4 +571,5 @@ For more info, see:
[QStringLiteral explained]: https://woboq.com/blog/qstringliteral.html [QStringLiteral explained]: https://woboq.com/blog/qstringliteral.html
[String concatenation with QStringBuilder]: https://blog.qt.io/blog/2011/06/13/string-concatenation-with-qstringbuilder/ [String concatenation with QStringBuilder]: https://blog.qt.io/blog/2011/06/13/string-concatenation-with-qstringbuilder/
[Latin-1]: https://en.wikipedia.org/wiki/ISO/IEC_8859-1 [Latin-1]: https://en.wikipedia.org/wiki/ISO/IEC_8859-1
[CppCoreGuidelines]: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#main