StarMirror/qTox
1
0
Fork 0
mirror of https://github.com/qTox/qTox.git synced 2024-03-22 14:00:36 +08:00
Code Issues Projects Releases Wiki Activity

chore(CI): Set a very long timeout for core_online_test

Browse Source 
CI has very flaky network causing everything to take way longer than expected.
None of the tests are actually checking that something happens quickly, so just
set a stupidly long timeout to avoid flakiness.
This commit is contained in:
Anthony Bilinski 2022-03-07 03:19:04 -08:00
parent 82b12f95fe
commit 30d54b1b0f
No known key found for this signature in database
GPG Key ID: 2AA8E0DA1B31FB3C
1 changed files with 19 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
test/core/core_online_test.cpp
View File

@ -54,9 +54,8 @@ QList<DhtServer> MockNodeListGenerator::getBootstrapnodes() const {
} }
namespace { namespace {
const int bootstrap_timeout = 120000; // timeout for bootstrapping const int very_long_timeout = 10 * 60 * 1000;
const int local_timeout = 500; // timeout for operations happening offline const int connected_message_wait = 15000; // timeout for alice and bob messaging
const int connected_message_timeout = 15000; // timeout for alice and bob messaging
} }
class TestCoreOnline : public QObject class TestCoreOnline : public QObject
@ -104,7 +103,7 @@ void TestCoreOnline::init()
bob->start(); bob->start();
// Wait for both instances coming online // Wait for both instances coming online
QTRY_VERIFY_WITH_TIMEOUT(spyAliceOnline.count() >= 1 && spyBobOnline.count() >= 1, bootstrap_timeout); QTRY_VERIFY_WITH_TIMEOUT(spyAliceOnline.count() >= 1 && spyBobOnline.count() >= 1, very_long_timeout);
// Make a friend request from alice to bob // Make a friend request from alice to bob
const QLatin1String friendMsg{"Test Invite Message"}; const QLatin1String friendMsg{"Test Invite Message"};
@ -114,7 +113,7 @@ void TestCoreOnline::init()
alice->requestFriendship(bob->getSelfId(), friendMsg); alice->requestFriendship(bob->getSelfId(), friendMsg);
// Wait for friend message to be received // Wait for friend message to be received
QTRY_VERIFY_WITH_TIMEOUT(spyBobFriendMsg.count() == 1 && spyAliceFriendMsg.count() == 1, bootstrap_timeout); QTRY_VERIFY_WITH_TIMEOUT(spyBobFriendMsg.count() == 1 && spyAliceFriendMsg.count() == 1, very_long_timeout);
// Check for expected signal content // Check for expected signal content
QVERIFY(qvariant_cast<ToxPk>(spyBobFriendMsg[0][0]) == alice->getSelfPublicKey()); QVERIFY(qvariant_cast<ToxPk>(spyBobFriendMsg[0][0]) == alice->getSelfPublicKey());
@ -130,7 +129,7 @@ void TestCoreOnline::init()
QSignalSpy spyAliceFriendOnline(alice.get(), &Core::friendStatusChanged); QSignalSpy spyAliceFriendOnline(alice.get(), &Core::friendStatusChanged);
QSignalSpy spyBobFriendOnline(bob.get(), &Core::friendStatusChanged); QSignalSpy spyBobFriendOnline(bob.get(), &Core::friendStatusChanged);
QTRY_VERIFY_WITH_TIMEOUT(spyAliceFriendOnline.count() >= 1 && spyBobFriendOnline.count() >= 1, bootstrap_timeout); QTRY_VERIFY_WITH_TIMEOUT(spyAliceFriendOnline.count() >= 1 && spyBobFriendOnline.count() >= 1, very_long_timeout);
// Check for expected signal content // Check for expected signal content
QVERIFY(spyAliceFriendOnline[0][0].toInt() == static_cast<int>(Status::Status::Online)); QVERIFY(spyAliceFriendOnline[0][0].toInt() == static_cast<int>(Status::Status::Online));
@ -154,20 +153,20 @@ void TestCoreOnline::change_name()
alice->setUsername(aliceName); alice->setUsername(aliceName);
QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 1, local_timeout); QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 1, very_long_timeout);
QTRY_VERIFY_WITH_TIMEOUT(aliceUsernameChanged.count() == 1 && QTRY_VERIFY_WITH_TIMEOUT(aliceUsernameChanged.count() == 1 &&
aliceUsernameChanged[0][0].toString() == aliceName, aliceUsernameChanged[0][0].toString() == aliceName,
local_timeout); very_long_timeout);
QTRY_VERIFY_WITH_TIMEOUT(bobUsernameChangeReceived.count() == 1 && QTRY_VERIFY_WITH_TIMEOUT(bobUsernameChangeReceived.count() == 1 &&
bobUsernameChangeReceived[0][1].toString() == aliceName, connected_message_timeout); bobUsernameChangeReceived[0][1].toString() == aliceName, very_long_timeout);
// Setting the username again to the same value shoud NOT trigger any signals // Setting the username again to the same value shoud NOT trigger any signals
alice->setUsername(aliceName); alice->setUsername(aliceName);
// Need to sleep here, because we're testing that these don't increase based on // Need to sleep here, because we're testing that these don't increase based on
// Alice re-setting her username, so QTRY_VERIFY_WITH_TIMEOUT would return immediately. // Alice re-setting her username, so QTRY_VERIFY_WITH_TIMEOUT would return immediately.
QTest::qSleep(connected_message_timeout); QTest::qSleep(connected_message_wait);
QVERIFY(aliceSaveRequest.count() == 1); QVERIFY(aliceSaveRequest.count() == 1);
QVERIFY(aliceUsernameChanged.count() == 1); QVERIFY(aliceUsernameChanged.count() == 1);
QVERIFY(bobUsernameChangeReceived.count() == 1); QVERIFY(bobUsernameChangeReceived.count() == 1);
@ -184,20 +183,20 @@ void TestCoreOnline::change_status_message()
alice->setStatusMessage(aliceStatusMsg); alice->setStatusMessage(aliceStatusMsg);
QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 1, local_timeout); QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 1, very_long_timeout);
QTRY_VERIFY_WITH_TIMEOUT(aliceStatusMsgChanged.count() == 1 && QTRY_VERIFY_WITH_TIMEOUT(aliceStatusMsgChanged.count() == 1 &&
aliceStatusMsgChanged[0][0].toString() == aliceStatusMsg, aliceStatusMsgChanged[0][0].toString() == aliceStatusMsg,
local_timeout); very_long_timeout);
QTRY_VERIFY_WITH_TIMEOUT(bobStatusMsgChangeReceived.count() == 1 && QTRY_VERIFY_WITH_TIMEOUT(bobStatusMsgChangeReceived.count() == 1 &&
bobStatusMsgChangeReceived[0][1].toString() == aliceStatusMsg, connected_message_timeout); bobStatusMsgChangeReceived[0][1].toString() == aliceStatusMsg, very_long_timeout);
// Setting the status message again to the same value shoud NOT trigger any signals // Setting the status message again to the same value shoud NOT trigger any signals
alice->setStatusMessage(aliceStatusMsg); alice->setStatusMessage(aliceStatusMsg);
// Need to sleep here, because we're testing that these don't increase based on // Need to sleep here, because we're testing that these don't increase based on
// Alice re-setting her status message, so QTRY_VERIFY_WITH_TIMEOUT would return immediately. // Alice re-setting her status message, so QTRY_VERIFY_WITH_TIMEOUT would return immediately.
QTest::qSleep(connected_message_timeout); QTest::qSleep(connected_message_wait);
QVERIFY(aliceSaveRequest.count() == 1); QVERIFY(aliceSaveRequest.count() == 1);
QVERIFY(aliceStatusMsgChanged.count() == 1); QVERIFY(aliceStatusMsgChanged.count() == 1);
QVERIFY(bobStatusMsgChangeReceived.count() == 1); QVERIFY(bobStatusMsgChangeReceived.count() == 1);
@ -211,27 +210,27 @@ void TestCoreOnline::change_status()
alice->setStatus(Status::Status::Away); alice->setStatus(Status::Status::Away);
QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 1, local_timeout); QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 1, very_long_timeout);
QTRY_VERIFY_WITH_TIMEOUT(aliceStatusChanged.count() == 1 && QTRY_VERIFY_WITH_TIMEOUT(aliceStatusChanged.count() == 1 &&
qvariant_cast<Status::Status>(aliceStatusChanged[0][0]) == Status::Status::Away, qvariant_cast<Status::Status>(aliceStatusChanged[0][0]) == Status::Status::Away,
local_timeout); very_long_timeout);
QTRY_VERIFY_WITH_TIMEOUT(bobStatusChangeReceived.count() == 1 && QTRY_VERIFY_WITH_TIMEOUT(bobStatusChangeReceived.count() == 1 &&
qvariant_cast<Status::Status>(bobStatusChangeReceived[0][1]) == Status::Status::Away, qvariant_cast<Status::Status>(bobStatusChangeReceived[0][1]) == Status::Status::Away,
connected_message_timeout); very_long_timeout);
// Setting the status message again to the same value again triggers all signals // Setting the status message again to the same value again triggers all signals
alice->setStatus(Status::Status::Away); alice->setStatus(Status::Status::Away);
// TODO(sudden6): Emitting these again odd and should probably be changed, lets codify it for now though // TODO(sudden6): Emitting these again odd and should probably be changed, lets codify it for now though
QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 2, local_timeout); QTRY_VERIFY_WITH_TIMEOUT(aliceSaveRequest.count() == 2, very_long_timeout);
QTRY_VERIFY_WITH_TIMEOUT(aliceStatusChanged.count() == 2 && QTRY_VERIFY_WITH_TIMEOUT(aliceStatusChanged.count() == 2 &&
qvariant_cast<Status::Status>(aliceStatusChanged[1][0]) == Status::Status::Away, qvariant_cast<Status::Status>(aliceStatusChanged[1][0]) == Status::Status::Away,
local_timeout); very_long_timeout);
// Need to sleep here, because we're testing that we don't get a new signal for the re-set but // Need to sleep here, because we're testing that we don't get a new signal for the re-set but
// unchanged status, so QTRY_VERIFY_WITH_TIMEOUT would return immediately. // unchanged status, so QTRY_VERIFY_WITH_TIMEOUT would return immediately.
QTest::qSleep(connected_message_timeout); QTest::qSleep(connected_message_wait);
QVERIFY(bobStatusChangeReceived.count() == 1); QVERIFY(bobStatusChangeReceived.count() == 1);
} }