Add an option for auto-updates on Windows

With the update server hosted on my laptop...

Fun fact: Updates are really easy to mess up right now. If I forget to update the update server, everyone gets downgraded. Upload a bad file and everyone will crash. Fun stuff.

Upates Are Experimental™ and off by default.

src/autoupdate.cpp

@@ -18,12 +18,15 @@
 #include "src/autoupdate.h"
 #include "src/misc/serialize.h"
 #include "src/misc/settings.h"
+#include "src/widget/widget.h"
 #include <QNetworkAccessManager>
 #include <QNetworkReply>
 #include <QCoreApplication>
 #include <QFile>
 #include <QDir>
 #include <QProcess>
+#include <QtConcurrent/QtConcurrent>
+#include <QMessageBox>
 
 #ifdef Q_OS_WIN
 #include <windows.h>
@@ -37,7 +40,7 @@ const QString AutoUpdater::updaterBin = "qtox-updater.exe";
 const QString AutoUpdater::platform;
 const QString AutoUpdater::updaterBin;
 #endif
-const QString AutoUpdater::updateServer = "http://127.0.0.1";
+const QString AutoUpdater::updateServer = "http://mlkj.bounceme.net";
 const QString AutoUpdater::checkURI = AutoUpdater::updateServer+"/qtox/"+AutoUpdater::platform+"/version";
 const QString AutoUpdater::flistURI = AutoUpdater::updateServer+"/qtox/"+AutoUpdater::platform+"/flist";
 const QString AutoUpdater::filesURI = AutoUpdater::updateServer+"/qtox/"+AutoUpdater::platform+"/files/";
@@ -392,3 +395,20 @@ fail:
     QDir(updateDirStr).removeRecursively();
     exit(-1);
 }
+
+void AutoUpdater::checkUpdatesAsyncInteractive()
+{
+    QtConcurrent::run(&AutoUpdater::checkUpdatesAsyncInteractiveWorker);
+}
+
+void AutoUpdater::checkUpdatesAsyncInteractiveWorker()
+{
+    if (!isUpdateAvailable())
+        return;
+
+    if (Widget::getInstance()->askMsgboxQuestion(QObject::tr("Update", "The title of a message box"),
+        QObject::tr("An update is available, do you want to download it now ?\nIt will be installed when qTox restarts.")))
+    {
+        downloadUpdate();
+    }
+}

src/autoupdate.h

@@ -57,6 +57,10 @@ public:
     };
 
 public:
+    /// Connects to the qTox update server, if an updat is found shows a dialog to the user asking to download it
+    /// Runs asynchronously in its own thread, and will return immediatly
+    /// Will call isUpdateAvailable, and as such may processEvents
+    static void checkUpdatesAsyncInteractive();
     /// Connects to the qTox update server, returns true if an update is available for download
     /// Will call getUpdateVersion, and as such may block and processEvents
     static bool isUpdateAvailable();
@@ -90,6 +94,9 @@ protected:
     /// Note that a file with an empty but non-null QByteArray is not an error, merely a file of size 0.
     /// Will try to follow qTox's proxy settings, may block and processEvents
     static UpdateFile getUpdateFile(UpdateFileMeta fileMeta);
+    /// Does the actual work for checkUpdatesAsyncInteractive
+    /// Blocking, but otherwise has the same properties than checkUpdatesAsyncInteractive
+    static void checkUpdatesAsyncInteractiveWorker();
 
 private:
     AutoUpdater() = delete;

src/misc/settings.cpp

@@ -119,6 +119,7 @@ void Settings::load()
         proxyPort = s.value("proxyPort", 0).toInt();
         currentProfile = s.value("currentProfile", "").toString();
     	autoAwayTime = s.value("autoAwayTime", 10).toInt();
+        checkUpdates = s.value("checkUpdates", false).toBool();
     s.endGroup();
 
     s.beginGroup("Widgets");
@@ -255,6 +256,7 @@ void Settings::save(QString path)
         s.setValue("proxyPort", proxyPort);
         s.setValue("currentProfile", currentProfile);
         s.setValue("autoAwayTime", autoAwayTime);
+        s.setValue("checkUpdates", checkUpdates);
     s.endGroup();
 
     s.beginGroup("Widgets");
@@ -727,6 +729,16 @@ void Settings::setWindowState(const QByteArray &value)
     windowState = value;
 }
 
+bool Settings::getCheckUpdates() const
+{
+    return checkUpdates;
+}
+
+void Settings::setCheckUpdates(bool newValue)
+{
+    checkUpdates = newValue;
+}
+
 QByteArray Settings::getSplitterState() const
 {
     return splitterState;

src/misc/settings.h

@@ -99,6 +99,9 @@ public:
     int getAutoAwayTime() const;
     void setAutoAwayTime(int newValue);
 
+    bool getCheckUpdates() const;
+    void setCheckUpdates(bool newValue);
+
     QPixmap getSavedAvatar(const QString& ownerId);
     void saveAvatar(QPixmap& pic, const QString& ownerId);
 
@@ -219,6 +222,7 @@ private:
     bool closeToTray;
     bool minimizeToTray;
     bool useEmoticons;
+    bool checkUpdates;
 
     bool forceTCP;
 

src/widget/form/settings/generalform.cpp

@@ -27,6 +27,8 @@
 #include <QFileDialog>
 #include <QStandardPaths>
 
+#include "src/autoupdate.h"
+
 static QStringList locales = {"bg", "de", "en", "fr", "it", "mannol", "pirate", "pl", "ru", "fi", "sv", "uk"};
 static QStringList langs = {"Български", "Deustch", "English", "Français", "Italiano", "mannol", "Pirate", "Polski", "Русский", "Suomi", "Svenska", "Українська"};
 
@@ -40,6 +42,9 @@ GeneralForm::GeneralForm(SettingsWidget *myParent) :
     bodyUI = new Ui::GeneralSettings;
     bodyUI->setupUi(this);
 
+    bodyUI->checkUpdates->setVisible(AUTOUPDATE_ENABLED);
+    bodyUI->checkUpdates->setChecked(Settings::getInstance().getCheckUpdates());
+    
     bodyUI->cbEnableIPv6->setChecked(Settings::getInstance().getEnableIPv6());
     for (int i = 0; i < langs.size(); i++)
         bodyUI->transComboBox->insertItem(i, langs[i]);
@@ -93,6 +98,7 @@ GeneralForm::GeneralForm(SettingsWidget *myParent) :
     onUseProxyUpdated();
 
     //general
+    connect(bodyUI->checkUpdates, &QCheckBox::stateChanged, this, &GeneralForm::onCheckUpdateChanged);
     connect(bodyUI->transComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(onTranslationUpdated()));
     connect(bodyUI->cbMakeToxPortable, &QCheckBox::stateChanged, this, &GeneralForm::onMakeToxPortableUpdated);
     connect(bodyUI->startInTray, &QCheckBox::stateChanged, this, &GeneralForm::onSetAutostartInTray);
@@ -280,3 +286,8 @@ void GeneralForm::reloadSmiles()
     bodyUI->smile4->setToolTip(smiles[3]);
     bodyUI->smile5->setToolTip(smiles[4]);
 }
+
+void GeneralForm::onCheckUpdateChanged()
+{
+    Settings::getInstance().setCheckUpdates(bodyUI->checkUpdates->isChecked());
+}

src/widget/form/settings/generalform.h

@@ -51,6 +51,7 @@ private slots:
     void onReconnectClicked();
     void onAutoAcceptFileChange();
     void onAutoSaveDirChange();
+    void onCheckUpdateChanged();
 
 private:
     Ui::GeneralSettings *bodyUI;

src/widget/form/settings/generalsettings.ui

@@ -40,7 +40,7 @@
         <x>0</x>
         <y>0</y>
         <width>511</width>
-        <height>739</height>
+        <height>720</height>
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout_4" stretch="0,0,1">
@@ -121,6 +121,13 @@
             </property>
            </widget>
           </item>
+          <item>
+           <widget class="QCheckBox" name="checkUpdates">
+            <property name="text">
+             <string>Check for updates on startup (unstable)</string>
+            </property>
+           </widget>
+          </item>
           <item>
            <layout class="QHBoxLayout" name="horizontalLayout_2">
             <item alignment="Qt::AlignLeft">

src/widget/widget.cpp

@@ -245,6 +245,11 @@ void Widget::init()
     coreThread->start();
 
     addFriendForm->show(*ui);
+
+#if (AUTOUPDATE_ENABLED)
+    if (Settings::getInstance().getCheckUpdates())
+        AutoUpdater::checkUpdatesAsyncInteractive();
+#endif
 }
 
 void Widget::setTranslation()
@@ -1096,3 +1101,20 @@ void Widget::setEnabledThreadsafe(bool enabled)
         return setEnabled(enabled);
     }
 }
+
+bool Widget::askMsgboxQuestion(const QString& title, const QString& msg)
+{
+    // We can only display widgets from the GUI thread
+    if (QThread::currentThread() != qApp->thread())
+    {
+        bool ret;
+        QMetaObject::invokeMethod(this, "askMsgboxQuestion", Qt::BlockingQueuedConnection,
+                                  Q_RETURN_ARG(bool, ret),
+                                  Q_ARG(const QString&, title), Q_ARG(const QString&, msg));
+        return ret;
+    }
+    else
+    {
+        return QMessageBox::question(this, title, msg) == QMessageBox::StandardButton::Yes;
+    }
+}

src/widget/widget.h

@@ -67,6 +67,7 @@ public:
     Q_INVOKABLE QMessageBox::StandardButton showWarningMsgBox(const QString& title, const QString& msg,
                                               QMessageBox::StandardButtons buttonss = QMessageBox::Ok);
     Q_INVOKABLE void setEnabledThreadsafe(bool enabled);
+    Q_INVOKABLE bool askMsgboxQuestion(const QString& title, const QString& msg);
     ~Widget();
 
     virtual void closeEvent(QCloseEvent *event);