mhchia
16a4fd33c1
PR feedbacks
...
- Move exceptions to exceptions.py
- Raise `UpgradeFailure` in upgrader
- Refine the try/catch for upgraders in swarm
2019-08-22 22:53:49 +08:00
mhchia
3e04480d62
Raise HandshakeFailure in transport
...
Change the exception handling flow.
Raise `SecurityUpgradeFailure` in security_multistream.
2019-08-22 22:53:48 +08:00
mhchia
80452d9589
Fix make_exchange_message to use the new API
2019-08-22 22:53:48 +08:00
mhchia
921bfb65cc
Verify the remote pubkey and peer_id
...
- Add `from_bytes` in RSAPublicKey and Secp256k1PublicKey
- Add `pubkey_from_protobuf` to parse pubkey from protobuf
- Verify key and peer_id in `InsecureSession.run_handshake`
2019-08-22 22:53:48 +08:00
mhchia
ef476e555b
Use RawConnection.read
...
Instead of accessing its reader and writer directly.
TODO: considering add `ReaderWriterCloser` interface and let connection
and stream inherit from it.
2019-08-22 22:53:48 +08:00
mhchia
0b466ddc86
Add lock to RawConnection
...
To avoid `self.writer.drain()` is called in parallel.
Reference: https://bugs.python.org/issue29930
2019-08-22 22:53:47 +08:00
mhchia
5768daa9bf
PR feedbacks
...
- Nits
- Add `SecurityUpgradeFailure` and handle `UpgradeFailure` in Swarm.
2019-08-22 22:53:47 +08:00
Kevin Mai-Husan Chia
2a1367b011
Apply suggestions from code review
...
Co-Authored-By: NIC Lin <twedusuck@gmail.com>
2019-08-22 22:53:47 +08:00
mhchia
de8d356955
Fix tests failure due to lack of peer id
...
Fix it through doing plaintext handshake.
2019-08-22 22:53:47 +08:00
mhchia
bb7d37fd4f
Fix msg encoding
...
- Change varint-prefix encode to fixedint-prefix(4 bytes) encode.
2019-08-22 22:53:46 +08:00
mhchia
22b1a5395d
A working plaintext 2.0 without validation
2019-08-22 22:53:46 +08:00
mhchia
a0923d202a
Move varint and delim read/write to toplevel
...
To `libp2p.utils`.
2019-08-22 22:53:46 +08:00
mhchia
5192944724
Update pb
2019-08-22 22:53:46 +08:00
mhchia
59b373b48a
Add plaintext.proto
...
Update Makefile to handle the import in `plaintext.proto`.
Import path is modified to be relative to the project root.
And we run `protoc` from where `Makefile` locates, i.e. the project
root.
Reference:
- plaintext.proto: 62b2c6c482/sec/insecure/pb/plaintext.proto
2019-08-22 22:53:46 +08:00
mhchia
7bc363f2fa
Remove initiator in Mplex
...
Besides, fix the wrong passed `multi_addr` to `mplex_stream`.
2019-08-22 22:53:45 +08:00
mhchia
2752e7a04b
Ignore mypy error here
2019-08-22 15:58:38 +08:00
mhchia
dbd4ed44dd
Fix the issue when importing from other package
2019-08-22 15:36:17 +08:00
mhchia
550c23f9f9
PR feedback
...
- Use the order in `MuxerMultistream` as the precedence in multiselect
2019-08-21 11:43:25 +08:00
mhchia
8596f7390f
PR feedback: set protocol_id to constants
2019-08-21 11:43:24 +08:00
mhchia
d7d8440b2c
PR feedback: nitpicks
2019-08-21 11:43:24 +08:00
mhchia
4358a4bc89
Negotiate multiselect version for Muxer
...
`MuxerMultistream` is introduced to negotiate `Multiselect` version
before negotiating Multiplexer's version. This is required by
multistream 1.x
2019-08-21 11:43:24 +08:00
Alex Stokes
e1d3f1601f
Satisfy mypy
2019-08-20 19:28:32 +02:00
Alex Stokes
87d943aa39
Internalize the protobuf serialization to the concept of a Key
...
Given its use across various components of `libp2p` (not just peer IDs),
it makes the abstraction cleaner to pull the serialization into the
key class and expose the canonical serialization to bytes.
2019-08-20 19:01:36 +02:00
mhchia
5d611801c7
Fix isort
2019-08-18 19:51:04 +08:00
mhchia
86d4ce1da8
Add delim_encode and delim_read
...
- Add `StreamCommunicator` and `RawConnectionCommunicator`, read/write
messages with delim codec, with `IMuxedStream` and `IRawConnection`
respectively.
- Use it in `Multiselect` and `MultiselectClient`.
2019-08-18 19:51:04 +08:00
mhchia
8cd23abfe2
Remove the leftover merge related stuff
2019-08-16 11:03:16 +08:00
mhchia
e293b89925
Fix mypy
...
It seems the stub doesn't allow default value for params
2019-08-16 11:03:16 +08:00
mhchia
c5f32bf431
PR feedback for MplexStream.read
2019-08-16 11:03:16 +08:00
Kevin Mai-Husan Chia
8699568d43
Update libp2p/stream_muxer/mplex/mplex_stream.py
...
Co-Authored-By: Alex Stokes <r.alex.stokes@gmail.com>
2019-08-16 11:03:16 +08:00
mhchia
f2c31f6fe3
Fix isort
2019-08-16 11:03:16 +08:00
mhchia
b27cd0f24f
Use bytearray over bytes
...
To avoid copies.
2019-08-16 11:03:16 +08:00
mhchia
92320523d5
Add the missing exceptions.py
2019-08-16 11:03:16 +08:00
mhchia
e37b8bcf19
mypy: Add read_buffer_nonblocking in Mplex
2019-08-16 11:03:16 +08:00
mhchia
f281e3e1db
flake8
2019-08-16 11:03:16 +08:00
mhchia
9f8276fa84
Support read(n=-1)
...
Now, `n=-1` indicates that we want to read until EOF. However, now we
only read until we have no new message.
2019-08-16 11:03:16 +08:00
mhchia
9cb6ec1c48
Modify the behavior of MplexStream.read
2019-08-16 11:03:16 +08:00
mhchia
2485a00e24
Modify NetStream to read n bytes
2019-08-16 11:03:16 +08:00
Alex Stokes
7535a02da7
Clean up key gen
2019-08-15 19:24:30 -07:00
Alex Stokes
9a4e23a803
mypy protobuf plugin requires keyword-based initializers
2019-08-15 16:36:32 -07:00
Alex Stokes
82bae341a7
Run isort over files that were missing it
2019-08-15 16:33:35 -07:00
Alex Stokes
2e3ffb9d53
Use types for {Private,Public}Key and address other missing type hints
2019-08-15 16:33:34 -07:00
Alex Stokes
e7d2681fc0
Move base implementations into BaseSession
2019-08-15 16:33:34 -07:00
Alex Stokes
9e18d7561d
Supply local priv and pub key when upgrading to a secure transport
2019-08-15 16:33:34 -07:00
Alex Stokes
7942b7eaa7
Expose writer
2019-08-15 16:33:34 -07:00
Alex Stokes
20dd7d777a
More efficiently remove trailing newline from message
2019-08-15 16:33:34 -07:00
Alex Stokes
0ebc8ffb21
Wire some missing properties up
2019-08-15 16:33:34 -07:00
Alex Stokes
02e073d85a
Keep the host's private key for use in transports
2019-08-15 16:33:33 -07:00
Alex Stokes
879cbf1abd
Add an "insecure session" that satisfies the ISecureConn interface
2019-08-15 16:33:33 -07:00
Alex Stokes
1e5357a1e1
Update the ISecureConn interface following the reference and simplify accordingly
2019-08-15 16:33:33 -07:00
Alex Stokes
ab7653526f
Code cleanup / formatting
2019-08-15 16:33:33 -07:00
Alex Stokes
b98025c379
Move security transports into their respective sub-packages
2019-08-15 16:33:33 -07:00
Alex Stokes
d50e1b6872
Use direct types over indirect types
2019-08-15 16:33:32 -07:00
Alex Stokes
ff5eaf2429
Merge pull request #249 from ralexstokes/fix-mypy-protos
...
Add `mypy` protobufs plugin and regenerate protobufs
2019-08-15 16:15:26 -07:00
Alex Stokes
0f81ca42a6
Add mypy protobufs plugin and regenerate protobufs
2019-08-15 16:01:44 -07:00
mhchia
97308c897e
Add the missing __init__.py in pb/
...
Error: https://circleci.com/gh/mhchia/trinity/5342?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
2019-08-15 21:03:45 +08:00
Alex Stokes
125c5d8e2c
Adjust inheritance so that the MRO is clear for the chain of keys
2019-08-14 09:30:23 -07:00
Alex Stokes
3b19104284
Add missing ABC declaration following PR feedback in #240 .
2019-08-14 09:25:54 -07:00
Alex Stokes
08e6f2a30c
Update libp2p/crypto/secp256k1.py
...
pass the secret on to `coincurve` lib
Co-Authored-By: NIC Lin <twedusuck@gmail.com>
2019-08-14 09:02:06 -07:00
Alex Stokes
53e583a068
Update libp2p/crypto/secp256k1.py
...
Pass the secret on to `coincurve` lib
Co-Authored-By: NIC Lin <twedusuck@gmail.com>
2019-08-14 09:02:06 -07:00
Alex Stokes
ad20d8cb00
Make a KeyPair dataclass for passing around key pairs
2019-08-14 09:00:40 -07:00
Alex Stokes
6506079a36
Generate peer IDs according to the spec
2019-08-14 09:00:39 -07:00
Alex Stokes
f9e859a8e9
Clean up peer.ID
2019-08-14 09:00:39 -07:00
Alex Stokes
c40314a043
Use new RSA key type
2019-08-14 09:00:39 -07:00
Alex Stokes
61f78c8feb
Add abstraction for a cryptographic key
2019-08-14 09:00:39 -07:00
Alex Stokes
992585852f
Use explicit imports in top-level declaration
2019-08-13 17:43:21 -07:00
Alex Stokes
3debd2c808
Run black and isort w/ the new config
2019-08-13 14:36:42 -07:00
Chih Cheng Liang
28f6de37ee
Fix the rest of the typing hints ( #232 )
...
* ignore kad
* fix swarm, and minor
* fix init and swarm
* ignore pb
* enable mypy
* fix basic host
* fix tcp
* fix mplex
* add typing for pb
* skip format pyi
* [mypy] no need to ignore pb now
* add typing to chat
2019-08-11 16:47:54 +08:00
Chih Cheng Liang
dbb702548f
add NegotiableTransport type
2019-08-08 16:09:02 +08:00
Chih Cheng Liang
9851ee01fb
sort import
2019-08-08 16:09:02 +08:00
Chih Cheng Liang
c536aa3e07
flake8
2019-08-08 16:09:02 +08:00
Chih Cheng Liang
5903012e0e
add typing to protocol_muxer
2019-08-08 16:09:02 +08:00
NIC Lin
b26426214e
Update libp2p/pubsub/pubsub.py
...
Co-Authored-By: Kevin Mai-Husan Chia <mhchia@users.noreply.github.com>
2019-08-07 11:43:32 +08:00
NIC619
d4febea469
Message was not enforced to carry signature yet
2019-08-06 13:05:31 +08:00
NIC619
1cea1264a4
Raise exception when topic validation failed
2019-08-06 12:38:31 +08:00
NIC619
9a1e5fe813
Add ValidationError
2019-08-06 12:37:34 +08:00
NIC619
47643a67c6
Apply PR feedback
2019-08-06 12:32:18 +08:00
NIC619
b96ef0e6c7
Fix:
...
`_is_subscribed_to_msg` need only subscribe to one of the topics
2019-08-05 18:20:04 +08:00
NIC619
a2efd03dfa
Schedule push_msg into a task
2019-08-05 18:19:32 +08:00
NIC619
2bb7f42c20
Add validators to push_msg
2019-08-05 18:19:32 +08:00
NIC619
19ce5bb420
Add signature_validator stub and docstring
2019-08-05 18:19:32 +08:00
NIC619
e1b86904e3
Add validate_msg and test
2019-08-05 18:19:32 +08:00
NIC619
ec2c566e5a
Fix validator return type and add docstring
2019-08-05 18:19:32 +08:00
NIC619
f8ca4fa1ef
Add get_msg_validators and test
2019-08-05 18:19:32 +08:00
NIC619
cf69f7e800
Rename to set_topic_validator and add test
2019-08-05 18:19:31 +08:00
NIC619
b1f4813195
Add add/remove topic validator functions
2019-08-05 18:19:31 +08:00
NIC619
3973f1d13c
Add pubsub.topic_validators
2019-08-05 18:19:31 +08:00
Chih Cheng Liang
cb3a59e0ac
ttl as int
2019-08-05 17:02:18 +08:00
Chih Cheng Liang
63c733c3f5
PR feedback
2019-08-05 16:58:34 +08:00
Chih Cheng Liang
ccfb6eb35f
remove constructor of TCP
2019-08-05 16:56:56 +08:00
Chih Cheng Liang
e763f57930
run isort
2019-08-05 11:47:23 +08:00
Chih Cheng Liang
7a04ebb51f
run black
2019-08-05 11:21:20 +08:00
Chih Cheng Liang
9e0a806218
move stream and connection interfaces to abc
2019-08-05 11:17:38 +08:00
Chih Cheng Liang
c804f5ad19
minor
2019-08-05 10:47:59 +08:00
Chih Cheng Liang
29091266fc
add still needed TYPE_CHECK
2019-08-05 10:46:49 +08:00
Chih Cheng Liang
87ef2e4618
remove if TYPE_CHECKING as much as possible
2019-08-05 10:46:49 +08:00
Chih Cheng Liang
4c9a930f84
stream_muxer done
2019-08-05 10:45:47 +08:00
Chih Cheng Liang
dadac423f2
typed muxed_connection_interface.py
2019-08-05 10:45:47 +08:00
Chih Cheng Liang
b64ed9fd6f
typed mplex.utils
2019-08-05 10:45:46 +08:00
Chih Cheng Liang
239a5c88fb
add typing to mplex
2019-08-05 10:45:46 +08:00
Chih Cheng Liang
36b7e8ded9
Refactor HeaderTags
2019-08-05 10:45:46 +08:00
Chih Cheng Liang
29fbb9e40a
add typing to transport
2019-08-05 10:42:43 +08:00
Alex Stokes
7477b29508
run black w/ extended line length
2019-08-04 12:37:41 +08:00
Alex Stokes
cb301fcc51
Opt-out of linting on the special cases we have, given new ignore rules
2019-08-04 12:37:27 +08:00
Alex Stokes
69ec86c871
Remove grpc dependency
2019-08-03 11:17:28 -07:00
mhchia
0a5b4a88ca
Fix flake8 for the existing code
2019-08-04 00:18:30 +08:00
Alex Stokes
c8005c8113
Run isort in repo
2019-08-03 17:50:14 +08:00
Alex Stokes
bd8d45fbc1
Refactor ID to not use third-party type for cryptographic keys
...
Remove `ID.from_privkey` which would require specific knowledge per cryptosystem
2019-08-02 21:51:16 -07:00
Alex Stokes
28e1a03dc4
remove empty yamux impl
2019-08-02 15:03:59 -07:00
Alex Stokes
e55d9f2e60
restore generated protobuf files
2019-08-02 12:09:27 -07:00
Alex Stokes
88a3a3159e
Add clarifying comment about InsecureTransport
2019-08-02 12:07:35 -07:00
Alex Stokes
7b7c8ad30d
run black over dangling files
2019-08-02 11:47:08 -07:00
mhchia
2e94fcf56c
Remove pylint:disable
2019-08-02 23:26:06 +08:00
NIC Lin
7a0fa7dd37
Merge pull request #196 from NIC619/fix_peer_id
...
Refactor `peer.ID` class and only takes in `bytes` type argument
2019-08-02 18:03:56 +08:00
NIC619
ee290b2ac2
Fix missing asterisk
2019-08-02 16:48:32 +08:00
NIC619
3a4b592a5a
Fix missing asterisk
2019-08-02 15:06:39 +08:00
NIC619
0173b5e0d9
Add ID.to_base58() and comparison against str type
2019-08-02 14:46:01 +08:00
NIC619
924e965537
Change argument name of Network.listen and blakc format
2019-08-02 14:45:59 +08:00
NIC619
cd684aad9e
Update peer_id to type peer.ID in pubsub folder
2019-08-02 14:45:23 +08:00
NIC619
9562cb2a46
Rename:
...
`KadPeerInfo.peer_id` to `KadPeerInfo.peer_id_bytes`
2019-08-02 14:43:01 +08:00
NIC619
f00e80bc25
Fix wrong peer id type used in KadPeerInfo
2019-08-02 14:42:10 +08:00
NIC619
b928bdb356
Convert from base58/pubkey/privkey to class method
2019-08-02 14:42:10 +08:00
NIC619
80481252ca
Refactor ID to take in type bytes only
2019-08-02 14:42:10 +08:00
Chih Cheng Liang
10a8347c6a
PR feedback
2019-08-02 14:12:59 +08:00
Chih Cheng Liang
e731f77f2d
minor
2019-08-01 19:13:43 +08:00
Chih Cheng Liang
a86f010c95
add typing to security
2019-08-01 19:12:11 +08:00
Alex Stokes
0ae9840928
Run black over repo
2019-07-31 15:00:12 -07:00
mhchia
9683d5e8ac
Add tests for Pubsub
...
- `test_handle_subscription`
- `test_handle_talk`
- `test_message_all_peers`
2019-07-31 14:15:11 +08:00
mhchia
3a42d72cd9
Fix a minor bug for pb optional field
...
In `Pubsub.continuously_read_stream`, it checks whether this is a
control message enclosed in RPC message with `if rpc_incoming.control:`.
However, in pb2, the condition is always true because a default value is
returned when a field is not set. Solved it by changing it to
`if rpc_incoming.HasField("control"):`.
2019-07-31 14:15:11 +08:00
mhchia
550289a439
Combine test_subscription.py to test_pubsub.py
...
And add a bunch of tests for pubsub
2019-07-31 14:15:10 +08:00
mhchia
96563c0d84
Add fixtures for pubsub and router
...
And a starting `test_pubsub.py`
2019-07-31 14:14:13 +08:00
NIC619
5e215901c0
Apply PR feedback
2019-07-30 23:41:28 +08:00
NIC619
437b7665c4
Fix:
...
type object not subscriptable
2019-07-30 18:00:30 +08:00
NIC619
c4105688d1
Fix after rebase
2019-07-30 17:31:08 +08:00
NIC619
e53727d301
Apply PR feedback: fix type hints
2019-07-30 16:28:25 +08:00
NIC619
2d4e23cfe2
Fix cyclic import and lint
2019-07-30 16:28:05 +08:00
NIC619
a4a0d79f6d
Improve import layout
2019-07-30 16:27:29 +08:00
NIC619
e7ac09cb94
Fix:
...
Add Gossipsub attribute `peers_protocol` and do cleanup when peer removed
2019-07-30 16:26:21 +08:00
NIC619
d716e90e17
Fix on type hints
2019-07-30 16:25:33 +08:00
NIC619
edd164c878
Add type hints to network folder
2019-07-30 16:25:17 +08:00
NIC619
e1592997a8
Add type hints to routing folder
2019-07-30 16:24:52 +08:00
NIC619
f2de986c74
Add type hints to peer folder
2019-07-30 16:24:51 +08:00
NIC619
b695b0e1ec
Add type hint to host folder
2019-07-30 16:24:34 +08:00
NIC619
b2f496d081
Fix type hints except pb msg in pubsub folder
2019-07-30 16:24:34 +08:00
NIC619
a0aa105867
Add type hint to pubsub notifee/interface
2019-07-30 16:23:15 +08:00
NIC619
3549f2ff8b
Add type hints to mcache.py
2019-07-30 16:20:48 +08:00
NIC619
63014eeaae
Add type hints to floodsub.py
2019-07-30 16:20:47 +08:00
NIC619
b920955db6
Add type hints to gossipsub.py
2019-07-30 15:39:50 +08:00
NIC619
8eb6a230ff
Fix and add type hints to pubsub.py
2019-07-30 15:32:58 +08:00
mhchia
f02d38c0ee
Reflect PR feedback
...
* Rename `src` to `msg_forwarder` in pubsub/floodsub/gossipsub
* Rename Variables
* Sort imports
* Clean up
2019-07-29 12:09:35 +08:00
mhchia
74d831d4e2
Reflect PR feedback
2019-07-28 18:06:38 +08:00
