StarMirror/py-libp2p
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add TODO for Swarm.connections

Browse Source
This commit is contained in:
mhchia 2019-08-29 22:00:07 +08:00
parent c61a06706a
commit b2c5371323
No known key found for this signature in database
GPG Key ID: 389EFBEA1362589A
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libp2p/network/swarm.py
View File

@ -32,6 +32,8 @@ class Swarm(INetwork):
upgrader: TransportUpgrader upgrader: TransportUpgrader
transport: ITransport transport: ITransport
router: IPeerRouting router: IPeerRouting
# TODO: Connections an `peer_id` are 1-1 mapping in our implementation,
# whereas in Go one `peer_id` may point to multiple connections.
connections: Dict[ID, IMuxedConn] connections: Dict[ID, IMuxedConn]
listeners: Dict[str, IListener] listeners: Dict[str, IListener]
stream_handlers: Dict[INetStream, Callable[[INetStream], None]] stream_handlers: Dict[INetStream, Callable[[INetStream], None]]
@ -225,10 +227,8 @@ class Swarm(INetwork):
raise SwarmException( raise SwarmException(
f"fail to upgrade the connection to a muxed connection from {peer_id}" f"fail to upgrade the connection to a muxed connection from {peer_id}"
) from error ) from error
# Store muxed_conn with peer id # Store muxed_conn with peer id
self.connections[peer_id] = muxed_conn self.connections[peer_id] = muxed_conn
# Call notifiers since event occurred # Call notifiers since event occurred
for notifee in self.notifees: for notifee in self.notifees:
await notifee.connected(self, muxed_conn) await notifee.connected(self, muxed_conn)