Apply PR feedback and fix

This commit is contained in:
NIC619 2019-11-26 14:04:28 +08:00
parent fab27b0357
commit 94c7a0bca4
No known key found for this signature in database
GPG Key ID: 570C35F5C2D51B17
3 changed files with 11 additions and 7 deletions

View File

@ -16,6 +16,8 @@ class PeerData(IPeerData):
addrs: List[Multiaddr] addrs: List[Multiaddr]
def __init__(self) -> None: def __init__(self) -> None:
self.pubkey = None
self.privkey = None
self.metadata = {} self.metadata = {}
self.protocols = [] self.protocols = []
self.addrs = [] self.addrs = []

View File

@ -328,18 +328,19 @@ async def test_host_connect():
transport_opt_list = [["/ip4/127.0.0.1/tcp/0"], ["/ip4/127.0.0.1/tcp/0"]] transport_opt_list = [["/ip4/127.0.0.1/tcp/0"], ["/ip4/127.0.0.1/tcp/0"]]
(node_a, node_b) = await set_up_nodes_by_transport_opt(transport_opt_list) (node_a, node_b) = await set_up_nodes_by_transport_opt(transport_opt_list)
assert not node_a.get_peerstore().peer_ids() # Only our peer ID is stored in peer store
assert len(node_a.get_peerstore().peer_ids()) == 1
addr = node_b.get_addrs()[0] addr = node_b.get_addrs()[0]
info = info_from_p2p_addr(addr) info = info_from_p2p_addr(addr)
await node_a.connect(info) await node_a.connect(info)
assert len(node_a.get_peerstore().peer_ids()) == 1 assert len(node_a.get_peerstore().peer_ids()) == 2
await node_a.connect(info) await node_a.connect(info)
# make sure we don't do double connection # make sure we don't do double connection
assert len(node_a.get_peerstore().peer_ids()) == 1 assert len(node_a.get_peerstore().peer_ids()) == 2
assert node_b.get_id() in node_a.get_peerstore().peer_ids() assert node_b.get_id() in node_a.get_peerstore().peer_ids()
ma_node_b = multiaddr.Multiaddr("/p2p/%s" % node_b.get_id().pretty()) ma_node_b = multiaddr.Multiaddr("/p2p/%s" % node_b.get_id().pretty())

View File

@ -1,13 +1,14 @@
from libp2p.peer.peerstore import PeerStore import pytest
from libp2p.peer.peerstore import PeerStore, PeerStoreError
# Testing methods from IPeerStore base class. # Testing methods from IPeerStore base class.
def test_peer_info_empty(): def test_peer_info_empty():
store = PeerStore() store = PeerStore()
info = store.peer_info("peer") with pytest.raises(PeerStoreError):
store.peer_info("peer")
assert not info
def test_peer_info_basic(): def test_peer_info_basic():