Remove pylint:disable

This commit is contained in:
mhchia 2019-08-02 23:19:36 +08:00
parent 06a9511ab4
commit 2e94fcf56c
No known key found for this signature in database
GPG Key ID: 389EFBEA1362589A
36 changed files with 7 additions and 64 deletions

View File

@ -70,7 +70,6 @@ def initialize_default_swarm(
:param disc_opt: optional discovery :param disc_opt: optional discovery
:return: return a default swarm instance :return: return a default swarm instance
""" """
# pylint: disable=too-many-arguments, unused-argument
if not id_opt: if not id_opt:
id_opt = generate_id() id_opt = generate_id()
@ -112,7 +111,6 @@ async def new_node(
:param disc_opt: optional discovery :param disc_opt: optional discovery
:return: return a host instance :return: return a host instance
""" """
# pylint: disable=too-many-arguments
if not id_opt: if not id_opt:
id_opt = generate_id() id_opt = generate_id()

View File

@ -5,17 +5,15 @@ from .kad_peerinfo import KadPeerHeap, create_kad_peerinfo
from .utils import gather_dict from .utils import gather_dict
log = logging.getLogger(__name__) # pylint: disable=invalid-name log = logging.getLogger(__name__)
# pylint: disable=too-few-public-methods
class SpiderCrawl: class SpiderCrawl:
""" """
Crawl the network and look for given 160-bit keys. Crawl the network and look for given 160-bit keys.
""" """
def __init__(self, protocol, node, peers, ksize, alpha): def __init__(self, protocol, node, peers, ksize, alpha):
# pylint: disable=too-many-arguments
""" """
Create a new C{SpiderCrawl}er. Create a new C{SpiderCrawl}er.
@ -72,7 +70,6 @@ class SpiderCrawl:
class ValueSpiderCrawl(SpiderCrawl): class ValueSpiderCrawl(SpiderCrawl):
def __init__(self, protocol, node, peers, ksize, alpha): def __init__(self, protocol, node, peers, ksize, alpha):
# pylint: disable=too-many-arguments
SpiderCrawl.__init__(self, protocol, node, peers, ksize, alpha) SpiderCrawl.__init__(self, protocol, node, peers, ksize, alpha)
# keep track of the single nearest node without value - per # keep track of the single nearest node without value - per
# section 2.3 so we can set the key there if found # section 2.3 so we can set the key there if found

View File

@ -21,7 +21,6 @@ class KadPeerInfo(PeerInfo):
self.addrs = peer_data.get_addrs() if peer_data else None self.addrs = peer_data.get_addrs() if peer_data else None
# pylint: disable=invalid-name
self.ip = self.addrs[0].value_for_protocol(P_IP) if peer_data else None self.ip = self.addrs[0].value_for_protocol(P_IP) if peer_data else None
self.port = int(self.addrs[0].value_for_protocol(P_UDP)) if peer_data else None self.port = int(self.addrs[0].value_for_protocol(P_UDP)) if peer_data else None
@ -143,7 +142,7 @@ def create_kad_peerinfo(node_id_bytes=None, sender_ip=None, sender_port=None):
) )
peer_data = None peer_data = None
if sender_ip and sender_port: if sender_ip and sender_port:
peer_data = PeerData() # pylint: disable=no-value-for-parameter peer_data = PeerData()
addr = [ addr = [
Multiaddr( Multiaddr(
"/" + P_IP + "/" + str(sender_ip) + "/" + P_UDP + "/" + str(sender_port) "/" + P_IP + "/" + str(sender_ip) + "/" + P_UDP + "/" + str(sender_port)

View File

@ -12,10 +12,9 @@ from .kad_peerinfo import create_kad_peerinfo
from .crawling import ValueSpiderCrawl from .crawling import ValueSpiderCrawl
from .crawling import NodeSpiderCrawl from .crawling import NodeSpiderCrawl
log = logging.getLogger(__name__) # pylint: disable=invalid-name log = logging.getLogger(__name__)
# pylint: disable=too-many-instance-attributes
class KademliaServer: class KademliaServer:
""" """
High level view of a node instance. This is the object that should be High level view of a node instance. This is the object that should be
@ -260,4 +259,4 @@ def check_dht_value_type(value):
placing in the dht. placing in the dht.
""" """
typeset = [int, float, bool, str, bytes] typeset = [int, float, bool, str, bytes]
return type(value) in typeset # pylint: disable=unidiomatic-typecheck return type(value) in typeset

View File

@ -7,7 +7,7 @@ from .kad_peerinfo import create_kad_peerinfo
from .routing import RoutingTable from .routing import RoutingTable
log = logging.getLogger(__name__) # pylint: disable=invalid-name log = logging.getLogger(__name__)
class KademliaProtocol(RPCProtocol): class KademliaProtocol(RPCProtocol):
@ -37,7 +37,7 @@ class KademliaProtocol(RPCProtocol):
ids.append(rid) ids.append(rid)
return ids return ids
def rpc_stun(self, sender): # pylint: disable=no-self-use def rpc_stun(self, sender):
return sender return sender
def rpc_ping(self, sender, nodeid): def rpc_ping(self, sender, nodeid):
@ -75,7 +75,6 @@ class KademliaProtocol(RPCProtocol):
return {"value": value} return {"value": value}
def rpc_add_provider(self, sender, nodeid, key, provider_id): def rpc_add_provider(self, sender, nodeid, key, provider_id):
# pylint: disable=unused-argument
""" """
rpc when receiving an add_provider call rpc when receiving an add_provider call
should validate received PeerInfo matches sender nodeid should validate received PeerInfo matches sender nodeid
@ -91,7 +90,6 @@ class KademliaProtocol(RPCProtocol):
return False return False
def rpc_get_providers(self, sender, key): def rpc_get_providers(self, sender, key):
# pylint: disable=unused-argument
""" """
rpc when receiving a get_providers call rpc when receiving a get_providers call
should look up key in data store and respond with records should look up key in data store and respond with records

View File

@ -20,7 +20,6 @@ class RawConnection(IRawConnection):
writer: asyncio.StreamWriter, writer: asyncio.StreamWriter,
initiator: bool, initiator: bool,
) -> None: ) -> None:
# pylint: disable=too-many-arguments
self.conn_ip = ip self.conn_ip = ip
self.conn_port = port self.conn_port = port
self.reader = reader self.reader = reader

View File

@ -1,6 +1,5 @@
from abc import ABC, abstractmethod from abc import ABC, abstractmethod
# pylint: disable=too-few-public-methods
class IRawConnection(ABC): class IRawConnection(ABC):

View File

@ -26,7 +26,6 @@ StreamHandlerFn = Callable[[INetStream], Awaitable[None]]
class Swarm(INetwork): class Swarm(INetwork):
# pylint: disable=too-many-instance-attributes,cell-var-from-loop,too-many-arguments
self_id: ID self_id: ID
peerstore: PeerStore peerstore: PeerStore
@ -249,7 +248,6 @@ class Swarm(INetwork):
# TODO: `tear_down` # TODO: `tear_down`
async def tear_down(self) -> None: async def tear_down(self) -> None:
# pylint: disable=line-too-long
# Reference: https://github.com/libp2p/go-libp2p-swarm/blob/8be680aef8dea0a4497283f2f98470c2aeae6b65/swarm.go#L118 # noqa: E501 # Reference: https://github.com/libp2p/go-libp2p-swarm/blob/8be680aef8dea0a4497283f2f98470c2aeae6b65/swarm.go#L118 # noqa: E501
pass pass

View File

@ -45,7 +45,6 @@ class ID:
__repr__ = __str__ = pretty = to_string = to_base58 __repr__ = __str__ = pretty = to_string = to_base58
def __eq__(self, other: object) -> bool: def __eq__(self, other: object) -> bool:
# pylint: disable=protected-access, no-else-return
if isinstance(other, str): if isinstance(other, str):
return self.to_base58() == other return self.to_base58() == other
elif isinstance(other, bytes): elif isinstance(other, bytes):

View File

@ -7,7 +7,6 @@ from .peerdata import PeerData
class PeerInfo: class PeerInfo:
# pylint: disable=too-few-public-methods
peer_id: ID peer_id: ID
addrs: List[multiaddr.Multiaddr] addrs: List[multiaddr.Multiaddr]

View File

@ -8,7 +8,6 @@ from .pubsub_router_interface import IPubsubRouter
class FloodSub(IPubsubRouter): class FloodSub(IPubsubRouter):
# pylint: disable=no-member
protocols: List[str] protocols: List[str]

View File

@ -12,9 +12,6 @@ from .pubsub_router_interface import IPubsubRouter
class GossipSub(IPubsubRouter): class GossipSub(IPubsubRouter):
# pylint: disable=no-member
# pylint: disable=too-many-instance-attributes
# pylint: disable=too-many-public-methods
protocols: List[str] protocols: List[str]
pubsub: Pubsub pubsub: Pubsub
@ -50,7 +47,6 @@ class GossipSub(IPubsubRouter):
gossip_history: int = 5, gossip_history: int = 5,
heartbeat_interval: int = 120, heartbeat_interval: int = 120,
) -> None: ) -> None:
# pylint: disable=too-many-arguments
self.protocols = list(protocols) self.protocols = list(protocols)
self.pubsub = None self.pubsub = None
@ -154,7 +150,6 @@ class GossipSub(IPubsubRouter):
await self.handle_prune(prune, sender_peer_id) await self.handle_prune(prune, sender_peer_id)
async def publish(self, msg_forwarder: ID, pubsub_msg: rpc_pb2.Message) -> None: async def publish(self, msg_forwarder: ID, pubsub_msg: rpc_pb2.Message) -> None:
# pylint: disable=too-many-locals
""" """
Invoked to forward a new message that has been validated. Invoked to forward a new message that has been validated.
""" """
@ -182,7 +177,6 @@ class GossipSub(IPubsubRouter):
:param origin: peer id of the peer the message originate from. :param origin: peer id of the peer the message originate from.
:return: a generator of the peer ids who we send data to. :return: a generator of the peer ids who we send data to.
""" """
# pylint: disable=len-as-condition
send_to: Set[ID] = set() send_to: Set[ID] = set()
for topic in topic_ids: for topic in topic_ids:
if topic not in self.pubsub.peer_topics: if topic not in self.pubsub.peer_topics:
@ -367,7 +361,6 @@ class GossipSub(IPubsubRouter):
self.fanout[topic].extend(selected_peers) self.fanout[topic].extend(selected_peers)
async def gossip_heartbeat(self) -> None: async def gossip_heartbeat(self) -> None:
# pylint: disable=too-many-nested-blocks
for topic in self.mesh: for topic in self.mesh:
msg_ids = self.mcache.window(topic) msg_ids = self.mcache.window(topic)
if msg_ids: if msg_ids:

View File

@ -4,7 +4,6 @@ from .pb import rpc_pb2
class CacheEntry: class CacheEntry:
# pylint: disable=too-few-public-methods
mid: Tuple[bytes, bytes] mid: Tuple[bytes, bytes]
topics: List[str] topics: List[str]

View File

@ -1,4 +1,3 @@
# pylint: disable=no-name-in-module
import asyncio import asyncio
import time import time
from typing import Any, Dict, List, Tuple, TYPE_CHECKING from typing import Any, Dict, List, Tuple, TYPE_CHECKING
@ -23,7 +22,6 @@ def get_msg_id(msg: rpc_pb2.Message) -> Tuple[bytes, bytes]:
class Pubsub: class Pubsub:
# pylint: disable=too-many-instance-attributes, no-member, unsubscriptable-object
host: IHost host: IHost
my_id: ID my_id: ID
@ -144,7 +142,6 @@ class Pubsub:
for message in rpc_incoming.subscriptions: for message in rpc_incoming.subscriptions:
self.handle_subscription(peer_id, message) self.handle_subscription(peer_id, message)
# pylint: disable=line-too-long
# NOTE: Check if `rpc_incoming.control` is set through `HasField`. # NOTE: Check if `rpc_incoming.control` is set through `HasField`.
# This is necessary because `control` is an optional field in pb2. # This is necessary because `control` is an optional field in pb2.
# Ref: https://developers.google.com/protocol-buffers/docs/reference/python-generated#singular-fields-proto2 # Ref: https://developers.google.com/protocol-buffers/docs/reference/python-generated#singular-fields-proto2
@ -201,7 +198,6 @@ class Pubsub:
hello: bytes = self.get_hello_packet() hello: bytes = self.get_hello_packet()
await stream.write(hello) await stream.write(hello)
# pylint: disable=line-too-long
# TODO: Investigate whether this should be replaced by `handlePeerEOF` # TODO: Investigate whether this should be replaced by `handlePeerEOF`
# Ref: https://github.com/libp2p/go-libp2p-pubsub/blob/49274b0e8aecdf6cad59d768e5702ff00aa48488/comm.go#L80 # noqa: E501 # Ref: https://github.com/libp2p/go-libp2p-pubsub/blob/49274b0e8aecdf6cad59d768e5702ff00aa48488/comm.go#L80 # noqa: E501
# Pass stream off to stream reader # Pass stream off to stream reader

View File

@ -14,7 +14,6 @@ if TYPE_CHECKING:
class PubsubNotifee(INotifee): class PubsubNotifee(INotifee):
# pylint: disable=too-many-instance-attributes, cell-var-from-loop, unsubscriptable-object
initiator_peers_queue: "asyncio.Queue[ID]" initiator_peers_queue: "asyncio.Queue[ID]"

View File

@ -4,7 +4,6 @@ from typing import Iterable
from libp2p.peer.id import ID from libp2p.peer.id import ID
from libp2p.peer.peerinfo import PeerInfo from libp2p.peer.peerinfo import PeerInfo
# pylint: disable=too-few-public-methods
class IContentRouting(ABC): class IContentRouting(ABC):

View File

@ -8,7 +8,6 @@ from libp2p.routing.interfaces import IPeerRouting
class KadmeliaPeerRouter(IPeerRouting): class KadmeliaPeerRouter(IPeerRouting):
# pylint: disable=too-few-public-methods
server: KademliaServer server: KademliaServer
@ -34,7 +33,7 @@ def decode_peerinfo(encoded: Union[bytes, str]) -> KadPeerInfo:
lines = ast.literal_eval(encoded) lines = ast.literal_eval(encoded)
except SyntaxError: except SyntaxError:
return None return None
ip = lines[1] # pylint: disable=invalid-name ip = lines[1]
port = lines[2] port = lines[2]
peer_id = lines[3] peer_id = lines[3]
peer_info = create_kad_peerinfo(peer_id, ip, port) peer_info = create_kad_peerinfo(peer_id, ip, port)

View File

@ -6,7 +6,6 @@ if TYPE_CHECKING:
from libp2p.network.connection.raw_connection_interface import IRawConnection from libp2p.network.connection.raw_connection_interface import IRawConnection
from .typing import TSecurityDetails from .typing import TSecurityDetails
# pylint: disable=W0105
""" """
Represents a secured connection object, which includes a connection and details about the security Represents a secured connection object, which includes a connection and details about the security

View File

@ -7,7 +7,6 @@ if TYPE_CHECKING:
from libp2p.network.connection.raw_connection_interface import IRawConnection from libp2p.network.connection.raw_connection_interface import IRawConnection
from libp2p.peer.id import ID from libp2p.peer.id import ID
# pylint: disable=W0105
""" """
Transport that is used to secure a connection. This transport is Transport that is used to secure a connection. This transport is

View File

@ -14,7 +14,6 @@ if TYPE_CHECKING:
TProtocol = NewType("TProtocol", str) TProtocol = NewType("TProtocol", str)
# pylint: disable=W0105
""" """
Represents a secured connection object, which includes a connection and details about the security Represents a secured connection object, which includes a connection and details about the security

View File

@ -6,7 +6,6 @@ from ..muxed_connection_interface import IMuxedConn
class Mplex(IMuxedConn): class Mplex(IMuxedConn):
# pylint: disable=too-many-instance-attributes
""" """
reference: https://github.com/libp2p/go-mplex/blob/master/multiplex.go reference: https://github.com/libp2p/go-mplex/blob/master/multiplex.go
""" """

View File

@ -6,7 +6,6 @@ from .utils import get_flag
class MplexStream(IMuxedStream): class MplexStream(IMuxedStream):
# pylint: disable=too-many-instance-attributes
""" """
reference: https://github.com/libp2p/go-mplex/blob/master/stream.go reference: https://github.com/libp2p/go-mplex/blob/master/stream.go
""" """

View File

@ -3,7 +3,6 @@ from libp2p.security.security_multistream import SecurityMultistream
class TransportUpgrader: class TransportUpgrader:
# pylint: disable=no-self-use
def __init__(self, secOpt, muxerOpt): def __init__(self, secOpt, muxerOpt):
# Store security option # Store security option

View File

@ -4,7 +4,6 @@ import setuptools
classifiers = [f"Programming Language :: Python :: {version}" for version in ["3.7"]] classifiers = [f"Programming Language :: Python :: {version}" for version in ["3.7"]]
# pylint: disable=invalid-name
extras_require = { extras_require = {
"test": [ "test": [
"codecov>=2.0.15,<3.0.0", "codecov>=2.0.15,<3.0.0",

View File

@ -5,7 +5,6 @@ from tests.utils import cleanup, set_up_nodes_by_transport_opt
from libp2p.peer.peerinfo import info_from_p2p_addr from libp2p.peer.peerinfo import info_from_p2p_addr
# pylint: disable=too-many-locals
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_simple_messages(): async def test_simple_messages():
transport_opt_list = [["/ip4/127.0.0.1/tcp/0"], ["/ip4/127.0.0.1/tcp/0"]] transport_opt_list = [["/ip4/127.0.0.1/tcp/0"], ["/ip4/127.0.0.1/tcp/0"]]

View File

@ -22,11 +22,9 @@ from libp2p import new_node, initialize_default_swarm
from libp2p.network.notifee_interface import INotifee from libp2p.network.notifee_interface import INotifee
from libp2p.host.basic_host import BasicHost from libp2p.host.basic_host import BasicHost
# pylint: disable=too-many-locals
class MyNotifee(INotifee): class MyNotifee(INotifee):
# pylint: disable=too-many-instance-attributes, cell-var-from-loop
def __init__(self, events, val_to_append_to_event): def __init__(self, events, val_to_append_to_event):
self.events = events self.events = events
@ -52,7 +50,6 @@ class MyNotifee(INotifee):
class InvalidNotifee: class InvalidNotifee:
# pylint: disable=too-many-instance-attributes, cell-var-from-loop
def __init__(self): def __init__(self):
pass pass

View File

@ -14,13 +14,11 @@ def test_init():
for _ in range(10): for _ in range(10):
random_id_string += random.SystemRandom().choice(ALPHABETS) random_id_string += random.SystemRandom().choice(ALPHABETS)
peer_id = ID(random_id_string.encode()) peer_id = ID(random_id_string.encode())
# pylint: disable=protected-access
assert peer_id == random_id_string.encode() assert peer_id == random_id_string.encode()
def test_no_init_value(): def test_no_init_value():
with pytest.raises(Exception) as _: with pytest.raises(Exception) as _:
# pylint: disable=no-value-for-parameter
ID() ID()

View File

@ -28,7 +28,6 @@ def test_init_():
def test_init_no_value(): def test_init_no_value():
with pytest.raises(Exception) as _: with pytest.raises(Exception) as _:
# pylint: disable=no-value-for-parameter
PeerInfo() PeerInfo()
@ -50,7 +49,6 @@ def test_info_from_p2p_addr_invalid(addr):
def test_info_from_p2p_addr_valid(): def test_info_from_p2p_addr_valid():
# pylint: disable=line-too-long
m_addr = multiaddr.Multiaddr( m_addr = multiaddr.Multiaddr(
"/ip4/127.0.0.1/tcp/8000/p2p/3YgLAeMKSAPcGqZkAt8mREqhQXmJT8SN8VCMN4T6ih4GNX9wvK8mWJnWZ1qA2mLdCQ" "/ip4/127.0.0.1/tcp/8000/p2p/3YgLAeMKSAPcGqZkAt8mREqhQXmJT8SN8VCMN4T6ih4GNX9wvK8mWJnWZ1qA2mLdCQ"
) )

View File

@ -8,7 +8,6 @@ from .configs import GOSSIPSUB_PARAMS
from .factories import FloodsubFactory, GossipsubFactory, HostFactory, PubsubFactory from .factories import FloodsubFactory, GossipsubFactory, HostFactory, PubsubFactory
# pylint: disable=redefined-outer-name
@pytest.fixture @pytest.fixture

View File

@ -137,14 +137,12 @@ FLOODSUB_PROTOCOL_TEST_CASES = [
}, },
] ]
# pylint: disable=invalid-name
floodsub_protocol_pytest_params = [ floodsub_protocol_pytest_params = [
pytest.param(test_case, id=test_case["name"]) pytest.param(test_case, id=test_case["name"])
for test_case in FLOODSUB_PROTOCOL_TEST_CASES for test_case in FLOODSUB_PROTOCOL_TEST_CASES
] ]
# pylint: disable=too-many-locals
async def perform_test_from_obj(obj, router_factory): async def perform_test_from_obj(obj, router_factory):
""" """
Perform pubsub tests from a test obj. Perform pubsub tests from a test obj.

View File

@ -7,7 +7,6 @@ from tests.utils import cleanup, connect
from .dummy_account_node import DummyAccountNode from .dummy_account_node import DummyAccountNode
# pylint: disable=too-many-locals
def create_setup_in_new_thread_func(dummy_node): def create_setup_in_new_thread_func(dummy_node):

View File

@ -13,7 +13,6 @@ from .floodsub_integration_test_settings import (
) )
# pylint: disable=too-many-locals
@pytest.mark.parametrize("num_hosts", (2,)) @pytest.mark.parametrize("num_hosts", (2,))

View File

@ -10,7 +10,6 @@ from .floodsub_integration_test_settings import (
) )
# pylint: disable=too-many-locals
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_gossipsub_initialize_with_floodsub_protocol(): async def test_gossipsub_initialize_with_floodsub_protocol():
GossipsubFactory(protocols=[FLOODSUB_PROTOCOL_ID]) GossipsubFactory(protocols=[FLOODSUB_PROTOCOL_ID])

View File

@ -3,10 +3,8 @@ import pytest
from libp2p.pubsub.mcache import MessageCache from libp2p.pubsub.mcache import MessageCache
# pylint: disable=too-few-public-methods
class Msg: class Msg:
def __init__(self, topicIDs, seqno, from_id): def __init__(self, topicIDs, seqno, from_id):
# pylint: disable=invalid-name
self.topicIDs = topicIDs self.topicIDs = topicIDs
self.seqno = seqno self.seqno = seqno
self.from_id = from_id self.from_id = from_id

View File

@ -75,7 +75,6 @@ async def test_get_hello_packet(pubsubs_fsub):
packet.ParseFromString(pubsubs_fsub[0].get_hello_packet()) packet.ParseFromString(pubsubs_fsub[0].get_hello_packet())
return tuple(sub.topicid for sub in packet.subscriptions) return tuple(sub.topicid for sub in packet.subscriptions)
# pylint: disable=len-as-condition
# Test: No subscription, so there should not be any topic ids in the hello packet. # Test: No subscription, so there should not be any topic ids in the hello packet.
assert len(_get_hello_packet_topic_ids()) == 0 assert len(_get_hello_packet_topic_ids()) == 0
@ -295,7 +294,6 @@ async def test_publish(pubsubs_fsub, monkeypatch):
@pytest.mark.parametrize("num_hosts", (1,)) @pytest.mark.parametrize("num_hosts", (1,))
@pytest.mark.asyncio @pytest.mark.asyncio
async def test_push_msg(pubsubs_fsub, monkeypatch): async def test_push_msg(pubsubs_fsub, monkeypatch):
# pylint: disable=protected-access
msg_0 = make_pubsub_msg( msg_0 = make_pubsub_msg(
origin_id=pubsubs_fsub[0].my_id, origin_id=pubsubs_fsub[0].my_id,
topic_ids=[TESTING_TOPIC], topic_ids=[TESTING_TOPIC],

View File

@ -1,6 +1,5 @@
import pytest import pytest
# pylint: disable=eval-used
@pytest.mark.parametrize("test_input,expected", [("3+5", 8), ("2+4", 6), ("6*9", 54)]) @pytest.mark.parametrize("test_input,expected", [("3+5", 8), ("2+4", 6), ("6*9", 54)])