StarMirror/py-libp2p
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove TODOs

Browse Source
This commit is contained in:
mhchia 2020-02-18 22:55:48 +08:00
parent 48a7c1a969
commit 1d2a976597
No known key found for this signature in database
GPG Key ID: 389EFBEA1362589A
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libp2p/security/noise/transport.py
View File

@ -16,6 +16,10 @@ class Transport(ISecureTransport):
local_peer: ID local_peer: ID
early_data: bytes early_data: bytes
with_noise_pipes: bool with_noise_pipes: bool
# NOTE: Implementations that support Noise Pipes must decide whether to use
# an XX or IK handshake based on whether they possess a cached static
# Noise key for the remote peer.
# TODO: A storage of seen noise static keys for pattern IK? # TODO: A storage of seen noise static keys for pattern IK?
def __init__( def __init__(
@ -46,15 +50,9 @@ class Transport(ISecureTransport):
) )
async def secure_inbound(self, conn: IRawConnection) -> ISecureConn: async def secure_inbound(self, conn: IRawConnection) -> ISecureConn:
# TODO: SecureInbound attempts to complete a noise-libp2p handshake initiated
# by a remote peer over the given InsecureConnection.
pattern = self.get_pattern() pattern = self.get_pattern()
return await pattern.handshake_inbound(conn) return await pattern.handshake_inbound(conn)
async def secure_outbound(self, conn: IRawConnection, peer_id: ID) -> ISecureConn: async def secure_outbound(self, conn: IRawConnection, peer_id: ID) -> ISecureConn:
# TODO: Validate libp2p pubkey with `peer_id`. Abort if not correct.
# NOTE: Implementations that support Noise Pipes must decide whether to use
# an XX or IK handshake based on whether they possess a cached static
# Noise key for the remote peer.
pattern = self.get_pattern() pattern = self.get_pattern()
return await pattern.handshake_outbound(conn, peer_id) return await pattern.handshake_outbound(conn, peer_id)