From 6e2955d60c308000d53305b55de7767ff3932d89 Mon Sep 17 00:00:00 2001 From: John Crepezzi Date: Mon, 28 Nov 2011 01:15:52 -0500 Subject: [PATCH] Warn on no setExpire in file store --- TODO.md | 1 + lib/file_document_store.js | 12 ++++++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/TODO.md b/TODO.md index 31d642c..d93c6bc 100644 --- a/TODO.md +++ b/TODO.md @@ -3,3 +3,4 @@ * fix that chrome bug where it loads the doc twice * Add file extensions ourselves to push state * add feedback for errors to UI - esp. too long +* make sure file store still functions appropriately diff --git a/lib/file_document_store.js b/lib/file_document_store.js index da24e67..76492f8 100644 --- a/lib/file_document_store.js +++ b/lib/file_document_store.js @@ -9,10 +9,11 @@ var hashlib = require('hashlib'); var FileDocumentStore = function(options) { this.basePath = options.path || './data'; + this.expire = options.expire; }; // Save data in a file, key as md5 - since we don't know what we could be passed here -FileDocumentStore.prototype.set = function(key, data, callback, setExpire) { +FileDocumentStore.prototype.set = function(key, data, callback, skipExpire) { try { var _this = this; fs.mkdir(this.basePath, '700', function() { @@ -22,6 +23,9 @@ FileDocumentStore.prototype.set = function(key, data, callback, setExpire) { } else { callback(true); + if (_this.expire && !skipExpire) { + winston.warn('file store cannot set expirations on keys'); + } } }); }); @@ -31,13 +35,17 @@ FileDocumentStore.prototype.set = function(key, data, callback, setExpire) { }; // Get data from a file from key -FileDocumentStore.prototype.get = function(key, callback, setExpire) { +FileDocumentStore.prototype.get = function(key, callback, skipExpire) { + var _this = this; fs.readFile(this.basePath + '/' + hashlib.md5(key), 'utf8', function(err, data) { if (err) { callback(false); } else { callback(data); + if (_this.expire && !skipExpire) { + winston.warn('file store cannot set expirations on keys'); + } } }); };