From 8c0d4cca9461dcee0d3220518532d81e5ae5ff0a Mon Sep 17 00:00:00 2001 From: Nick Galbreath Date: Thu, 24 May 2018 11:29:34 -0700 Subject: [PATCH] Fix for issue russross/blackfriday#239 (#372) Issue russross/blackfriday#239 codeblock inside list. --- block.go | 22 ++++++++++++++++++++++ block_test.go | 38 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) diff --git a/block.go b/block.go index 83c71c5..859c6ef 100644 --- a/block.go +++ b/block.go @@ -1258,6 +1258,7 @@ func (p *Markdown) listItem(data []byte, flags *ListType) int { // process the following lines containsBlankLine := false sublist := 0 + codeBlockMarker := "" gatherlines: for line < len(data) { @@ -1291,6 +1292,27 @@ gatherlines: chunk := data[line+indentIndex : i] + if p.extensions&FencedCode != 0 { + // determine if in or out of codeblock + // if in codeblock, ignore normal list processing + _, marker := isFenceLine(chunk, nil, codeBlockMarker) + if marker != "" { + if codeBlockMarker == "" { + // start of codeblock + codeBlockMarker = marker + } else { + // end of codeblock. + codeBlockMarker = "" + } + } + // we are in a codeblock, write line, and continue + if codeBlockMarker != "" || marker != "" { + raw.Write(data[line+indentIndex : i]) + line = i + continue gatherlines + } + } + // evaluate how this line fits in switch { // is this a nested list item? diff --git a/block_test.go b/block_test.go index c196701..dc780e1 100644 --- a/block_test.go +++ b/block_test.go @@ -1475,6 +1475,44 @@ func TestFencedCodeBlock_EXTENSION_NO_EMPTY_LINE_BEFORE_BLOCK(t *testing.T) { doTestsBlock(t, tests, FencedCode|NoEmptyLineBeforeBlock) } +func TestListWithFencedCodeBlock(t *testing.T) { + var tests = []string{ + "1. one\n\n ```\n code\n ```\n\n2. two\n", + "
    \n
  1. one

    \n\n
    code\n
  2. \n\n
  3. two

  4. \n
\n", + // https://github.com/russross/blackfriday/issues/239 + "1. one\n\n ```\n - code\n ```\n\n2. two\n", + "
    \n
  1. one

    \n\n
    - code\n
  2. \n\n
  3. two

  4. \n
\n", + } + doTestsBlock(t, tests, FencedCode) +} + +func TestListWithMalformedFencedCodeBlock(t *testing.T) { + // Ensure that in the case of an unclosed fenced code block in a list, + // no source gets ommitted (even if it is malformed). + // See russross/blackfriday#372 for context. + var tests = []string{ + "1. one\n\n ```\n code\n\n2. two\n", + "
    \n
  1. one\n```\ncode\n2. two
  2. \n
\n", + + "1. one\n\n ```\n - code\n\n2. two\n", + "
    \n
  1. one\n```\n- code\n2. two
  2. \n
\n", + } + doTestsBlock(t, tests, FencedCode) +} + +func TestListWithFencedCodeBlockNoExtensions(t *testing.T) { + // If there is a fenced code block in a list, and FencedCode is not set, + // lists should be processed normally. + var tests = []string{ + "1. one\n\n ```\n code\n ```\n\n2. two\n", + "
    \n
  1. one

    \n\n

    \ncode\n

  2. \n\n
  3. two

  4. \n
\n", + + "1. one\n\n ```\n - code\n ```\n\n2. two\n", + "
    \n
  1. one

    \n\n

    ```

    \n\n
      \n
    • code\n```
    • \n
  2. \n\n
  3. two

  4. \n
\n", + } + doTestsBlock(t, tests, 0) +} + func TestTitleBlock_EXTENSION_TITLEBLOCK(t *testing.T) { var tests = []string{ "% Some title\n" +