StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity
1,549 Commits 14 Branches 4 Tags 216 MiB
ba25a26294
Commit Graph

1549 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jonathan Wakely
ba25a26294 Rephrase C.21 to talk about declaring not defining (#1152) 
* Rephrase C.21 to talk about declaring not defining

Add examples.

Fixes #870.

* Define special functions, clarify default constructor effects
 2018-03-26 11:15:03 -07:00
fekir
ab5f9c18bd catch by reference in all samples (#1154) 2018-03-26 11:13:49 -07:00
Stephan Weller
2c3d9921b6 Replace erroneous public keyword by private in C.129. (#1166) 2018-03-26 11:13:11 -07:00
beinhaerter
edf13aabc0 Note that C.46 does not apply for copy/move ctors (#1169) 
* Note that C.46 does not apply for copy/move ctors

* moved Note section before Enforcement section
 2018-03-26 11:12:03 -07:00
Gabriel Dos Reis
644e0f5b5e
Merge pull request #1164 from ChrisGuzak/ChrisGuzak-sizeof-not_max 
use sizeof(buffer) instead of MAX
 2018-03-22 16:15:32 -07:00
echeij
6ed138076d Fixed get_string example in F.21 (#1160) 
In the 'all values as return value' example in F.21, the passed istream was not used in the function.
 2018-03-14 10:14:07 -04:00
Chris Guzak
373f4c4808
use sizeof(buffer) instead of MAX 2018-03-13 15:28:26 -07:00
nnaka
09035eb1e4 Align comment block (#1162) 2018-03-11 13:35:09 +00:00
nnaka
9c4d4247b1 P.5 example read int array size mismatch (#1161) 
Expand comment to clarify problem.
 2018-03-11 08:13:55 +00:00
Andrew Pardoe
b487f9790a subject-verb agreement in NL.2 2018-03-09 14:23:39 -08:00
hsutter
8d5d5e4aeb To address #1147 
Changed `.length()` to `.size()` for `span` examples to track
standardization changes.
 2018-03-05 10:51:31 -08:00
Andrew Pardoe
beed3e97c0 update date 2018-02-26 14:31:04 -08:00
Ari Hietanen
6c55d4eaaf Bug fix C4 class Foobar (#1143) 
* Fixed bug in example code of C4 Expecptions. In C4, the class function void Foobar::foo(double x) is supposed to call the overloaded void Foobar::foo(int x), but in the call foo(std::round(x)), std::round returns a double. Hence, it will get stuck in an infinite recursive loop. Added static_cast<int>(..) to enforce the call to right overload. Added also keyword public to be more consistent.

* Changed static_cast<int> to narrow_cast<int> following ES.46.

* Modified C4 Foobar class, s.t, std::lround(x) is now called in
void foo(double) and the overload is changed to void foo(long) from (int). Now there is
no need for conversions.
 2018-02-26 11:11:51 -08:00
Tobias Mende
da3b6b98bc Do Not Check For nullptr Explicitely In Examples (closes #1142) (#1144) 2018-02-26 11:09:45 -08:00
beinhaerter
9c98f9679c Copy-Paste-Typo in Comment for ES.87 sample (==0/!=0) (#1145) 2018-02-26 11:07:05 -08:00
Sergey Zubkov
01e59d5452
added ofstream to dictionary for travis CI 2018-02-14 15:37:54 -05:00
hsutter
10c0a8b156 Closes #1119 
Make C.43 crisper -- the guideline is that default construction is
required for copyable types. A lot of the existing examples then just
fall out, without having to be presented as special cases. This was the
original intent and I think this new text helps make that clearer.
 2018-02-12 16:03:01 -08:00
Andrew Pardoe
d9f3149e11 Update references to C++17, also typo 2018-02-12 11:56:59 -08:00
Dipl.-Ing. Raoul Rubien, BSc
73dad7909d title page/In.sec: reordered and updated titles (#1135) 
* title page: updated titles and unified titles' camel case to sentence case

* In.sec: reordered bullets to match document's workflow, updated titles

* updated several links and link names, modified names to title case

* redirected broken link to new anchor Rf-value-return at 'value return sematic rules' block

* updated links

* reverted unindended broken artistic prose

* updated links, modified "see also's" formatting to comply with the majority

* modified "see also's" formatting to comply with the majority

* fix spellcheck: 'Componentization -> Compartmentalization'

* updated link name
 2018-02-12 11:12:58 -08:00
Bernardo Sulzbach
eb534411a7 Should say repository instead of depository (#1138) 2018-02-10 11:43:02 -08:00
Dipl.-Ing. Raoul Rubien, BSc
888067d6ff fixed spellcheck/lint issues on running make in ./scripts/ (#1134) 2018-01-24 08:12:05 -08:00
Sergey Zubkov
25d9d12e15 travis CI fixes 2018-01-24 09:19:47 -05:00
hsutter
f8f396ef3b Typo fix to NL.5 2018-01-23 12:03:41 -08:00
hsutter
c5f67599d1 Added another example to NL.5 2018-01-23 12:01:57 -08:00
hsutter
c10e5503e9 Closes #1104 2018-01-23 12:01:56 -08:00
Sergey Zubkov
e3f753ed14 the copy ctor typo and comment fixes from #1125 2018-01-23 14:19:11 -05:00
Andrew Pardoe
15ca9d220c Fixing typo per #1130 & updating date 2018-01-22 11:24:19 -08:00
Herb Sutter
c1e3cd01cd Add gsl::index, closes #1098 (#1115) 
* Add gsl::index, closes #1098

And update examples throughout to use `index` as appropriate

* Actually adding `index` to the GSL.util section

* Added `sizeof` to whitelisted signed/unsigned comparisons

Same reason as container `.size()` -- better backward compatibility with
the existing standard
 2018-01-22 11:16:11 -08:00
Oleg Artenii
b677b69014 Removed useless "Currently (July 2016)" (#1123) 
* Removed useless "Currently (July 2016)"

* replaced `GCC 6.1` with `GCC 6.1 or later`

* Correct usage of `and/or` in `GCC 6.1 _ later`
 2018-01-22 11:14:51 -08:00
rknuus
2bdd1ae705 add example for R.24 (#1127) 
* add example for R.24

taken from https://cpppatterns.com/patterns/weak-reference.html, where
it's published under CC0 Public Domain Dedication

* improve example for R.24
 2018-01-22 11:08:23 -08:00
Alexey Porotnikov
9de66ec027 add "return" to the compound literal exclusions (#1113) 
inhibits readability/brace warning for compound literals in return
statement
 2018-01-22 10:43:41 -08:00
Andrew Pardoe
999f9dd0ce Adding "ptrdiff" to travis dictionary 2018-01-22 10:39:01 -08:00
Jonathan Wakely
5c3006b60f Change "untended" to "unintended" in C.9 2018-01-09 22:27:14 +00:00
Herb Sutter
7aac5313d9 Correct example comment 2018-01-09 11:02:25 -05:00
Herb Sutter
e1cc6fedb0 In docs\gsl-intro, cleaned up stray notes into a "hints" section 2018-01-08 13:53:39 -05:00
Sergey Zubkov
59eb77027e travis CI fixes 2018-01-02 22:15:02 -05:00
Sergey Zubkov
7dc8aaa420 travis CI fixes 2018-01-02 22:14:16 -05:00
Bjarne Stroustrup
8f87a03588 ES.87 
#1032 comment and example added.
To consider: should integer comparison be broken out as its own rule?
 2018-01-01 17:37:38 -05:00
Bjarne Stroustrup
72b9b40a7c Some examples in Per.11 
In response to #936 I added some text to Per.11. More would be welcome
 2018-01-01 15:47:20 -05:00
Bjarne Stroustrup
edbfc3b8ec Clarifying (I hope) text and example added 
addressing #980 and #9777
 2018-01-01 14:26:00 -05:00
Bjarne Stroustrup
0df2c26e9a C.129 
#1052 added Jonathan's example
 2018-01-01 13:56:34 -05:00
Bjarne Stroustrup
ff42e7bbaf closing #547 
(now?) we have CP.3 and CP.31. Also CP.mess.
Yes we need more work on CP.mess
 2018-01-01 11:44:58 -05:00
Bjarne Stroustrup
ecabc369bb simplifying ES.20 
#488
 2018-01-01 11:13:38 -05:00
Bjarne Stroustrup
7e5019378b Fix #493 array myth 
Added comment about performance to SL.con.1
 2018-01-01 10:40:45 -05:00
Andrew Pardoe
7cfb1d7961 update date 2017-12-26 08:13:24 -08:00
Mitch Phillips
bd948ee839 Fix example code in F.20. (#1109) 2017-12-22 16:01:42 -05:00
michaelz85
044a4b277e fixed anchor name for T.21 (#1108) 2017-12-20 11:50:46 -05:00
michaelz85
7c11ac1acf fixed a word (should be 'that' not 'the') (#1107) 2017-12-20 11:46:50 -05:00
michaelz85
b5a20f10ea fixed error in code comment (#1105) 2017-12-18 11:39:04 -05:00
Oleg Artenii
352e94babe fixed minor typo: "on the on the" -> "on the" (#1103) 2017-12-13 12:52:13 -05:00