Commit Graph

835 Commits

Author SHA1 Message Date
Severin Meyer
6fb7ad6bb5 Fix a few more typos
F.22: Fix typos
C.128: Update the title in the ToC, to match the new title from commit f0e29f0
Con.1: Fix typo
T.84: Fix typo
NR.2: Remove duplicated word from title (single single)
2016-11-22 16:10:31 +01:00
Andrew Pardoe
9987d835b9 Updating date 2016-11-21 08:38:55 -08:00
Andrew Pardoe
7741b8689e Merge pull request #796 from severinmeyer/C-Typos
Fix typos in section C: Classes and class hierarchies
2016-11-21 08:33:22 -08:00
Severin Meyer
353f8ffc4c C.140: Fix typo in text 2016-11-17 14:56:45 +01:00
Severin Meyer
26953e0bf9 C.139: Fix typo in text 2016-11-17 14:55:54 +01:00
Severin Meyer
fc0999c56e C.129: Fix typo in text 2016-11-17 14:54:52 +01:00
Severin Meyer
434f995679 C.128: Fix typo in text 2016-11-17 14:53:58 +01:00
Severin Meyer
66c0348d19 C.80: Fix typo in text 2016-11-17 14:51:08 +01:00
Severin Meyer
7070ffa839 C.41: Add missing comma 2016-11-17 14:49:54 +01:00
Severin Meyer
efb284388f C.defop: Fix typo in introductory text 2016-11-17 14:48:43 +01:00
Severin Meyer
db8273d068 C.concrete: Fix typo in introductory text 2016-11-17 14:47:44 +01:00
Severin Meyer
0d02b7e8bf C.9: Capitalize first word of title 2016-11-17 14:45:50 +01:00
Severin Meyer
edb59eea86 C.8: Fix typo in text 2016-11-17 14:43:03 +01:00
Severin Meyer
b516c49efc C.8: Fix typo in title and capitalize first word 2016-11-17 14:41:18 +01:00
Severin Meyer
c6071b8add CP.41: Fix typo in code example 2016-11-17 13:28:15 +01:00
Gabriel Dos Reis
09d76d93fc Merge pull request #791 from severinmeyer/P.9-Typo
P.9: Fix typo in code example
2016-11-15 07:57:54 -08:00
Severin Meyer
c3ee965a28 P.9: Fix typo in code example 2016-11-15 16:00:56 +01:00
Stéphane Magnenat
17c7ba9b8b Fixed missing ` 2016-11-15 10:25:34 +01:00
Mustafa Serdar Sanli
53bc78fd49 Fix broken anchor link 2016-10-31 20:00:14 +00:00
Jan Nils Ferner
d86a82f1eb Fix typo (#782) 2016-10-20 10:48:31 +01:00
Jonathan Wakely
98f1e46602 C.146 Compare pb2->id() instead of pb2
Fixes #504
2016-10-17 19:15:04 +01:00
Doan Tran Cong Danh
db85ec865d ES.7 Fix typo, "i" -> "current_element_index" 2016-10-07 17:58:08 +07:00
Jonathan Wakely
aab97d9e48 C.32 Fix typo, "aide" -> "aid" 2016-10-05 13:00:48 +01:00
Gabriel Dos Reis
6767413118 Merge pull request #760 from derekxgl/patch-1
P.11 call vector reserve(100) instead of vector(100)
2016-10-04 07:25:52 -07:00
Malcolm Parsons
38772fc251 Correct spelling of nullptr 2016-10-04 15:12:56 +01:00
Derek Li
6c29e226d8 P.11 call vector reserve(100) instead of vector(100) 2016-10-04 12:55:52 +01:00
Gabriel Dos Reis
7b4a1903ec Merge pull request #745 from kks32/master
Fixes wrong order of type and function name in naming scheme - master branch
2016-10-03 16:41:53 -07:00
Gabriel Dos Reis
804964d653 Merge pull request #758 from Eliyahu-Ravuna/patch-22
Short string optimization example for C.180
2016-10-03 16:41:07 -07:00
Eliyahu Ravuna
52c4376433 Short string optimization example for C.180
Extra blank lines removed

strcpy replaced with strcpy_s to get rid of Travis CI warnings

Note: strcpy_s  is defined in the Annex K of the C++11 standard.

Gabriel's comments incorporated

- No need for braces for a single statement.
- Comment to explain why buffer_size is 16.

Bracing style made consistent with the rest of the examples

Bracing style made consistent with the rest of the examples

braces made consistent with the rest of the examples
2016-10-04 02:37:25 +03:00
Andrew Pardoe
f6dd6159f8 Fix issue #747 2016-10-03 15:40:56 -07:00
Andrew Pardoe
f66d9aea46 Fix 798177568e 2016-10-03 15:37:56 -07:00
Andrew Pardoe
798177568e Merge pull request #754 from Eliyahu-Ravuna/patch-21
CP.110 & CP.111: Double-checked locking
2016-10-03 11:17:25 -07:00
Andrew Pardoe
b149a50faf Merge pull request #756 from pepsiman/patch-1
P.5 Correct case of Int alias
2016-10-03 11:10:59 -07:00
Andrew Pardoe
4d45c6bb1d Merge pull request #755 from pepsiman/executionpolicy
P.3 Split execution policy and container
2016-10-03 11:09:51 -07:00
Eliyahu Ravuna
ec2f23781d CP.110 renamed as "Do not write your own double-checked locking"
CP.110 renamed as "Do not write your own double-checked locking".
Explanation and two examples added.

Added exception

Double-checked locking may be legitimately used in lock-free programming. However, see the rule [CP.100: Don't use lock-free programming unless you absolutely have to](#Rconc-lockfree).

Title made clearer and a conventional pattern has been added

* Title made clearer
* A correct example of double-checked locking has been added

Casing fixed

Casing fixed

Extra whitespace deleted

CP.110 and CP.111 separated

- CP.110: Do not write your own double-checked locking for initialization
- CP.111: Use a conventional pattern if you really need double-checked locking

Whitespace removed

Example simplified

Whitespace issue fixed.

punctuation fixed.
2016-10-03 10:21:04 +03:00
Malcolm Parsons
71df1537b3 P.5 Correct case of Int alias
Revert d9562f683d and part of 9590bb94b1
2016-10-02 19:58:34 +01:00
Malcolm Parsons
e66f5bb28e P.3 Split execution policy and container 2016-10-02 16:28:24 +01:00
Johel Ernesto Guerrero Peña
2a000ac21a In: Grammar and correction fixes
We use letters to identify the first part of a rule "number", not just one letter.
The rest are grammar fixes.
2016-10-01 19:18:50 -04:00
Oleksandr Senkovych
e0abec4259 Remove mode string from ifstream constructor in R.12 2016-09-28 11:23:18 +02:00
Krishna Kumar
7f872a9d50 Fixes wrong order of type and function name in naming scheme 2016-09-27 15:43:04 -07:00
Johel Ernesto Guerrero Peña
8aaf6e1b76 Correct glossary entry order 2016-09-27 13:42:22 -04:00
Johel Ernesto Guerrero Peña
138da22db4 Fix glossary definitions and grammar
A class isn't abstract for having a protected constructor, but for only having protected constructors.
2016-09-27 02:00:24 -04:00
Rian Quinn
8be1869663 Update C.128 to remove override from destructors
Clang Tidy has a a check called (modernize-use-override) that explicitly verifies that `override` be placed on destructors of derived classes whose base class is `virtual` as seen [here](https://github.com/Microsoft/clang-tools-extra/blob/master/test/clang-tidy/modernize-use-override.cpp#L48). This issue was brought up by @jaredgrubb in the following [ticket](https://github.com/isocpp/CppCoreGuidelines/issues/721#issuecomment-246627077) and was also seen [here](https://github.com/Bareflank/hypervisor/issues/208) as well. @gdr-at-ms closed the ticket stating that the C++ Core Guideline Editors have decided that `override` should not be placed on destructors, but the documentation makes no mention of this decision. The following PR addresses this issue. With the documentation updated, an issue ticket can be generated for Clang Tidy to have the destructor check modified to reflect the C++ Core Guidance.
2016-09-13 07:05:52 -06:00
Gabriel Dos Reis
3f33bd9c89 Merge pull request #730 from olafdietsche/spelling
Minor spelling fixes
2016-09-12 11:48:55 -07:00
Gabriel Dos Reis
729c515a2b Merge pull request #703 from amdn/master
T.44: Added `s` suffix to string literal
2016-09-12 11:13:04 -07:00
Andrew Pardoe
c4a19c99b2 Merge pull request #706 from tkruse/fix-examples2
Fix examples2
2016-09-12 11:11:16 -07:00
Andrew Pardoe
97503abeaa Merge pull request #700 from tkruse/fix-examples
fix code examples
2016-09-12 11:08:13 -07:00
Akim Demaille
2b80bc92a5 T.65: fix code examples 2016-09-12 18:41:54 +02:00
Olaf Dietsche
bb2e744c3f Minor spelling fixes 2016-09-11 17:19:52 +02:00
Thibault Kruse
1c0e2b7d11 fix invalid code 2016-09-10 22:56:15 +09:00