StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity
1,042 Commits 14 Branches 4 Tags 216 MiB
5f66e004d8
Commit Graph

813 Commits

Author SHA1 Message Date
Eliyahu Ravuna
5f66e004d8 Exception of CP.100 refined to include the "sequentially consistent memory model" only 
Atomic variables are safe with the sequentially consistent memory model (memory_order_seq_cst) only. Weakly ordered atomics cannot be considered safe for mainstream use. The exception clause of CP.100 refined to include the "sequentially consistent memory model" only.

cst added to dictionary

For std::memory_order_seq_cst, which is defined in <atomic>.
 2016-10-04 20:36:09 +03:00
Gabriel Dos Reis
6767413118 Merge pull request #760 from derekxgl/patch-1 
P.11 call vector reserve(100) instead of vector(100)
 2016-10-04 07:25:52 -07:00
Malcolm Parsons
38772fc251 Correct spelling of nullptr 2016-10-04 15:12:56 +01:00
Derek Li
6c29e226d8 P.11 call vector reserve(100) instead of vector(100) 2016-10-04 12:55:52 +01:00
Gabriel Dos Reis
7b4a1903ec Merge pull request #745 from kks32/master 
Fixes wrong order of type and function name in naming scheme - master branch
 2016-10-03 16:41:53 -07:00
Gabriel Dos Reis
804964d653 Merge pull request #758 from Eliyahu-Ravuna/patch-22 
Short string optimization example for C.180
 2016-10-03 16:41:07 -07:00
Eliyahu Ravuna
52c4376433 Short string optimization example for C.180 
Extra blank lines removed

strcpy replaced with strcpy_s to get rid of Travis CI warnings

Note: strcpy_s  is defined in the Annex K of the C++11 standard.

Gabriel's comments incorporated

- No need for braces for a single statement.
- Comment to explain why buffer_size is 16.

Bracing style made consistent with the rest of the examples

Bracing style made consistent with the rest of the examples

braces made consistent with the rest of the examples
 2016-10-04 02:37:25 +03:00
Andrew Pardoe
f6dd6159f8 Fix issue #747 2016-10-03 15:40:56 -07:00
Andrew Pardoe
f66d9aea46 Fix 798177568e 2016-10-03 15:37:56 -07:00
Andrew Pardoe
798177568e Merge pull request #754 from Eliyahu-Ravuna/patch-21 
CP.110 & CP.111: Double-checked locking
 2016-10-03 11:17:25 -07:00
Andrew Pardoe
b149a50faf Merge pull request #756 from pepsiman/patch-1 
P.5 Correct case of Int alias
 2016-10-03 11:10:59 -07:00
Andrew Pardoe
4d45c6bb1d Merge pull request #755 from pepsiman/executionpolicy 
P.3 Split execution policy and container
 2016-10-03 11:09:51 -07:00
Eliyahu Ravuna
ec2f23781d CP.110 renamed as "Do not write your own double-checked locking" 
CP.110 renamed as "Do not write your own double-checked locking".
Explanation and two examples added.

Added exception

Double-checked locking may be legitimately used in lock-free programming. However, see the rule [CP.100: Don't use lock-free programming unless you absolutely have to](#Rconc-lockfree).

Title made clearer and a conventional pattern has been added

* Title made clearer
* A correct example of double-checked locking has been added

Casing fixed

Casing fixed

Extra whitespace deleted

CP.110 and CP.111 separated

- CP.110: Do not write your own double-checked locking for initialization
- CP.111: Use a conventional pattern if you really need double-checked locking

Whitespace removed

Example simplified

Whitespace issue fixed.

punctuation fixed.
 2016-10-03 10:21:04 +03:00
Malcolm Parsons
71df1537b3 P.5 Correct case of Int alias 
Revert d9562f683d and part of 9590bb94b1
 2016-10-02 19:58:34 +01:00
Malcolm Parsons
e66f5bb28e P.3 Split execution policy and container 2016-10-02 16:28:24 +01:00
Johel Ernesto Guerrero Peña
2a000ac21a In: Grammar and correction fixes 
We use letters to identify the first part of a rule "number", not just one letter.
The rest are grammar fixes.
 2016-10-01 19:18:50 -04:00
Oleksandr Senkovych
e0abec4259 Remove mode string from ifstream constructor in R.12 2016-09-28 11:23:18 +02:00
Krishna Kumar
7f872a9d50 Fixes wrong order of type and function name in naming scheme 2016-09-27 15:43:04 -07:00
Johel Ernesto Guerrero Peña
8aaf6e1b76 Correct glossary entry order 2016-09-27 13:42:22 -04:00
Johel Ernesto Guerrero Peña
138da22db4 Fix glossary definitions and grammar 
A class isn't abstract for having a protected constructor, but for only having protected constructors.
 2016-09-27 02:00:24 -04:00
Rian Quinn
8be1869663 Update C.128 to remove override from destructors 
Clang Tidy has a a check called (modernize-use-override) that explicitly verifies that `override` be placed on destructors of derived classes whose base class is `virtual` as seen [here](https://github.com/Microsoft/clang-tools-extra/blob/master/test/clang-tidy/modernize-use-override.cpp#L48). This issue was brought up by @jaredgrubb in the following [ticket](https://github.com/isocpp/CppCoreGuidelines/issues/721#issuecomment-246627077) and was also seen [here](https://github.com/Bareflank/hypervisor/issues/208) as well. @gdr-at-ms closed the ticket stating that the C++ Core Guideline Editors have decided that `override` should not be placed on destructors, but the documentation makes no mention of this decision. The following PR addresses this issue. With the documentation updated, an issue ticket can be generated for Clang Tidy to have the destructor check modified to reflect the C++ Core Guidance.
 2016-09-13 07:05:52 -06:00
Gabriel Dos Reis
3f33bd9c89 Merge pull request #730 from olafdietsche/spelling 
Minor spelling fixes
 2016-09-12 11:48:55 -07:00
Gabriel Dos Reis
729c515a2b Merge pull request #703 from amdn/master 
T.44: Added `s` suffix to string literal
 2016-09-12 11:13:04 -07:00
Andrew Pardoe
c4a19c99b2 Merge pull request #706 from tkruse/fix-examples2 
Fix examples2
 2016-09-12 11:11:16 -07:00
Andrew Pardoe
97503abeaa Merge pull request #700 from tkruse/fix-examples 
fix code examples
 2016-09-12 11:08:13 -07:00
Akim Demaille
2b80bc92a5 T.65: fix code examples 2016-09-12 18:41:54 +02:00
Olaf Dietsche
bb2e744c3f Minor spelling fixes 2016-09-11 17:19:52 +02:00
Thibault Kruse
1c0e2b7d11 fix invalid code 2016-09-10 22:56:15 +09:00
Thibault Kruse
25e3ec4652 improve code example, use() function makes little sense with void results of f() and g() 2016-09-10 22:56:15 +09:00
Thibault Kruse
7c991f0e7e fix varname 2016-09-10 22:56:15 +09:00
Thibault Kruse
a361c37f5e unique funIds 2016-09-10 22:56:15 +09:00
Thibault Kruse
9590bb94b1 fix code examples 2016-09-10 22:56:14 +09:00
Thibault Kruse
2db47928df fix unnecessary block 2016-09-10 22:56:11 +09:00
Thibault Kruse
6a39a88bf8 Fix initializer list example 2016-09-10 22:56:11 +09:00
Gabriel Dos Reis
3acba2ebae Merge pull request #726 from tkruse/fix-typos 
Fix typos
 2016-09-09 19:23:25 -07:00
Olaf Dietsche
bceec9e494 CP.3: Fix example: function declarations 2016-09-09 18:44:19 +02:00
Thibault Kruse
a11f1f7f53 fix typos 2016-09-07 18:17:59 +09:00
Felix Morgner
8078b0a1f8 Move whitespace to right place 2016-09-06 15:43:55 +02:00
Thibault Kruse
1e4b13bfb0 fix whitespace after comma 2016-09-06 18:32:23 +09:00
Thibault Kruse
9c148afad3 Fix transition of *Excption* to #### Exception in 4d7b1d 2016-09-06 18:31:47 +09:00
Thibault Kruse
254c123c14 fix internal link 2016-09-05 22:22:08 +09:00
Thibault Kruse
13419aa5dd fix code style 2016-09-05 22:17:03 +09:00
Thibault Kruse
603a1b4286 Fix whitespace inconsistencies, remove tabs 2016-09-05 22:08:04 +09:00
Thibault Kruse
27b585ad71 style issues 2016-09-05 22:08:04 +09:00
Bjarne Stroustrup
0aea7d997b Added Per.7 
Design to enable optimization
 2016-09-04 11:08:54 -04:00
Jeroen Habraken
bf0d7e415f Fixes the NL.26 link. 2016-08-31 16:32:34 -07:00
Neil MacIntosh
b5d5d3f547 Fix order of declarations inside example 
Fixes #668.
 2016-08-30 14:31:16 -07:00
Neil MacIntosh
d1f22ae88d Fix order of declarations inside example 
As per #668, fixing order of declarations in example to match NL.16.
 2016-08-30 14:22:40 -07:00
Bjarne Stroustrup
3ca23f1575 fix Enum.4 2016-08-29 15:50:47 -04:00
Bjarne Stroustrup
3ec8cfc5cc Issue 660 
Note added
 2016-08-28 14:49:47 -04:00