StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Fix remaining typos mentioned in issue #556

Browse Source 
ES.23: Correct the Fibonacci series
ES.71: Fix bug in example code
T.61: Use the correct type for the class member
Appendix C: Use an example string that is not identical to a C++ keyword and clarify comment
This commit is contained in:
Severin Meyer 2016-11-22 23:08:27 +01:00
parent 7fb5621495
commit bcd9904ae2
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
CppCoreGuidelines.md
View File

@ -9533,7 +9533,7 @@ Initialization of a variable declared using `auto` with a single value, e.g., `{
Use `={...}` if you really want an `initializer_list<T>` Use `={...}` if you really want an `initializer_list<T>`
auto fib10 = {0, 1, 2, 3, 5, 8, 13, 25, 38, 63}; // fib10 is a list auto fib10 = {0, 1, 2, 3, 5, 8, 13, 21, 34, 55}; // fib10 is a list
##### Note ##### Note
@ -9915,8 +9915,8 @@ Readability. Error prevention. Efficiency.
cout << f(v, &v[i]) << '\n'; cout << f(v, &v[i]) << '\n';
for (int i = 0; i < v.size(); ++i) { // body messes with loop variable: can't be a range-for for (int i = 0; i < v.size(); ++i) { // body messes with loop variable: can't be a range-for
if (i % 2) if (i % 2 == 0)
++i; // skip even elements continue; // skip even elements
else else
cout << v[i] << '\n'; cout << v[i] << '\n';
} }
@ -15113,7 +15113,7 @@ This limits use and typically increases code size.
// ... // ...
private: private:
Node* head; Link* head;
}; };
List<int> lst1; List<int> lst1;
@ -15140,7 +15140,7 @@ This looks innocent enough, but ???
// ... // ...
private: private:
Node* head; Link* head;
}; };
List<int> lst1; List<int> lst1;
@ -15452,12 +15452,12 @@ Note that `maul()` violates the a `T*` points to an individual object [Rule](#??
*p = Pear{}; // put a Pear into *p *p = Pear{}; // put a Pear into *p
} }
vector<Apple> va = { an_apple, another_apple }; // aa contains Apples (obviously!) vector<Apple> va = { an_apple, another_apple }; // va contains Apples (obviously!)
maul2(aa); // error: cannot convert a vector<Apple> to a Fruit* maul2(va); // error: cannot convert a vector<Apple> to a Fruit*
maul2(&aa[0]); // you asked for it maul2(&va[0]); // you asked for it
Apple& a0 = &aa[0]; // a Pear? Apple& a0 = &va[0]; // a Pear?
Note that the assignment in `maul2()` violated the no-slicing [Rule](#???). Note that the assignment in `maul2()` violated the no-slicing [Rule](#???).
@ -18873,7 +18873,7 @@ To avoid extremely hard-to-find errors. Dereferencing such a pointer is undefine
string* bad() // really bad string* bad() // really bad
{ {
vector<string> v = { "this", "will", "cause" "trouble" }; vector<string> v = { "This", "will", "cause", "trouble", "!" };
// leaking a pointer into a destroyed member of a destroyed object (v) // leaking a pointer into a destroyed member of a destroyed object (v)
return &v[0]; return &v[0];
} }
@ -18882,7 +18882,7 @@ To avoid extremely hard-to-find errors. Dereferencing such a pointer is undefine
{ {
string* p = bad(); string* p = bad();
vector<int> xx = {7, 8, 9}; vector<int> xx = {7, 8, 9};
// undefined behavior: x may not be "this" // undefined behavior: x may not be the string "This"
string x = *p; string x = *p;
// undefined behavior: we don't know what (if anything) is allocated a location p // undefined behavior: we don't know what (if anything) is allocated a location p
*p = "Evil!"; *p = "Evil!";