StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Fix calls to malloc() with 2 arguments (#1377)

Browse Source 
* Fix calls to malloc() with 2 arguments
This commit is contained in:
Amir Livneh 2019-03-09 19:17:33 -05:00 committed by Sergey Zubkov
parent f67e91d295
commit ba2dbc5edf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CppCoreGuidelines.md
View File

@ -15787,7 +15787,7 @@ Better:
void f(int n) void f(int n)
{ {
void* p = malloc(1, n); void* p = malloc(n);
auto _ = finally([p] { free(p); }); auto _ = finally([p] { free(p); });
// ... // ...
} }
@ -15891,7 +15891,7 @@ In such cases, "crashing" is simply leaving error handling to the next level of
void f(int n) void f(int n)
{ {
// ... // ...
p = static_cast<X*>(malloc(n, X)); p = static_cast<X*>(malloc(n * sizeof(X)));
if (!p) abort(); // abort if memory is exhausted if (!p) abort(); // abort if memory is exhausted
// ... // ...
} }