From a3ae12b20e15b2a87a8944ec2e6d7c8a48213142 Mon Sep 17 00:00:00 2001 From: Florian Bramer Date: Thu, 16 Mar 2023 04:03:52 +0100 Subject: [PATCH] Fixed typo (#2055) Section C.21 shows a code example which typed a class name in two different ways: - CloneableBase - ClonableBase It is easy to overlook but it would not compile. My commit prefers CloneableBase over ClonableBase and uses just that name then. I prefered CloneableBase because Java's SDK uses the same writing, so I guess this can be consired to be more widely used. --- CppCoreGuidelines.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index b1da68b..b22ce5d 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -4945,15 +4945,15 @@ defined as defaulted. To prevent slicing as per [C.67](#Rc-copy-virtual), make the copy and move operations protected or `=delete`d, and add a `clone`: - class ClonableBase { + class CloneableBase { public: - virtual unique_ptr clone() const; - virtual ~ClonableBase() = default; + virtual unique_ptr clone() const; + virtual ~CloneableBase() = default; CloneableBase() = default; - ClonableBase(const ClonableBase&) = delete; - ClonableBase& operator=(const ClonableBase&) = delete; - ClonableBase(ClonableBase&&) = delete; - ClonableBase& operator=(ClonableBase&&) = delete; + CloneableBase(const CloneableBase&) = delete; + CloneableBase& operator=(const CloneableBase&) = delete; + CloneableBase(CloneableBase&&) = delete; + CloneableBase& operator=(CloneableBase&&) = delete; // ... other constructors and functions ... };