StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Fix cpplint issues

Browse Source 
Rconc-create0.cpp:20:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
Res-always5.cpp:15:  Missing space after ,  [whitespace/comma] [3]
Rp-lib0.cpp:15:  Missing space after ,  [whitespace/comma] [3]
Rs-using-directive0.cpp:25:  Extra space after ( in function call  [whitespace/parens] [4]
Rs-using-directive0.cpp:25:  Extra space before )  [whitespace/parens] [2]
This commit is contained in:
Jacob Langley 2017-02-13 13:14:42 -08:00 committed by Thibault Kruse
parent 48b40df328
commit a2dba2e78b
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
CppCoreGuidelines.md
View File

@ -1067,7 +1067,7 @@ So, if a suitable library exists for your application domain, use it.
##### Example ##### Example
std::sort(begin(v),end(v),std::greater<>()); std::sort(begin(v), end(v), std::greater<>());
Unless you are an expert in sorting algorithms and have plenty of time, Unless you are an expert in sorting algorithms and have plenty of time,
this is more likely to be correct and to run faster than anything you write for a specific application. this is more likely to be correct and to run faster than anything you write for a specific application.
@ -9105,7 +9105,7 @@ Readability. Minimize resource retention.
Note: C++17 also adds `if` and `switch` initializer statements. These require C++17 support. Note: C++17 also adds `if` and `switch` initializer statements. These require C++17 support.
map<int,string> mymap; map<int, string> mymap;
if (auto result = mymap.insert(value); result.second) { if (auto result = mymap.insert(value); result.second) {
// insert succeeded, and result is valid for this block // insert succeeded, and result is valid for this block
@ -9508,7 +9508,7 @@ Assuming that there is a logical connection between `i` and `j`, that connection
Obviously, what we really would like is a construct that initialized n variables from a `tuple`. For example: Obviously, what we really would like is a construct that initialized n variables from a `tuple`. For example:
auto [i,j] = make_related_widgets(cond); // C++17, not C++14 auto [i, j] = make_related_widgets(cond); // C++17, not C++14
Today, we might approximate that using `tie()`: Today, we might approximate that using `tie()`:
@ -12494,8 +12494,7 @@ Thread creation is expensive.
// process // process
} }
void void master(istream& is)
(istream& is)
{ {
for (Message m; is >> m; ) for (Message m; is >> m; )
run_list.push_back(new thread(worker, m)); run_list.push_back(new thread(worker, m));
@ -16574,10 +16573,10 @@ Doing so takes away an `#include`r's ability to effectively disambiguate and to
// user.cpp // user.cpp
#include "bad.h" #include "bad.h"
bool copy( /*... some parameters ...*/); // some function that happens to be named copy bool copy(/*... some parameters ...*/); // some function that happens to be named copy
int main() { int main() {
copy( /*...*/ ); // now overloads local ::copy and std::copy, could be ambiguous copy(/*...*/); // now overloads local ::copy and std::copy, could be ambiguous
} }
##### Enforcement ##### Enforcement