StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Fix bugs in examples

Browse Source
This commit is contained in:
Johannes Laire 2015-09-29 11:00:13 +02:00
parent d01a414fed
commit 9a976c8a85
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
CppCoreGuidelines.md
View File

@ -808,8 +808,8 @@ Prefer [RAII](#Rr-raii):
if (p==nullptr) throw Nullptr_error{}; if (p==nullptr) throw Nullptr_error{};
int n = strlen(p); int n = strlen(p);
auto buf = new char[n]; auto buf = new char[n];
for (int i = 0; i<n; ++i) buf[i] = p[i];
if (buf==nullptr) throw Allocation_error{}; if (buf==nullptr) throw Allocation_error{};
for (int i = 0; i<n; ++i) buf[i] = p[i];
// ... manipulate buffer ... // ... manipulate buffer ...
X x; X x;
x.ch = 'a'; x.ch = 'a';
@ -1639,7 +1639,7 @@ If there was a need, we could further templatize `read()` and `print()` on the d
{ {
input >> value; input >> value;
// check for errors // check for errors
} };
auto print(auto& output, const auto& value) auto print(auto& output, const auto& value)
{ {
@ -1736,7 +1736,7 @@ Small simple functions are easily inlined where the cost of a function call is s
constexpr int max_exp = 17; // constexpr enables this to be used in Expects constexpr int max_exp = 17; // constexpr enables this to be used in Expects
Expects(0<=n && n<max_exp); // prevent silliness and overflow Expects(0<=n && n<max_exp); // prevent silliness and overflow
int x = 1; int x = 1;
for (int i=2; i<=n; ++i) x*= n; for (int i=2; i<=n; ++i) x*= i;
return x; return x;
} }
@ -2013,7 +2013,7 @@ When I call `length(r)` should I test for `r==nullptr` first? Should the impleme
**Example**: **Example**:
X* find(array_view<X> r, const X& v) // find v in r X* find(array_view<X> r, const X& v); // find v in r
vector<X> vec; vector<X> vec;
// ... // ...