From 7a4fbef3701d8de55270ae2e09b4c13144f9aa44 Mon Sep 17 00:00:00 2001 From: tvaneerd Date: Tue, 22 Mar 2016 11:51:30 -0400 Subject: [PATCH] remove use of == on doubles could use an epsilon, but that just distracts from the point of the example, so changed double to int instead --- CppCoreGuidelines.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index dbd3230..e879e8d 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -10211,15 +10211,13 @@ Note that this applies most urgently to library code and least urgently to stand ##### Example - double cached_computation(double x) + double cached_computation(int x) { - static double cached_x = 0.0; + static int cached_x = 0; static double cached_result = COMPUTATION_OF_ZERO; - double result; - if (cached_x == x) return cached_result; - result = computation(x); + double result = computation(x); cached_x = x; cached_result = result; return result;