StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Merge pull request #1164 from ChrisGuzak/ChrisGuzak-sizeof-not_max

Browse Source 
use sizeof(buffer) instead of MAX
This commit is contained in:
Gabriel Dos Reis 2018-03-22 16:15:32 -07:00 committed by GitHub
commit 644e0f5b5e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CppCoreGuidelines.md
View File

@ -1584,7 +1584,7 @@ Consider a famous security bug:
{ {
char buffer[MAX]; char buffer[MAX];
// ... // ...
memset(buffer, 0, MAX); memset(buffer, 0, sizeof(buffer));
} }
There was no postcondition stating that the buffer should be cleared and the optimizer eliminated the apparently redundant `memset()` call: There was no postcondition stating that the buffer should be cleared and the optimizer eliminated the apparently redundant `memset()` call:
@ -1593,7 +1593,7 @@ There was no postcondition stating that the buffer should be cleared and the opt
{ {
char buffer[MAX]; char buffer[MAX];
// ... // ...
memset(buffer, 0, MAX); memset(buffer, 0, sizeof(buffer));
Ensures(buffer[0] == 0); Ensures(buffer[0] == 0);
} }