From 2f5434afc7978cb7f16ce83c9c760b16d7957829 Mon Sep 17 00:00:00 2001 From: Modanung Date: Fri, 20 Mar 2020 12:47:44 +0100 Subject: [PATCH] Reverted erroneous modifications --- CppCoreGuidelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 3a0af89..9ae09ad 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -898,7 +898,7 @@ Don't repeatedly check the same value. Don't pass structured data as strings: void user1(const string& date) // manipulate date { - auto d{ extract_date(date) }; + auto d = extract_date(date); // ... } @@ -924,7 +924,7 @@ There are cases where checking early is dumb because you may not ever need the v float e; public: - Jet(float , float y, float z, float e) + Jet(float x, float y, float z, float e) :x{ x }, y{ y }, z{ z }, e{ e } { // Should I check here that the values are physically meaningful?