StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

ES.61 clarify wording (#2137)

Browse Source 
The original text was "If the `new` and the `delete` are in the same scope, mistakes can be flagged." This has been [misinterpreted](https://stackoverflow.com/q/75905524) to mean "Any `new` and `delete` in the same scope is a mistake and should be flagged."

Reword the Enforcement clauses to follow the pattern established by the other Enforcement clauses: "Flag (bad thing)". Also, call the issue a "mismatch" rather than a "mistake", so that it is more clear that the underlying issue is the mismatch between scalar and array new/deletion.
This commit is contained in:
Raymond Chen 2023-09-28 15:00:36 -07:00 committed by GitHub
parent 5eb1467d5e
commit 27e662bebb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CppCoreGuidelines.md
View File

@ -12474,7 +12474,7 @@ Flag naked `new`s and naked `delete`s.
##### Reason ##### Reason
That's what the language requires and mistakes can lead to resource release errors and/or memory corruption. That's what the language requires, and mismatches can lead to resource release errors and/or memory corruption.
##### Example, bad ##### Example, bad
@ -12491,8 +12491,8 @@ This example not only violates the [no naked `new` rule](#Res-new) as in the pre
##### Enforcement ##### Enforcement
* If the `new` and the `delete` are in the same scope, mistakes can be flagged. * Flag mismatched `new` and `delete` if they are in the same scope.
* If the `new` and the `delete` are in a constructor/destructor pair, mistakes can be flagged. * Flag mismatched `new` and `delete` if they are in a constructor/destructor pair.
### <a name="Res-arr2"></a>ES.62: Don't compare pointers into different arrays ### <a name="Res-arr2"></a>ES.62: Don't compare pointers into different arrays