From 1fd6ce78c204140c78a25096734732107e388c5b Mon Sep 17 00:00:00 2001 From: Amir Livneh Date: Sat, 16 Feb 2019 05:08:58 -0800 Subject: [PATCH] Fix typo and grammar (#1329) --- CppCoreGuidelines.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 7be62fe..0bc6247 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -5575,7 +5575,7 @@ An initialization explicitly states that initialization, rather than assignment, class A { // Good string s1; public: - A(czstring p) : s1{p} { } // GOOD: directly construct (and the C-sting is explicitly named) + A(czstring p) : s1{p} { } // GOOD: directly construct (and the C-string is explicitly named) // ... }; @@ -6819,7 +6819,7 @@ Do *not* represent non-hierarchical domain concepts as class hierarchies. Here most overriding classes cannot implement most of the functions required in the interface well. Thus the base class becomes an implementation burden. -Furthermore, the user of `Container` cannot rely on the member functions actually performing a meaningful operations reasonably efficiently; +Furthermore, the user of `Container` cannot rely on the member functions actually performing meaningful operations reasonably efficiently; it may throw an exception instead. Thus users have to resort to run-time checking and/or not using this (over)general interface in favor of a particular interface found by a run-time type inquiry (e.g., a `dynamic_cast`).