StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Merge pull request #207 from tryfinally/patch-2

Browse Source 
typo fixes: constxp -> constexpr, spaces
This commit is contained in:
Gabriel Dos Reis 2015-09-29 02:15:12 -07:00
commit 1a3b28260f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
CppCoreGuidelines.md
View File

@ -7264,20 +7264,20 @@ The call will most likely be `f(0, 1)` or `f(1, 0)`, but you don't know which. T
**Example**: **Example**:
for (int m = 1; m<=12; ++m) // don't: magic constant 12 for (int m = 1; m <= 12; ++m) // don't: magic constant 12
cout << month[m] << '\n'; cout << month[m] << '\n';
No, we don't all know that there a 12 month, numbered 1..12, in a year. Better: No, we don't all know that there a 12 month, numbered 1..12, in a year. Better:
constexp int last_month = 12; // months are numbered 1..12 constexpr int last_month = 12; // months are numbered 1..12
for (int m = first_month; m<=last_month; ++m) // better for (int m = first_month; m <= last_month; ++m) // better
cout << month[m] << '\n'; cout << month[m] << '\n';
Better still, don't expose constants: Better still, don't expose constants:
for(auto m : month) for(auto m : month)
cout << m <<'\n'; cout << m << '\n';
**Enforcement**: Flag literals in code. Give a pass to `0`, `1`, `nullptr`, `\n`, `""`, and others on a positive list. **Enforcement**: Flag literals in code. Give a pass to `0`, `1`, `nullptr`, `\n`, `""`, and others on a positive list.